Merge pull request #82 from aligent/feature/SL-443-update-route-resolver-cms-page

SL-443 CMS pages from BC were being returned even when they were set to hidden. This was likly missed due to the different behaviors of AC and BC APIs.

Author: jackmacaa

packages/modules/bigcommerce/src/apis/graphql/route.ts

@@ -6,6 +6,7 @@ import {
     ContactPage,
     NormalPage,
     Product,
+    RawHtmlPage,
     SiteRouteArgs,
 } from '@aligent/bigcommerce-operations';
 import { logAndThrowError } from '@aligent/utils';
@@ -15,7 +16,9 @@ import { getRouteQuery } from './requests';
 export const getRoute = async (
     variables: SiteRouteArgs & { includeTax?: boolean },
     customerImpersonationToken: string
-): Promise<Blog | BlogPost | Brand | Category | ContactPage | NormalPage | Product> => {
+): Promise<
+    Blog | BlogPost | Brand | Category | ContactPage | NormalPage | Product | RawHtmlPage
+> => {
     const headers = {
         Authorization: `Bearer ${customerImpersonationToken}`,
     };

packages/modules/bigcommerce/src/factories/__tests__/__data__/normal-page-data.ts

@@ -22,7 +22,7 @@ export const bcHomePageContent = {
     entityId: 17,
     parentEntityId: null,
     name: 'Big Commerce Homepage',
-    isVisibleInNavigation: false,
+    isVisibleInNavigation: true,
     seo: {
         pageTitle: '',
         metaDescription: '',

packages/modules/bigcommerce/src/factories/get-transformed-page-data.ts

@@ -8,10 +8,19 @@ type PageData = {
     htmlBody: string;
     name: string;
     seo: SeoDetailsFragment;
+    isVisibleInNavigation: boolean;
 };
 
 export const getTransformedPageData = (data: PageData, cdnUrl: string): CmsPage => {
     const { path, htmlBody, name, seo } = data;
+
+    if (data.isVisibleInNavigation === false) {
+        return {
+            redirect_code: 0,
+            __typename: 'CmsPage',
+        };
+    }
+
     return {
         url_key: path.replace(/\//g, ''),
         content: htmlBody.replace(CND_MASK, cdnUrl),

packages/modules/bigcommerce/src/resolvers/queries/route.ts

@@ -22,7 +22,7 @@ import { getBundleItemProducts } from '../../apis/graphql/bundle-item-products';
 import { retrieveCustomerImpersonationTokenFromCache } from '../../apis/rest';
 
 interface TransformedRouteData {
-    data: Blog | BlogPost | Brand | Category | ContactPage | NormalPage | Product;
+    data: Blog | BlogPost | Brand | Category | ContactPage | NormalPage | Product | RawHtmlPage;
     storeConfig: StoreConfig & Settings;
     customerImpersonationToken: string;
     taxSettings?: TaxDisplaySettings | null;
@@ -65,6 +65,7 @@ const getTransformedRouteData = async ({
 
     if (__typename === 'NormalPage' || __typename === 'RawHtmlPage') {
         const cdnUrl = storeConfig.url.cdnUrl;
+
         return {
             ...getTransformedPageData(data as NormalPage | RawHtmlPage, cdnUrl),
             type: 'CMS_PAGE',