=BG= add CLI option to specify karma reporter, either by name or with an absolute path

Author: bguiz

lib/test/karma.js

@@ -7,6 +7,8 @@ var gulp            = require('gulp'),
     querystring     = require('querystring'),
     childProcess    = require('child_process');
 
+var yargs           = require('../util/yargs');
+
 /**
  * Wrap the given value in quotation marks
  * @param {*} value The value to wrap
@@ -17,6 +19,7 @@ function quote(value) {
 }
 
 var defaultReporterName = 'angularity-karma-reporter';
+
 var filesAppendRegex = /\/\*+\s*ANGULARITY_FILE_LIST\s*\*+\// ;
 var reportersAppendRegex = /\/\*+\s*ANGULARITY_REPORTER_LIST\s*\*+\// ;
 var pluginsAppendRegex = /\/\*+\s*ANGULARITY_PLUGIN_LIST\s*\*+\// ;
@@ -200,7 +203,38 @@ function karmaRun(reporters, bannerWidth) {
   });
 };
 
+var yargsOptionDefiniton = {
+  key: 'karmareporter',
+  value: {
+    describe: 'Specify a custom Karma reporter to use. '+
+      'Either a locally npm installed module, or an asolute path to one.',
+    alias: ['k'],
+    default: defaultReporterName,
+    string:true,
+  }
+};
+var checkKarmaReporter = yargs.createCheck()
+  .withGate(function (argv) {
+    return !argv.help;
+  })
+  .withTest({
+    'karmareporter': function(value) {
+      if (typeof value === 'undefined') {
+        return;
+      }
+      try {
+        getKarmaReporterPluginPath(value);
+      }
+      catch (ex) {
+        return 'Illegal value for "reporter"\n'+ex;
+      }
+    },
+  })
+  .commit();
+
 module.exports = {
   createConfig: karmaCreateConfig,
-  run: karmaRun
+  run: karmaRun,
+  yargsCheck: checkKarmaReporter,
+  yargsOption: yargsOptionDefiniton,
 };

lib/util/jshint-reporter.js

@@ -7,16 +7,6 @@ var gulpJshint = require('gulp-jshint');
 var yargs = require('./yargs');
 
 var defaultReporterName = 'angularity-jshint-reporter';
-var yargsOptionDefiniton = {
-  key: 'reporter',
-  value: {
-    describe: 'Specify a custom JsHint reporter to use. '+
-      'Either a locally npm installed module, or an asolute path to one.',
-    alias: ['r'],
-    default: defaultReporterName,
-    string:true,
-  }
-};
 
 /**
  * Dynamically load a JsHint reporter
@@ -64,12 +54,22 @@ function getJsHintReporter(reporterName) {
   return jsHintReporter;
 }
 
+var yargsOptionDefiniton = {
+  key: 'reporter',
+  value: {
+    describe: 'Specify a custom JsHint reporter to use. '+
+      'Either a locally npm installed module, or an asolute path to one.',
+    alias: ['r'],
+    default: defaultReporterName,
+    string: true,
+  }
+};
 var checkJsHintReporter = yargs.createCheck()
   .withGate(function (argv) {
     return !argv.help;
   })
   .withTest({
-    reporter: function(value) {
+    'reporter': function(value) {
       if (typeof value === 'undefined') {
         return;
       }

tasks/javascript.js

@@ -64,9 +64,11 @@ yargs.getInstance('test')
     boolean : true
   })
   .options(jshintReporter.yargsOption.key, jshintReporter.yargsOption.value)
+  .options(karma.yargsOption.key, karma.yargsOption.value)
   .strict()
   .check(yargs.subCommandCheck)
   .check(jshintReporter.yargsCheck)
+  .check(karma.yargsCheck)
   .wrap(80);
 
 gulp.task('javascript', function (done) {
@@ -113,7 +115,17 @@ gulp.task('javascript:lint', function () {
 
 // karma unit tests in local library only
 gulp.task('javascript:unit', function () {
-  var reporters = [];
+  var reporters = cliArgs.karmareporter;
+  if (reporters.constructor === Array) {
+    reporters = Array;
+  }
+  else if (typeof reporters === 'string' &&
+      reporters !== karma.yargsOption.value.default) {
+    reporters = [reporters];
+  }
+  else {
+    reporters = [];
+  }
   return combined.create()
     .append(
       streams