=BG= swap gulp-if for gulp-filter in javascript:unit task; plus misc. minor corrections

Author: bguiz

lib/test/karma.js

@@ -3,7 +3,6 @@
 var path            = require('path');
 
 var gulp            = require('gulp'),
-    gulpIf          = require('gulp-if'),
     through         = require('through2'),
     querystring     = require('querystring'),
     childProcess    = require('child_process');
@@ -33,20 +32,15 @@ var filesAppendRegex = /\/\*+\s*ANGULARITY_FILE_LIST\s*\*+\// ;
  * @return {stream.Through} The output of this stream is expected to contain
  *   just one file: the augmented karma config file.
  */
-function karmaConfig(configFileName) {
+function karmaCreateConfig(configFileName) {
   configFileName = 'karma.conf.js';
   var files = [];
 
   function transformFn(file, encoding, done) {
     if (!file || !file.path) {
       throw 'Files must have paths';
     }
-    var stream = this;
-    //filter out all files (nothing added back to the stream)
-    //but we save file paths for later use in the flush function
-    if (path.extname(file.path) !== '.map') {
-      files.push(file.path);
-    }
+    files.push(file.path);
     done();
   }
 
@@ -126,6 +120,6 @@ function karmaRun(bannerWidth) {
 };
 
 module.exports = {
-  createConfig: karmaConfig,
+  createConfig: karmaCreateConfig,
   run: karmaRun
 };

npm-shrinkwrap.json

@@ -49,7 +49,7 @@
     "convert-source-map": "latest",
     "gulp": "latest",
     "gulp-concat": "latest",
-    "gulp-if": "latest",
+    "gulp-filter": "latest",
     "gulp-inject": "latest",
     "gulp-jshint": "latest",
     "gulp-load-plugins": "latest",

package.json

@@ -4,7 +4,7 @@ var path            = require('path'),
     fs              = require('fs');
 
 var gulp            = require('gulp'),
-    gulpIf          = require('gulp-if'),
+    gulpFilter      = require('gulp-filter'),
     jshint          = require('gulp-jshint'),
     rimraf          = require('gulp-rimraf'),
     gutil           = require('gulp-util'),
@@ -127,7 +127,8 @@ gulp.task('javascript:unit', function () {
         .pipe(browserify
           .compile(80, transforms.concat(browserify.jasmineTransform('@')))
           .all('index.js'))
-        .pipe(gulpIf('*.js', gulp.dest(streams.TEST)))
+        .pipe(gulpFilter('*.js'))
+        .pipe(gulp.dest(streams.TEST))
     )
     .pipe(karma.createConfig())
     .pipe(gulp.dest(streams.TEST))