chore: v1 implementation of bodies stub (#2400)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Jacob Kerstetter <[email protected]>

Author: 4 people

doc/changelog.d/2400.maintenance.md

@@ -0,0 +1 @@
+Chore: v1 implementation of bodies stub

src/ansys/geometry/core/_grpc/_services/v0/bodies.py

@@ -22,11 +22,9 @@
 """Module containing the bodies service implementation for v0."""
 
 import grpc
-import pint
 
 import ansys.geometry.core as pyansys_geom
 from ansys.geometry.core.errors import protect_grpc
-from ansys.geometry.core.misc.measurements import DEFAULT_UNITS
 
 from ..base.bodies import GRPCBodyService
 from ..base.conversions import from_measurement_to_server_angle, from_measurement_to_server_length
@@ -187,17 +185,19 @@ def sweep_with_guide(self, **kwargs) -> dict:  # noqa: D102
         request = SweepWithGuideRequest(
             request_data=[
                 SweepWithGuideRequestData(
-                    name=data.name,
-                    parent=build_grpc_id(data.parent_id),
-                    plane=from_plane_to_grpc_plane(data.sketch.plane),
+                    name=sweep_item.name,
+                    parent=build_grpc_id(sweep_item.parent_id),
+                    plane=from_plane_to_grpc_plane(sweep_item.sketch.plane),
                     geometries=from_sketch_shapes_to_grpc_geometries(
-                        data.sketch.plane, data.sketch.edges, data.sketch.faces
+                        sweep_item.sketch.plane,
+                        sweep_item.sketch.edges,
+                        sweep_item.sketch.faces,
                     ),
-                    path=from_trimmed_curve_to_grpc_trimmed_curve(data.path),
-                    guide=from_trimmed_curve_to_grpc_trimmed_curve(data.guide),
-                    tight_tolerance=data.tight_tolerance,
+                    path=from_trimmed_curve_to_grpc_trimmed_curve(sweep_item.path),
+                    guide=from_trimmed_curve_to_grpc_trimmed_curve(sweep_item.guide),
+                    tight_tolerance=sweep_item.tight_tolerance,
                 )
-                for data in kwargs["sweep_data"]
+                for sweep_item in kwargs["sweep_data"]
             ],
         )
 
@@ -213,8 +213,8 @@ def sweep_with_guide(self, **kwargs) -> dict:  # noqa: D102
                     "master_id": body.master_id,
                     "is_surface": body.is_surface,
                 }
+                for body in resp.bodies
             ]
-            for body in resp.bodies
         }
 
     @protect_grpc
@@ -460,11 +460,13 @@ def get_vertices(self, **kwargs) -> dict:  # noqa: D102
 
     @protect_grpc
     def get_volume(self, **kwargs) -> dict:  # noqa: D102
+        from .conversions import from_grpc_volume_to_volume
+
         # Call the gRPC service
         resp = self.stub.GetVolume(request=build_grpc_id(kwargs["id"]))
 
         # Return the response - formatted as a dictionary
-        return {"volume": pint.Quantity(resp.volume, DEFAULT_UNITS.SERVER_VOLUME)}
+        return {"volume": from_grpc_volume_to_volume(resp.volume)}
 
     @protect_grpc
     def get_bounding_box(self, **kwargs) -> dict:  # noqa: D102
@@ -796,8 +798,8 @@ def combine(self, **kwargs) -> dict:  # noqa: D102
         transfer_named_selections = kwargs["transfer_named_selections"]
 
         if type_bool_op == "intersect":
-            body_ids = [build_grpc_id(body.id) for body in other_bodies]
-            target_ids = [build_grpc_id(target_body.id)]
+            body_ids = [build_grpc_id(body) for body in other_bodies]
+            target_ids = [build_grpc_id(target_body)]
             request = CombineIntersectBodiesRequest(
                 target_selection=target_ids,
                 tool_selection=body_ids,
@@ -807,8 +809,8 @@ def combine(self, **kwargs) -> dict:  # noqa: D102
             )
             response = self.command_stub.CombineIntersectBodies(request)
         elif type_bool_op == "subtract":
-            body_ids = [build_grpc_id(body.id) for body in other_bodies]
-            target_ids = [build_grpc_id(target_body.id)]
+            body_ids = [build_grpc_id(body) for body in other_bodies]
+            target_ids = [build_grpc_id(target_body)]
             request = CombineIntersectBodiesRequest(
                 target_selection=target_ids,
                 tool_selection=body_ids,
@@ -820,7 +822,7 @@ def combine(self, **kwargs) -> dict:  # noqa: D102
         elif type_bool_op == "unite":
             bodies = [target_body]
             bodies.extend(other_bodies)
-            body_ids = [build_grpc_id(body.id) for body in bodies]
+            body_ids = [build_grpc_id(body) for body in bodies]
             request = CombineMergeBodiesRequest(target_selection=body_ids)
             response = self.command_stub.CombineMergeBodies(request)
         else:

src/ansys/geometry/core/_grpc/_services/v0/conversions.py

@@ -202,6 +202,24 @@ def from_grpc_direction_to_unit_vector(direction: GRPCDirection) -> "UnitVector3
     return UnitVector3D([direction.x, direction.y, direction.z])
 
 
+def from_grpc_volume_to_volume(grpc_volume: float) -> "pint.Quantity":
+    """Convert a gRPC volume float to a pint Quantity.
+
+    Parameters
+    ----------
+    grpc_volume : float
+        Source gRPC volume data.
+
+    Returns
+    -------
+    pint.Quantity
+        Converted volume quantity with server volume units.
+    """
+    from ansys.geometry.core.misc.measurements import DEFAULT_UNITS
+
+    return pint.Quantity(grpc_volume, DEFAULT_UNITS.SERVER_VOLUME)
+
+
 def from_line_to_grpc_line(line: "Line") -> GRPCLine:
     """Convert a ``Line`` to a line gRPC message.