fixed PythonDocker rerun matrix gating and gh setup#38199
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the stability and maintainability of the CI/CD infrastructure. It resolves a problem with the Python Docker rerun matrix gating and refactors the GitHub CLI installation within a GitHub Action, moving from a manual script to a reusable action. These changes aim to make the workflows more robust and easier to manage. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
| startsWith(github.event.comment.body, 'Run PythonDocker PreCommit') | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| if: ${{ github.event_name != 'issue_comment' || github.event.comment.body == format('{0} {1}', matrix.job_phrase, matrix.python_version) }} |
There was a problem hiding this comment.
Do we know why this specific workflow has conflict? Adding if condition for every step sounds a bit messy. If we cannot get issue comment right we can just remove issue comment trigger and use trigger file approach
There was a problem hiding this comment.
Ahh okay got it, I will remove issue_comment handling from beam_PreCommit_PythonDocker.yml and keep trigger-file/PR-path flow only
2 participants
Fixes: #38025
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.