Improve message "Network is unavailable. Please contact administrator"

[daviftorres]

Recently I had faced this message when trying to deploy a new instance in a guest network that was already in use.

I did not realized the VR was running on a version that was prior to the latest (4.20.1) and the Management server was on the latest (4.20.2).

I guest there are many ways this exception can be triggered and the message has to be generic enough to point in the right direction and cannot cover all possible cases with unique exceptions.

For my surprise, there is e in the code but it does not output any thing, so I propose to change to e.getMessage(). Maybe even adding a bit more description to the message would be appreciated but not required.

cloudstack/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java

Line 938 in 15c2e50

throw new CloudRuntimeException("Network is unavailable. Please contact administrator", e).add(VirtualMachine.class, vmUuid);

See examples/proposals below:

Or

Just "Network is unavailable" throw me off to network connectivity between Management and Agent or other connectivity issues. When in fact, it the Guest Network and its VR did not pass the criteria to be used.

Please share your thoughts and I would be glad to provide a PR for this trivial change.

[DaanHoogland]

@daviftorres , both look good to me. Feel invited to create a PR and people will add their critique on it.

Please do not feel discouraged when they do. I am not seeing them now, but there might for instance be security concerns. I think mentioning that it is a guest network should not be a problem, but the e.getMessage() might contain sensitive info.

[weizhouapache]

@daviftorres , both look good to me. Feel invited to create a PR and people will add their critique on it.

Please do not feel discouraged when they do. I am not seeing them now, but there might for instance be security concerns. I think mentioning that it is a guest network should not be a problem, but the e.getMessage() might contain sensitive info.

we can provide more details for root administrators