Skip to content

Commit 97e6315

Browse files
timsaucerclaude
andcommitted
docs: state the equality as a rule, not as a defence of it
The paragraph explained why the assertion is not a subset check, which only reads as an explanation to someone holding the previous version. Say what a maintainer should do instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 9baf121 commit 97e6315

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

python/tests/test_context.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1681,12 +1681,9 @@ def test_every_component_field_has_an_installer():
16811681
``_collect_contributions``, and resolve and install it in
16821682
``with_extensions``. Then add it below.
16831683
1684-
The dataclass is the source of truth, so the comparison is an equality and
1685-
not a subset — a subset would grow to cover a new field on its own, which
1686-
is the one case this exists to catch. A field that is deliberately not a
1687-
component collection goes in ``not_components`` rather than into
1688-
``_COMPONENT_NOUNS``, which is what keeps that exemption a decision someone
1689-
made instead of an operator someone loosened.
1684+
Keep the comparison an equality. A subset check is satisfied by any new
1685+
field on its own, which is the one case this exists to catch. A field that
1686+
is deliberately not a component collection belongs in ``not_components``.
16901687
"""
16911688
from datafusion.extensions import _COMPONENT_NOUNS
16921689

0 commit comments

Comments
 (0)