Repository navigation
Commit 1f241cf
authored
[chore](ci) Connect PR checks and comment triggers to current TeamCity (#70459)
### Background
Doris PR comments use the existing workflow and shell helper to select
and trigger TeamCity pipelines. This migration replaces the retired
environment and embedded credentials with the current TeamCity and a
dedicated token.
### What problem does this PR solve?
Issue Number: None
Related PR: None
PR Type: Build/CI/Chore
Problem Summary:
Connect master, branch-4.2 and branch-4.1 PR checks and comment commands
to the current TeamCity. Preserve file-based trigger/skip selection and
authorized `skip buildall`. Keep the comment entry point simple: submit
the requested pipeline with PR number, target branch and an exact VCS
revision; artifact resolution remains the target pipeline's
responsibility.
### Details
- **Change map:** The existing shell helper is 210 lines; tests cover
direct submission, command parsing, file filters, skip status coverage,
authorization and credential tracing. The workflow retains the original
file-selection functions; `.asf.yaml` updates required contexts for
three branches. No separate production Python client or new
dependencies.
- **Affected:** Compile, FEUT, BEUT, CloudUT, P0, CloudP0, VaultP0 and
NonConcurrent remain required. External and Performance are optional.
Current command keywords match the `TeamCity/<keyword>` status suffix.
- **Developer and release impact:** `run p0` submits P0 directly, with
only `env.PR_NUMBER` and `env.CI_BRANCH` as business parameters and the
commit in TeamCity's native revision field. The client does not search
or convert artifact manifests, choose producers, automatically compile
missing artifacts, override artifact dependencies or deduplicate
requests. TeamCity owns artifact retrieval and queue replacement. `run
buildall` and the existing authorized `skip buildall` policy remain;
Performance is enabled only for master using a positive branch
condition. Temporary validation VCS roots are rejected before
submission.
- **File selection:** Existing FEUT, BEUT, CloudUT, regression and
Performance file-pattern functions remain unchanged.
`trigger_or_skip_build` submits related changes and publishes skip
statuses for unrelated changes. Skipping Compile also resolves its five
downstream checks. Failed file lookups do not falsely select a skip.
- **Behavior change:** The new environment publishes current check
names; External and Performance no longer block merges. Commands run
trusted default-branch code. Token authentication replaces the retired
endpoint and public account credentials; authenticated requests are not
traced.
- **License and third-party:** Existing Apache licensing; no dependency
additions.
- **Rollback:** Revert workflow routing and required-context changes
together without restoring retired credentials or interrupting running
builds.
### Testing
- Local: 26 tests pass, including direct submission of all five
regression lanes with only two business parameters; exact revision
binding; repeated submissions; file filtering; skip buildall permissions
and status coverage on master and both release branches; stale heads;
HTTP failures; and token redaction.
- Local: actionlint, shell syntax validation and git diff --check pass.
- Live: Previous CloudUT submission through the existing shell helper
completed successfully on branch-4.2 (764 passed, 27 ignored). Earlier
Compile canaries completed on all three branches. These results predate
this final simplification.
- Live: Final direct P0 submission
[1065](https://8.218.164.131/buildConfiguration/Doris_P0/1065) retained
the exact requested commit and did not create a Compile dependency. It
failed before execution because the target pipeline still selects build
number `UNBOUND`; commit-based artifact lookup is not implemented there
yet. Compile 852 has an unexpired artifact manifest for this exact
PR/head, so this failure is a pipeline lookup gap rather than missing
compilation. All five regression configurations currently use the same
UNBOUND default. CloudUT canaries
[1066](https://8.218.164.131/buildConfiguration/Doris_CloudUT/1066)
(master),
[1067](https://8.218.164.131/buildConfiguration/Doris_CloudUT/1067)
(branch-4.2), and
[1068](https://8.218.164.131/buildConfiguration/Doris_CloudUT/1068)
(branch-4.1) are running. The live harness uses the committed shell
helper and substitutes server-local authentication/PR-read transport; it
does not post GitHub comments.
### Notes for Reviewers
The issue_comment workflow becomes active only after merge into the
default branch. Live branch protection must be checked after ASF
reconciliation. Regression pipelines must resolve artifacts for the
requested commit and fail when unavailable; the comment client
deliberately has no producer fallback. The experimental commit-tag
approach is not part of this PR and has not been deployed to production
regression configurations. Performance's temporary validation VCS
configuration still prevents general PR comment runs.1 parent 9d8ce75 commit 1f241cf
5 files changed
Lines changed: 557 additions & 519 deletions
File tree
- .github/workflows
- regression-test/pipeline/common
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
| 46 | + | |
45 | 47 | | |
46 | 48 | | |
47 | 49 | | |
| |||
50 | 52 | | |
51 | 53 | | |
52 | 54 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
63 | | - | |
| 64 | + | |
64 | 65 | | |
65 | | - | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
88 | 87 | | |
89 | 88 | | |
90 | 89 | | |
| |||
97 | 96 | | |
98 | 97 | | |
99 | 98 | | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
109 | 107 | | |
110 | 108 | | |
111 | 109 | | |
| |||
0 commit comments