Skip to content

Commit 1f241cf

Browse files
[chore](ci) Connect PR checks and comment triggers to current TeamCity (#70459)
### Background Doris PR comments use the existing workflow and shell helper to select and trigger TeamCity pipelines. This migration replaces the retired environment and embedded credentials with the current TeamCity and a dedicated token. ### What problem does this PR solve? Issue Number: None Related PR: None PR Type: Build/CI/Chore Problem Summary: Connect master, branch-4.2 and branch-4.1 PR checks and comment commands to the current TeamCity. Preserve file-based trigger/skip selection and authorized `skip buildall`. Keep the comment entry point simple: submit the requested pipeline with PR number, target branch and an exact VCS revision; artifact resolution remains the target pipeline's responsibility. ### Details - **Change map:** The existing shell helper is 210 lines; tests cover direct submission, command parsing, file filters, skip status coverage, authorization and credential tracing. The workflow retains the original file-selection functions; `.asf.yaml` updates required contexts for three branches. No separate production Python client or new dependencies. - **Affected:** Compile, FEUT, BEUT, CloudUT, P0, CloudP0, VaultP0 and NonConcurrent remain required. External and Performance are optional. Current command keywords match the `TeamCity/<keyword>` status suffix. - **Developer and release impact:** `run p0` submits P0 directly, with only `env.PR_NUMBER` and `env.CI_BRANCH` as business parameters and the commit in TeamCity's native revision field. The client does not search or convert artifact manifests, choose producers, automatically compile missing artifacts, override artifact dependencies or deduplicate requests. TeamCity owns artifact retrieval and queue replacement. `run buildall` and the existing authorized `skip buildall` policy remain; Performance is enabled only for master using a positive branch condition. Temporary validation VCS roots are rejected before submission. - **File selection:** Existing FEUT, BEUT, CloudUT, regression and Performance file-pattern functions remain unchanged. `trigger_or_skip_build` submits related changes and publishes skip statuses for unrelated changes. Skipping Compile also resolves its five downstream checks. Failed file lookups do not falsely select a skip. - **Behavior change:** The new environment publishes current check names; External and Performance no longer block merges. Commands run trusted default-branch code. Token authentication replaces the retired endpoint and public account credentials; authenticated requests are not traced. - **License and third-party:** Existing Apache licensing; no dependency additions. - **Rollback:** Revert workflow routing and required-context changes together without restoring retired credentials or interrupting running builds. ### Testing - Local: 26 tests pass, including direct submission of all five regression lanes with only two business parameters; exact revision binding; repeated submissions; file filtering; skip buildall permissions and status coverage on master and both release branches; stale heads; HTTP failures; and token redaction. - Local: actionlint, shell syntax validation and git diff --check pass. - Live: Previous CloudUT submission through the existing shell helper completed successfully on branch-4.2 (764 passed, 27 ignored). Earlier Compile canaries completed on all three branches. These results predate this final simplification. - Live: Final direct P0 submission [1065](https://8.218.164.131/buildConfiguration/Doris_P0/1065) retained the exact requested commit and did not create a Compile dependency. It failed before execution because the target pipeline still selects build number `UNBOUND`; commit-based artifact lookup is not implemented there yet. Compile 852 has an unexpired artifact manifest for this exact PR/head, so this failure is a pipeline lookup gap rather than missing compilation. All five regression configurations currently use the same UNBOUND default. CloudUT canaries [1066](https://8.218.164.131/buildConfiguration/Doris_CloudUT/1066) (master), [1067](https://8.218.164.131/buildConfiguration/Doris_CloudUT/1067) (branch-4.2), and [1068](https://8.218.164.131/buildConfiguration/Doris_CloudUT/1068) (branch-4.1) are running. The live harness uses the committed shell helper and substitutes server-local authentication/PR-read transport; it does not post GitHub comments. ### Notes for Reviewers The issue_comment workflow becomes active only after merge into the default branch. Live branch protection must be checked after ASF reconciliation. Regression pipelines must resolve artifacts for the requested commit and fail when unavailable; the comment client deliberately has no producer fallback. The experimental commit-tag approach is not part of this PR and has not been deployed to production regression configurations. Performance's temporary validation VCS configuration still prevents general PR comment runs.
1 parent 9d8ce75 commit 1f241cf

5 files changed

Lines changed: 557 additions & 519 deletions

File tree

‎.asf.yaml‎

Lines changed: 26 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ github:
4242
merge: false
4343
rebase: false
4444
protected_branches:
45+
# master, branch-4.2 and branch-4.1 use the migrated TeamCity contexts.
46+
# External and Performance report results without gating these branches.
4547
master:
4648
required_status_checks:
4749
strict: false
@@ -50,20 +52,18 @@ github:
5052
- Check for secrets
5153
- Clang Formatter
5254
- CheckStyle
53-
- P0 Regression (Doris Regression)
54-
- NonConcurrent Regression (nonConcurrent)
55-
- External Regression (Doris External Regression)
56-
- cloud_p0 (Doris Cloud Regression)
57-
- vault_p0 (Doris Cloud Regression)
58-
- FE UT (Doris FE UT)
59-
- BE UT (Doris BE UT)
55+
- TeamCity/p0
56+
- TeamCity/nonconcurrent
57+
- TeamCity/cloud_p0
58+
- TeamCity/vault_p0
59+
- TeamCity/feut
60+
- TeamCity/beut
6061
- Build Third Party Libraries (Linux)
6162
- Build Third Party Libraries (macOS)
6263
- Build Third Party Libraries (macOS-arm64)
63-
- COMPILE (DORIS_COMPILE)
64+
- TeamCity/compile
6465
- code-review
65-
- Cloud UT (Doris Cloud UT)
66-
- performance (Doris Performance)
66+
- TeamCity/cloudut
6767
required_pull_request_reviews:
6868
dismiss_stale_reviews: true
6969
require_code_owner_reviews: true
@@ -76,15 +76,14 @@ github:
7676
- Clang Formatter
7777
- CheckStyle
7878
- Build Broker
79-
- FE UT (Doris FE UT)
80-
- BE UT (Doris BE UT)
81-
- Cloud UT (Doris Cloud UT)
82-
- COMPILE (DORIS_COMPILE)
83-
- P0 Regression (Doris Regression)
84-
- NonConcurrent Regression (nonConcurrent)
85-
- External Regression (Doris External Regression)
86-
- cloud_p0 (Doris Cloud Regression)
87-
- vault_p0 (Doris Cloud Regression)
79+
- TeamCity/feut
80+
- TeamCity/beut
81+
- TeamCity/cloudut
82+
- TeamCity/compile
83+
- TeamCity/p0
84+
- TeamCity/nonconcurrent
85+
- TeamCity/cloud_p0
86+
- TeamCity/vault_p0
8887
required_pull_request_reviews:
8988
require_code_owner_reviews: true
9089
required_approving_review_count: 1
@@ -97,15 +96,14 @@ github:
9796
- Clang Formatter
9897
- CheckStyle
9998
- Build Broker
100-
- FE UT (Doris FE UT)
101-
- BE UT (Doris BE UT)
102-
- Cloud UT (Doris Cloud UT)
103-
- COMPILE (DORIS_COMPILE)
104-
- P0 Regression (Doris Regression)
105-
- NonConcurrent Regression (nonConcurrent)
106-
- External Regression (Doris External Regression)
107-
- cloud_p0 (Doris Cloud Regression)
108-
- vault_p0 (Doris Cloud Regression)
99+
- TeamCity/feut
100+
- TeamCity/beut
101+
- TeamCity/cloudut
102+
- TeamCity/compile
103+
- TeamCity/p0
104+
- TeamCity/nonconcurrent
105+
- TeamCity/cloud_p0
106+
- TeamCity/vault_p0
109107
required_pull_request_reviews:
110108
require_code_owner_reviews: true
111109
required_approving_review_count: 1

0 commit comments

Comments
 (0)