Repository navigation
Conversation
Member
Author
|
run buildall |
Member
Author
|
run compile |
Member
Author
|
run p0 |
Member
Author
|
run external |
### What problem does this PR solve? Related PR: apache#69434 Problem Summary: A 4.0 backend sends Variant V1 without a trailing doc-value map. A 4.2 V1 receiver reads that map and can crash during load or exchange. Use the presence of the existing doc-mode field to reject the old layout before reading Variant bytes. Current V1 writers set the field even with doc mode disabled. Variant V2 uses its existing reader. ### Release note A 4.2 backend reports an explicit error when it receives an incompatible legacy Variant block during a mixed-version transfer. ### Check List (For Author) - Test: clang-format 16 and git diff --check. Runtime validation is tracked in the PR. - Behavior changed: Yes. Incompatible legacy Variant blocks return NotSupported. - Does this need documentation: No
### What problem does this PR solve? Related PR: apache#69434 Problem Summary: Check legacy V1 metadata rejection through a nullable Variant inside a struct, including a Snappy block. Exercise 4.2 V1 in both doc modes and V2 as successful controls. ### Release note None ### Check List (For Author) - Test: clang-format 16 and git diff --check. ASAN test execution is tracked in the PR. - Behavior changed: No - Does this need documentation: No
eldenmoon
force-pushed
the
branch-pick-69434-4.2
branch
from
November 12, 2026 02:10
b699ea3 to
1373c02
Compare
Member
Author
|
run buildall |
Member
Author
|
run compile |
1 similar comment
Member
Author
|
run compile |
Member
Author
|
run feut |
Member
Author
|
run external |
Member
Author
|
run nonConcurrent |
1 similar comment
Member
Author
|
run nonConcurrent |
Member
Author
|
run nonconcurrent |
Member
Author
|
run external |
Member
Author
|
run nonConcurrent |
Member
Author
|
run nonconcurrent |
Member
Author
|
run external |
4 similar comments
Member
Author
|
run external |
Member
Author
|
run external |
Member
Author
|
run external |
Member
Author
|
run external |
Member
Author
|
run nonConcurrent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #69434