-
Notifications
You must be signed in to change notification settings - Fork 14.8k
MINOR: Bump LATEST_PRODUCTION to 4.2-IV1 #20977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Bump LATEST_PRODUCTION to 4.2-IV1 #20977
Conversation
tests/kafkatest/version.py
Outdated
| LATEST_4_2 = V_4_2_1 | ||
|
|
||
| # 4.3.x version | ||
| V_4_3_0 = KafkaVersion("4.3.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this is unused. We would only need to add this after we release AK 4.3.0, and only for trunk / 4.4.0-SNAPSHOT version.
tests/kafkatest/version.py
Outdated
| V_4_2_0 = KafkaVersion("4.2.0") | ||
| LATEST_4_2 = V_4_2_0 | ||
| V_4_2_1 = KafkaVersion("4.2.1") | ||
| LATEST_4_2 = V_4_2_1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems not to be correct... We use LATEST_4_2 in system tests, but 4.2.1 is no release yet, so this might break system test trying to test 4.2.0 is they only specify LATEST_4_2 (what most system test do...)
And for trunk (in contrast to 4.2 branch), after 4.2.0 was release, we are going to use LATEST_4_2, and it must point to 4.2.0 not to unreleased 4.2.1 to work as expected, and not break system tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks for the review.
mjsax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bump latest production metadata version to 4.2-IV1 to enable share groups and streams groups by default. Reviewers: Matthias J. Sax <[email protected]>
|
@AndrewJSchofield Are you going to cherry-pick this to the 4.2 branch? |
Bump latest production metadata version to 4.2-IV1 to enable share
groups and streams groups by default.
Reviewers: Matthias J. Sax [email protected]