format

xuzifu666 · xuzifu666 · commit 455175a760df · 2025-08-21T21:48:55.000+08:00
diff --git a/src/commands/command_parser.h b/src/commands/command_parser.h
@@ -33,7 +33,7 @@
 
 template <typename Iter>
 struct MoveIterator : Iter {
-  explicit MoveIterator(Iter iter) : Iter(iter){};
+  explicit MoveIterator(Iter iter) : Iter(iter) {};
 
   typename Iter::value_type&& operator*() const { return std::move(this->Iter::operator*()); }
 };
diff --git a/src/commands/commander.cc b/src/commands/commander.cc
@@ -100,10 +100,7 @@ StatusOr<std::vector<int>> CommandTable::GetKeysFromCommand(const CommandAttribu
       [&](const std::vector<std::string> &, CommandKeyRange key_range) {
         key_range.ForEachKeyIndex([&](int i) { key_indexes.push_back(i); }, cmd_tokens.size());
       },
-      cmd_tokens,
-      [&](const auto &) {
-        status = {Status::NotOK, "The command has no key arguments"};
-      });
+      cmd_tokens, [&](const auto &) { status = {Status::NotOK, "The command has no key arguments"}; });
 
   if (!status) {
     return status;
diff --git a/src/common/cron.h b/src/common/cron.h
@@ -36,7 +36,7 @@ struct CronPattern {
 
   struct Interval {
     int interval;
-  };                                                         // */n
+  };  // */n
   struct Any {};                                             // *
   using Numbers = std::vector<std::variant<Number, Range>>;  // 1,2,3-6,7
 
diff --git a/src/common/rdb_stream.h b/src/common/rdb_stream.h
@@ -47,7 +47,7 @@ class RdbStream {
 
 class RdbStringStream : public RdbStream {
  public:
-  explicit RdbStringStream(std::string_view input) : input_(input){};
+  explicit RdbStringStream(std::string_view input) : input_(input) {};
   RdbStringStream(const RdbStringStream &) = delete;
   RdbStringStream &operator=(const RdbStringStream &) = delete;
   ~RdbStringStream() override = default;
@@ -65,7 +65,7 @@ class RdbStringStream : public RdbStream {
 class RdbFileStream : public RdbStream {
  public:
   explicit RdbFileStream(std::string file_name, size_t chunk_size = 1024 * 1024)
-      : file_name_(std::move(file_name)), check_sum_(0), total_read_bytes_(0), max_read_chunk_size_(chunk_size){};
+      : file_name_(std::move(file_name)), check_sum_(0), total_read_bytes_(0), max_read_chunk_size_(chunk_size) {};
   RdbFileStream(const RdbFileStream &) = delete;
   RdbFileStream &operator=(const RdbFileStream &) = delete;
   ~RdbFileStream() override = default;
diff --git a/src/common/status.h b/src/common/status.h
@@ -181,7 +181,7 @@ struct StringInStatusOr<T, std::enable_if_t<sizeof(T) < sizeof(std::string)>> :
   StringInStatusOr(StringInStatusOr<U>&& v) : BaseType(new std::string(*std::move(v))) {}  // NOLINT
   template <typename U, typename std::enable_if_t<!StringInStatusOr<U>::inplace, int> = 0>
   StringInStatusOr(StringInStatusOr<U>&& v)  // NOLINT
-      : BaseType((typename StringInStatusOr<U>::BaseType &&)(std::move(v))) {}
+      : BaseType((typename StringInStatusOr<U>::BaseType&&)(std::move(v))) {}
 
   StringInStatusOr(const StringInStatusOr& v) = delete;
 
diff --git a/src/common/string_util.h b/src/common/string_util.h
@@ -79,8 +79,7 @@ std::string StringJoin(const T &con, F &&f, std::string_view sep = ", ") {
 
 template <typename T>
 std::string StringJoin(const T &con, std::string_view sep = ", ") {
-  return StringJoin(
-      con, [](const auto &v) -> decltype(auto) { return v; }, sep);
+  return StringJoin(con, [](const auto &v) -> decltype(auto) { return v; }, sep);
 }
 
 }  // namespace util
diff --git a/src/config/config.cc b/src/config/config.cc
@@ -125,8 +125,8 @@ Status SetRocksdbCompression(Server *srv, const rocksdb::CompressionType compres
   for (size_t i = compression_start_level; i < KVROCKS_MAX_LSM_LEVEL; i++) {
     compression_per_level_builder.emplace_back(compression_option);
   }
-  const std::string compression_per_level = util::StringJoin(
-      compression_per_level_builder, [](const auto &s) -> decltype(auto) { return s; }, ":");
+  const std::string compression_per_level =
+      util::StringJoin(compression_per_level_builder, [](const auto &s) -> decltype(auto) { return s; }, ":");
   return srv->storage->SetOptionForAllColumnFamilies("compression_per_level", compression_per_level);
 };
 
diff --git a/src/search/interval.h b/src/search/interval.h
@@ -113,8 +113,7 @@ struct IntervalSet {
 
   std::string ToString() const {
     if (IsEmpty()) return "empty set";
-    return util::StringJoin(
-        intervals, [](const auto &i) { return Interval(i.first, i.second).ToString(); }, " or ");
+    return util::StringJoin(intervals, [](const auto &i) { return Interval(i.first, i.second).ToString(); }, " or ");
   }
 
   friend std::ostream &operator<<(std::ostream &os, const IntervalSet &is) { return os << is.ToString(); }
diff --git a/src/search/ir.h b/src/search/ir.h
@@ -232,7 +232,7 @@ struct NumericCompareExpr : BoolAtomExpr {
 struct VectorLiteral : Literal {
   std::vector<double> values;
 
-  explicit VectorLiteral(std::vector<double> &&values) : values(std::move(values)){};
+  explicit VectorLiteral(std::vector<double> &&values) : values(std::move(values)) {};
 
   std::string_view Name() const override { return "VectorLiteral"; }
   std::string Dump() const override {
diff --git a/src/search/value.h b/src/search/value.h
@@ -77,8 +77,7 @@ struct Value : std::variant<Null, Numeric, String, StringArray, NumericArray> {
     } else if (Is<String>()) {
       return Get<String>();
     } else if (Is<StringArray>()) {
-      return util::StringJoin(
-          Get<StringArray>(), [](const auto &v) -> decltype(auto) { return v; }, sep);
+      return util::StringJoin(Get<StringArray>(), [](const auto &v) -> decltype(auto) { return v; }, sep);
     } else if (Is<NumericArray>()) {
       return util::StringJoin(
           Get<NumericArray>(), [](const auto &v) -> decltype(auto) { return std::to_string(v); }, sep);
diff --git a/src/storage/rdb/rdb.h b/src/storage/rdb/rdb.h
@@ -73,7 +73,7 @@ using RedisObjValue =
 class RDB {
  public:
   explicit RDB(engine::Storage *storage, std::string ns, std::unique_ptr<RdbStream> stream)
-      : storage_(storage), ns_(std::move(ns)), stream_(std::move(stream)){};
+      : storage_(storage), ns_(std::move(ns)), stream_(std::move(stream)) {};
   ~RDB() = default;
 
   Status VerifyPayloadChecksum(const std::string_view &payload);
diff --git a/src/storage/rdb/rdb_intset.h b/src/storage/rdb/rdb_intset.h
@@ -26,7 +26,7 @@
 
 class IntSet {
  public:
-  explicit IntSet(std::string_view input) : input_(input){};
+  explicit IntSet(std::string_view input) : input_(input) {};
   ~IntSet() = default;
   StatusOr<std::vector<std::string>> Entries();
 
diff --git a/src/storage/rdb/rdb_listpack.h b/src/storage/rdb/rdb_listpack.h
@@ -26,7 +26,7 @@
 
 class ListPack {
  public:
-  explicit ListPack(std::string_view input) : input_(input){};
+  explicit ListPack(std::string_view input) : input_(input) {};
   ~ListPack() = default;
 
   StatusOr<uint32_t> Length();
diff --git a/src/storage/rdb/rdb_ziplist.h b/src/storage/rdb/rdb_ziplist.h
@@ -32,7 +32,7 @@ constexpr const uint8_t zlEnd = 0xFF;
 
 class ZipList {
  public:
-  explicit ZipList(std::string_view input) : input_(input){};
+  explicit ZipList(std::string_view input) : input_(input) {};
   ~ZipList() = default;
 
   StatusOr<std::string> Next();
diff --git a/src/storage/rdb/rdb_zipmap.h b/src/storage/rdb/rdb_zipmap.h
@@ -27,7 +27,7 @@
 
 class ZipMap {
  public:
-  explicit ZipMap(std::string_view input) : input_(input){};
+  explicit ZipMap(std::string_view input) : input_(input) {};
   ~ZipMap() = default;
 
   StatusOr<std::pair<std::string, std::string>> Next();
diff --git a/src/types/bloom_filter.h b/src/types/bloom_filter.h
@@ -92,7 +92,7 @@ StatusOr<BlockSplitBloomFilter> CreateBlockSplitBloomFilter(std::string& bitset)
 class BlockSplitBloomFilter {
  public:
   /// The constructor of BlockSplitBloomFilter. It uses XXH64 as hash function.
-  explicit BlockSplitBloomFilter(nonstd::span<char> data) : data_(data){};
+  explicit BlockSplitBloomFilter(nonstd::span<char> data) : data_(data) {};
 
   /// Calculate optimal size according to the number of distinct values and false
   /// positive probability.
diff --git a/src/types/redis_bitmap.cc b/src/types/redis_bitmap.cc
@@ -589,18 +589,16 @@ rocksdb::Status Bitmap::BitOp(engine::Context &ctx, BitOpFlags op_flag, const st
               j += sizeof(uint64_t) * 4;
               frag_minlen -= sizeof(uint64_t) * 4;
             }
-          } else if (op_flag == kBitOpDiff
-            || op_flag == kBitOpDiff1
-            || op_flag == kBitOpAndOr) {
+          } else if (op_flag == kBitOpDiff || op_flag == kBitOpDiff1 || op_flag == kBitOpAndOr) {
             size_t processed = 0;
             size_t k = 0;
 
-            while(frag_minlen >= sizeof(uint64_t)*4) {
+            while (frag_minlen >= sizeof(uint64_t) * 4) {
               for (uint64_t i = 1; i < frag_numkeys; i++) {
-                lres[0] |= lp[i][k+0];
-                lres[1] |= lp[i][k+1];
-                lres[2] |= lp[i][k+2];
-                lres[3] |= lp[i][k+3];
+                lres[0] |= lp[i][k + 0];
+                lres[1] |= lp[i][k + 1];
+                lres[2] |= lp[i][k + 2];
+                lres[3] |= lp[i][k + 3];
               }
               k += 4;
               lres += 4;
@@ -618,7 +616,7 @@ rocksdb::Status Bitmap::BitOp(engine::Context &ctx, BitOpFlags op_flag, const st
                   lres[1] = (first_key[1] & ~lres[1]);
                   lres[2] = (first_key[2] & ~lres[2]);
                   lres[3] = (first_key[3] & ~lres[3]);
-                  lres+=4;
+                  lres += 4;
                   first_key += 4;
                 }
                 break;
@@ -647,19 +645,19 @@ rocksdb::Status Bitmap::BitOp(engine::Context &ctx, BitOpFlags op_flag, const st
             uint64_t lcommon_bits[4];
             size_t k = 0;
 
-            while(frag_minlen >= sizeof(uint64_t)*4) {
+            while (frag_minlen >= sizeof(uint64_t) * 4) {
               memset(lcommon_bits, 0, sizeof(lcommon_bits));
 
               for (size_t i = 1; i < frag_numkeys; i++) {
-                lcommon_bits[0] |= (lres[0] & lp[i][k+0]);
-                lcommon_bits[1] |= (lres[1] & lp[i][k+1]);
-                lcommon_bits[2] |= (lres[2] & lp[i][k+2]);
-                lcommon_bits[3] |= (lres[3] & lp[i][k+3]);
-
-                lres[0] ^= lp[i][k+0];
-                lres[1] ^= lp[i][k+1];
-                lres[2] ^= lp[i][k+2];
-                lres[3] ^= lp[i][k+3];
+                lcommon_bits[0] |= (lres[0] & lp[i][k + 0]);
+                lcommon_bits[1] |= (lres[1] & lp[i][k + 1]);
+                lcommon_bits[2] |= (lres[2] & lp[i][k + 2]);
+                lcommon_bits[3] |= (lres[3] & lp[i][k + 3]);
+
+                lres[0] ^= lp[i][k + 0];
+                lres[1] ^= lp[i][k + 1];
+                lres[2] ^= lp[i][k + 2];
+                lres[3] ^= lp[i][k + 3];
               }
 
               lres[0] &= ~lcommon_bits[0];
@@ -706,7 +704,7 @@ rocksdb::Status Bitmap::BitOp(engine::Context &ctx, BitOpFlags op_flag, const st
                 break;
             }
           }
-          switch(op_flag) {
+          switch (op_flag) {
             case kBitOpDiff:
               frag_res[j] = (output & ~disjunction);
               break;
diff --git a/src/types/redis_bitmap.h b/src/types/redis_bitmap.h
@@ -29,16 +29,7 @@
 #include "storage/redis_db.h"
 #include "storage/redis_metadata.h"
 
-enum BitOpFlags {
-  kBitOpAnd,
-  kBitOpOr,
-  kBitOpXor,
-  kBitOpNot,
-  kBitOpDiff,
-  kBitOpDiff1,
-  kBitOpAndOr,
-  kBitOpOne
-};
+enum BitOpFlags { kBitOpAnd, kBitOpOr, kBitOpXor, kBitOpNot, kBitOpDiff, kBitOpDiff1, kBitOpAndOr, kBitOpOne };
 
 namespace redis {
 
diff --git a/src/types/redis_stream_base.h b/src/types/redis_stream_base.h
@@ -94,7 +94,7 @@ class AutoGeneratedEntryID : public NextStreamEntryIDGenerationStrategy {
 
 class SpecificTimestampWithAnySequenceNumber : public NextStreamEntryIDGenerationStrategy {
  public:
-  explicit SpecificTimestampWithAnySequenceNumber(uint64_t ms) : ms_(ms){};
+  explicit SpecificTimestampWithAnySequenceNumber(uint64_t ms) : ms_(ms) {};
   ~SpecificTimestampWithAnySequenceNumber() override = default;
 
   Status GenerateID(const StreamEntryID &last_id, StreamEntryID *next_id) override;

Original file line number	Diff line number	Diff line change
`@@ -79,8 +79,7 @@ std::string StringJoin(const T &con, F &&f, std::string_view sep = ", ") {`
`79`	`79`
`80`	`80`	`template <typename T>`
`81`	`81`	`std::string StringJoin(const T &con, std::string_view sep = ", ") {`
`82`		`- return StringJoin(`
`83`		`- con, [](const auto &v) -> decltype(auto) { return v; }, sep);`
	`82`	`+ return StringJoin(con, [](const auto &v) -> decltype(auto) { return v; }, sep);`
`84`	`83`	`}`
`85`	`84`
`86`	`85`	`} // namespace util`
Original file line number	Diff line number	Diff line change
`@@ -113,8 +113,7 @@ struct IntervalSet {`
`113`	`113`
`114`	`114`	`std::string ToString() const {`
`115`	`115`	`if (IsEmpty()) return "empty set";`
`116`		`- return util::StringJoin(`
`117`		`- intervals, [](const auto &i) { return Interval(i.first, i.second).ToString(); }, " or ");`
	`116`	`+ return util::StringJoin(intervals, [](const auto &i) { return Interval(i.first, i.second).ToString(); }, " or ");`
`118`	`117`	`}`
`119`	`118`
`120`	`119`	`friend std::ostream &operator<<(std::ostream &os, const IntervalSet &is) { return os << is.ToString(); }`