Search by option is shown even when there is no search term in tables

[anpilw]

Bug description

There seems to be an issue when using Server Side pagination in table charts.
I've enabled Server pagination in a table and then I start seeing the "Search by:" dropdown on the chart.
But I did not enable the "Search box" option under the "Customize" tab.
Therefore, it will be confusing to users when server side pagination is enabled and we want to prevent users to search by any column.

Steps to reproduce:

1. Create table chart with text columns.
2. Enable "Server pagination"
3. Do not enable the "Search box" option under the "Customize" tab.
4. Save the chart.
5. The "Search by": dropdown chart is still shown on the chart

Screenshots/recordings

Superset version

6.1.0

Python version

3.9

Node version

16

Browser

Chrome

Additional context

This probably happens with any data source, but I tested with PostgreSQL and ClickHouse.
Did not find any error stack trace in logs.
I am NOT using the AG_GRID_TABLE_ENABLED feature flag.

Checklist

• I have searched Superset docs and Slack and didn't find a solution to my problem.
• I have searched the GitHub issue tracker and didn't find a similar bug report.
• I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

[durgaprasadml]

Thanks for reporting this issue.

I was able to reproduce the behavior locally using the legacy Table chart implementation with Server Pagination enabled and Search Box disabled.

The Search by dropdown appears to be rendered whenever server pagination is enabled, regardless of the Search box setting.

I'll investigate and work on a fix to ensure search controls are shown only when the Search box option is enabled while preserving existing server-side pagination functionality.

[rusackas]

Thanks for opening/linking the PR, @durgaprasadml!