fix: syntax errcode (#225)

AlexStocks · web-flow · commit 04b5c0655b2e · 2025-03-19T22:20:01.000+08:00
diff --git a/src/cmd_admin.cc b/src/cmd_admin.cc
@@ -258,7 +258,7 @@ void HelloCmd::DoCmd(PClient* client) {
       }
       next_arg += 2;
     } else {
-      client->SetRes(CmdRes::kSyntaxErr, "Syntax error");
+      client->SetRes(CmdRes::kSyntaxErr, kCmdNameHello);
       return;
     }
   }
@@ -336,7 +336,7 @@ bool InfoCmd::DoInitial(PClient* client) {
       return false;
     }
   } else {
-    client->SetRes(CmdRes::kSyntaxErr);
+    client->SetRes(CmdRes::kSyntaxErr, kCmdNameInfo);
     return false;
   }
   return true;
@@ -603,7 +603,7 @@ bool SortCmd::DoInitial(PClient* client) {
     } else if (strcasecmp(client->argv_[i].data(), "limit") == 0 && leftargs >= 2) {
       if (kstd::String2int(client->argv_[i + 1], &offset_) == 0 ||
           kstd::String2int(client->argv_[i + 2], &count_) == 0) {
-        client->SetRes(CmdRes::kSyntaxErr);
+        client->SetRes(CmdRes::kSyntaxErr, kCmdNameSort);
         return false;
       }
       i += 2;
@@ -620,7 +620,7 @@ bool SortCmd::DoInitial(PClient* client) {
       get_patterns_.push_back(client->argv_[i + 1]);
       i++;
     } else {
-      client->SetRes(CmdRes::kSyntaxErr);
+      client->SetRes(CmdRes::kSyntaxErr, kCmdNameSort);
       return false;
     }
   }
diff --git a/src/cmd_hash.cc b/src/cmd_hash.cc
@@ -74,7 +74,7 @@ void HGetCmd::DoCmd(PClient* client) {
   } else if (s.IsInvalidArgument()) {
     client->SetRes(CmdRes::kMultiKey);
   } else {
-    client->SetRes(CmdRes::kSyntaxErr, "hget cmd error");
+    client->SetRes(CmdRes::kSyntaxErr, kCmdNameHGet);
   }
 }
 
@@ -419,7 +419,7 @@ void HSetNXCmd::DoCmd(PClient* client) {
   } else if (s.IsInvalidArgument()) {
     client->SetRes(CmdRes::kMultiKey);
   } else {
-    client->SetRes(CmdRes::kSyntaxErr, "hsetnx cmd error");
+    client->SetRes(CmdRes::kSyntaxErr, kCmdNameHSetNX);
   }
 }
 
@@ -476,12 +476,12 @@ void HRandFieldCmd::DoCmd(PClient* client) {
       return;
     }
     if (argv.size() > 4) {
-      client->SetRes(CmdRes::kSyntaxErr);
+      client->SetRes(CmdRes::kSyntaxErr, kCmdNameHRandField);
       return;
     }
     if (argv.size() > 3) {
       if (kWithValueString != kstd::StringToLower(argv[3])) {
-        client->SetRes(CmdRes::kSyntaxErr);
+        client->SetRes(CmdRes::kSyntaxErr, kCmdNameHRandField);
         return;
       }
       with_values = true;
diff --git a/src/cmd_kv.cc b/src/cmd_kv.cc
@@ -39,7 +39,7 @@ void GetCmd::DoCmd(PClient* client) {
   } else if (s.IsInvalidArgument()) {
     client->SetRes(CmdRes::kMultiKey);
   } else {
-    client->SetRes(CmdRes::kSyntaxErr, "get key error");
+    client->SetRes(CmdRes::kSyntaxErr, kCmdNameGet);
   }
 }
 
@@ -66,7 +66,7 @@ bool SetCmd::DoInitial(PClient* client) {
       condition_ = (condition_ == SetCmd::kNONE) ? SetCmd::kEXORPX : condition_;
       index++;
       if (index == argv_.size()) {
-        client->SetRes(CmdRes::kSyntaxErr);
+        client->SetRes(CmdRes::kSyntaxErr, kCmdNameSet);
         return false;
       }
       if (kstd::String2int(argv_[index].data(), argv_[index].size(), &sec_) == 0) {
@@ -78,7 +78,7 @@ bool SetCmd::DoInitial(PClient* client) {
         sec_ /= 1000;
       }
     } else {
-      client->SetRes(CmdRes::kSyntaxErr);
+      client->SetRes(CmdRes::kSyntaxErr, kCmdNameSet);
       return false;
     }
     index++;
@@ -312,7 +312,7 @@ bool BitOpCmd::DoInitial(PClient* client) {
         kstd::StringEqualCaseInsensitive(client->argv_[1], "or") ||
         kstd::StringEqualCaseInsensitive(client->argv_[1], "not") ||
         kstd::StringEqualCaseInsensitive(client->argv_[1], "xor"))) {
-    client->SetRes(CmdRes::kSyntaxErr, "operation error");
+    client->SetRes(CmdRes::kSyntaxErr, kCmdNameBitOp);
     return false;
   }
   return true;
@@ -347,7 +347,7 @@ void BitOpCmd::DoCmd(PClient* client) {
   }
 
   if (err != kPErrorOK) {
-    client->SetRes(CmdRes::kSyntaxErr);
+    client->SetRes(CmdRes::kSyntaxErr, kCmdNameBitOp);
   } else {
     PString value;
     int64_t result_length = 0;
diff --git a/src/cmd_list.cc b/src/cmd_list.cc
@@ -8,6 +8,7 @@
  */
 
 #include "cmd_list.h"
+#include "base_cmd.h"
 #include "src/scope_record_lock.h"
 #include "std_string.h"
 #include "store.h"
@@ -32,7 +33,7 @@ void LPushCmd::DoCmd(PClient* client) {
   } else if (s.IsInvalidArgument()) {
     client->SetRes(CmdRes::kMultiKey);
   } else {
-    client->SetRes(CmdRes::kSyntaxErr, "lpush cmd error");
+    client->SetRes(CmdRes::kSyntaxErr, kCmdNameLPush);
   }
 }
 
@@ -103,7 +104,7 @@ void RPushCmd::DoCmd(PClient* client) {
   } else if (s.IsInvalidArgument()) {
     client->SetRes(CmdRes::kMultiKey);
   } else {
-    client->SetRes(CmdRes::kSyntaxErr, "rpush cmd error");
+    client->SetRes(CmdRes::kSyntaxErr, kCmdNameRPush);
   }
 }
 
@@ -169,7 +170,7 @@ void RPopCmd::DoCmd(PClient* client) {
   } else if (s.IsInvalidArgument()) {
     client->SetRes(CmdRes::kMultiKey);
   } else {
-    client->SetRes(CmdRes::kSyntaxErr, "rpop cmd error");
+    client->SetRes(CmdRes::kSyntaxErr, kCmdNameRPop);
   }
 }
 
@@ -248,7 +249,7 @@ void LRangeCmd::DoCmd(PClient* client) {
     if (s.IsInvalidArgument()) {
       client->SetRes(CmdRes::kMultiKey);
     } else {
-      client->SetRes(CmdRes::kSyntaxErr, "lrange cmd error");
+      client->SetRes(CmdRes::kSyntaxErr, kCmdNameLRange);
     }
     return;
   }
@@ -307,7 +308,7 @@ void LTrimCmd::DoCmd(PClient* client) {
   } else if (s.IsInvalidArgument()) {
     client->SetRes(CmdRes::kMultiKey);
   } else {
-    client->SetRes(CmdRes::kSyntaxErr, "ltrim cmd error");
+    client->SetRes(CmdRes::kSyntaxErr, kCmdNameLTrim);
   }
 }
 
@@ -341,7 +342,7 @@ void LSetCmd::DoCmd(PClient* client) {
     } else if (s.IsInvalidArgument()) {
       client->SetRes(CmdRes::kMultiKey);
     } else {
-      client->SetRes(CmdRes::kSyntaxErr, "lset cmd error");  // just a safeguard
+      client->SetRes(CmdRes::kSyntaxErr, kCmdNameLSet);  // just a safeguard
     }
   } else {
     client->SetRes(CmdRes::kInvalidInt);
@@ -373,7 +374,7 @@ void LInsertCmd::DoCmd(PClient* client) {
     if (s.IsInvalidArgument()) {
       client->SetRes(CmdRes::kMultiKey);
     } else {
-      client->SetRes(CmdRes::kSyntaxErr, "linsert cmd error");
+      client->SetRes(CmdRes::kSyntaxErr, kCmdNameLInsert);
     }
     return;
   }
diff --git a/src/cmd_set.cc b/src/cmd_set.cc
@@ -10,6 +10,7 @@
 #include "cmd_set.h"
 #include <memory>
 #include <utility>
+#include "base_cmd.h"
 #include "std/std_string.h"
 #include "store.h"
 
@@ -52,7 +53,7 @@ void SAddCmd::DoCmd(PClient* client) {
   } else if (s.IsInvalidArgument()) {
     client->SetRes(CmdRes::kMultiKey);
   } else {
-    client->SetRes(CmdRes::kSyntaxErr, "sadd cmd error");
+    client->SetRes(CmdRes::kSyntaxErr, kCmdNameSAdd);
   }
 }
 
@@ -77,7 +78,7 @@ void SUnionStoreCmd::DoCmd(PClient* client) {
       client->SetRes(CmdRes::kMultiKey);
       return;
     }
-    client->SetRes(CmdRes::kSyntaxErr, "sunionstore cmd error");
+    client->SetRes(CmdRes::kSyntaxErr, kCmdNameSUnionStore);
   }
   client->AppendInteger(ret);
 }
@@ -172,7 +173,7 @@ void SInterStoreCmd::DoCmd(PClient* client) {
     if (s.IsInvalidArgument()) {
       client->SetRes(CmdRes::kMultiKey);
     } else {
-      client->SetRes(CmdRes::kSyntaxErr, "sinterstore cmd error");
+      client->SetRes(CmdRes::kSyntaxErr, kCmdNameSInterStore);
     }
     return;
   }
@@ -193,15 +194,15 @@ void SCardCmd::DoCmd(PClient* client) {
     if (s.IsInvalidArgument()) {
       client->SetRes(CmdRes::kMultiKey);
     } else {
-      client->SetRes(CmdRes::kSyntaxErr, "scard cmd error");
+      client->SetRes(CmdRes::kSyntaxErr, kCmdNameSCard);
     }
     return;
   }
   if (s.ok() || s.IsNotFound()) {
     client->AppendInteger(reply_Num);
     return;
   }
-  client->SetRes(CmdRes::kSyntaxErr, "scard cmd error");
+  client->SetRes(CmdRes::kSyntaxErr, kCmdNameSCard);
 }
 
 SMoveCmd::SMoveCmd(const std::string& name, int16_t arity)
@@ -261,7 +262,7 @@ void SRandMemberCmd::DoCmd(PClient* client) {
     if (s.IsInvalidArgument()) {
       client->SetRes(CmdRes::kMultiKey);
     } else {
-      client->SetRes(CmdRes::kSyntaxErr, "srandmember cmd error");
+      client->SetRes(CmdRes::kSyntaxErr, kCmdNameSRandMember);
     }
     return;
   }
@@ -287,7 +288,7 @@ void SPopCmd::DoCmd(PClient* client) {
       if (s.IsInvalidArgument()) {
         client->SetRes(CmdRes::kMultiKey);
       } else {
-        client->SetRes(CmdRes::kSyntaxErr, "spop cmd error");
+        client->SetRes(CmdRes::kSyntaxErr, kCmdNameSPop);
       }
       return;
     }
@@ -306,7 +307,7 @@ void SPopCmd::DoCmd(PClient* client) {
       if (s.IsInvalidArgument()) {
         client->SetRes(CmdRes::kMultiKey);
       } else {
-        client->SetRes(CmdRes::kSyntaxErr, "spop cmd error");
+        client->SetRes(CmdRes::kSyntaxErr, kCmdNameSPop);
       }
       return;
     }
@@ -334,7 +335,7 @@ void SMembersCmd::DoCmd(PClient* client) {
     if (s.IsInvalidArgument()) {
       client->SetRes(CmdRes::kMultiKey);
     } else {
-      client->SetRes(CmdRes::kSyntaxErr, "smembers cmd error");
+      client->SetRes(CmdRes::kSyntaxErr, kCmdNameSMembers);
     }
     return;
   }
@@ -357,7 +358,7 @@ void SDiffCmd::DoCmd(PClient* client) {
     if (s.IsInvalidArgument()) {
       client->SetRes(CmdRes::kMultiKey);
     } else {
-      client->SetRes(CmdRes::kSyntaxErr, "sdiff cmd error");
+      client->SetRes(CmdRes::kSyntaxErr, kCmdNameSDiff);
     }
     return;
   }
@@ -383,7 +384,7 @@ void SDiffstoreCmd::DoCmd(PClient* client) {
     if (s.IsInvalidArgument()) {
       client->SetRes(CmdRes::kMultiKey);
     } else {
-      client->SetRes(CmdRes::kSyntaxErr, "sdiffstore cmd error");
+      client->SetRes(CmdRes::kSyntaxErr, kCmdNameSDiffstore);
     }
     return;
   }
@@ -395,7 +396,7 @@ SScanCmd::SScanCmd(const std::string& name, int16_t arity)
 
 bool SScanCmd::DoInitial(PClient* client) {
   if (auto size = client->argv_.size(); size != 3 && size != 5 && size != 7) {
-    client->SetRes(CmdRes::kSyntaxErr);
+    client->SetRes(CmdRes::kSyntaxErr, kCmdNameSScan);
     return false;
   }
   client->SetKey(client->argv_[1]);
diff --git a/src/cmd_zset.cc b/src/cmd_zset.cc
diff --git a/src/resp/resp2_encode.cc b/src/resp/resp2_encode.cc

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ void HelloCmd::DoCmd(PClient* client) {`
`258`	`258`	`}`
`259`	`259`	`next_arg += 2;`
`260`	`260`	`} else {`
`261`		`- client->SetRes(CmdRes::kSyntaxErr, "Syntax error");`
	`261`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameHello);`
`262`	`262`	`return;`
`263`	`263`	`}`
`264`	`264`	`}`
`@@ -336,7 +336,7 @@ bool InfoCmd::DoInitial(PClient* client) {`
`336`	`336`	`return false;`
`337`	`337`	`}`
`338`	`338`	`} else {`
`339`		`- client->SetRes(CmdRes::kSyntaxErr);`
	`339`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameInfo);`
`340`	`340`	`return false;`
`341`	`341`	`}`
`342`	`342`	`return true;`
`@@ -603,7 +603,7 @@ bool SortCmd::DoInitial(PClient* client) {`
`603`	`603`	`} else if (strcasecmp(client->argv_[i].data(), "limit") == 0 && leftargs >= 2) {`
`604`	`604`	`if (kstd::String2int(client->argv_[i + 1], &offset_) == 0 \|\|`
`605`	`605`	`kstd::String2int(client->argv_[i + 2], &count_) == 0) {`
`606`		`- client->SetRes(CmdRes::kSyntaxErr);`
	`606`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSort);`
`607`	`607`	`return false;`
`608`	`608`	`}`
`609`	`609`	`i += 2;`
`@@ -620,7 +620,7 @@ bool SortCmd::DoInitial(PClient* client) {`
`620`	`620`	`get_patterns_.push_back(client->argv_[i + 1]);`
`621`	`621`	`i++;`
`622`	`622`	`} else {`
`623`		`- client->SetRes(CmdRes::kSyntaxErr);`
	`623`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSort);`
`624`	`624`	`return false;`
`625`	`625`	`}`
`626`	`626`	`}`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ void HGetCmd::DoCmd(PClient* client) {`
`74`	`74`	`} else if (s.IsInvalidArgument()) {`
`75`	`75`	`client->SetRes(CmdRes::kMultiKey);`
`76`	`76`	`} else {`
`77`		`- client->SetRes(CmdRes::kSyntaxErr, "hget cmd error");`
	`77`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameHGet);`
`78`	`78`	`}`
`79`	`79`	`}`
`80`	`80`
`@@ -419,7 +419,7 @@ void HSetNXCmd::DoCmd(PClient* client) {`
`419`	`419`	`} else if (s.IsInvalidArgument()) {`
`420`	`420`	`client->SetRes(CmdRes::kMultiKey);`
`421`	`421`	`} else {`
`422`		`- client->SetRes(CmdRes::kSyntaxErr, "hsetnx cmd error");`
	`422`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameHSetNX);`
`423`	`423`	`}`
`424`	`424`	`}`
`425`	`425`
`@@ -476,12 +476,12 @@ void HRandFieldCmd::DoCmd(PClient* client) {`
`476`	`476`	`return;`
`477`	`477`	`}`
`478`	`478`	`if (argv.size() > 4) {`
`479`		`- client->SetRes(CmdRes::kSyntaxErr);`
	`479`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameHRandField);`
`480`	`480`	`return;`
`481`	`481`	`}`
`482`	`482`	`if (argv.size() > 3) {`
`483`	`483`	`if (kWithValueString != kstd::StringToLower(argv[3])) {`
`484`		`- client->SetRes(CmdRes::kSyntaxErr);`
	`484`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameHRandField);`
`485`	`485`	`return;`
`486`	`486`	`}`
`487`	`487`	`with_values = true;`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ void GetCmd::DoCmd(PClient* client) {`
`39`	`39`	`} else if (s.IsInvalidArgument()) {`
`40`	`40`	`client->SetRes(CmdRes::kMultiKey);`
`41`	`41`	`} else {`
`42`		`- client->SetRes(CmdRes::kSyntaxErr, "get key error");`
	`42`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameGet);`
`43`	`43`	`}`
`44`	`44`	`}`
`45`	`45`
`@@ -66,7 +66,7 @@ bool SetCmd::DoInitial(PClient* client) {`
`66`	`66`	`condition_ = (condition_ == SetCmd::kNONE) ? SetCmd::kEXORPX : condition_;`
`67`	`67`	`index++;`
`68`	`68`	`if (index == argv_.size()) {`
`69`		`- client->SetRes(CmdRes::kSyntaxErr);`
	`69`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSet);`
`70`	`70`	`return false;`
`71`	`71`	`}`
`72`	`72`	`if (kstd::String2int(argv_[index].data(), argv_[index].size(), &sec_) == 0) {`
`@@ -78,7 +78,7 @@ bool SetCmd::DoInitial(PClient* client) {`
`78`	`78`	`sec_ /= 1000;`
`79`	`79`	`}`
`80`	`80`	`} else {`
`81`		`- client->SetRes(CmdRes::kSyntaxErr);`
	`81`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSet);`
`82`	`82`	`return false;`
`83`	`83`	`}`
`84`	`84`	`index++;`
`@@ -312,7 +312,7 @@ bool BitOpCmd::DoInitial(PClient* client) {`
`312`	`312`	`kstd::StringEqualCaseInsensitive(client->argv_[1], "or") \|\|`
`313`	`313`	`kstd::StringEqualCaseInsensitive(client->argv_[1], "not") \|\|`
`314`	`314`	`kstd::StringEqualCaseInsensitive(client->argv_[1], "xor"))) {`
`315`		`- client->SetRes(CmdRes::kSyntaxErr, "operation error");`
	`315`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameBitOp);`
`316`	`316`	`return false;`
`317`	`317`	`}`
`318`	`318`	`return true;`
`@@ -347,7 +347,7 @@ void BitOpCmd::DoCmd(PClient* client) {`
`347`	`347`	`}`
`348`	`348`
`349`	`349`	`if (err != kPErrorOK) {`
`350`		`- client->SetRes(CmdRes::kSyntaxErr);`
	`350`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameBitOp);`
`351`	`351`	`} else {`
`352`	`352`	`PString value;`
`353`	`353`	`int64_t result_length = 0;`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`	`*/`
`9`	`9`
`10`	`10`	`#include "cmd_list.h"`
	`11`	`+#include "base_cmd.h"`
`11`	`12`	`#include "src/scope_record_lock.h"`
`12`	`13`	`#include "std_string.h"`
`13`	`14`	`#include "store.h"`
`@@ -32,7 +33,7 @@ void LPushCmd::DoCmd(PClient* client) {`
`32`	`33`	`} else if (s.IsInvalidArgument()) {`
`33`	`34`	`client->SetRes(CmdRes::kMultiKey);`
`34`	`35`	`} else {`
`35`		`- client->SetRes(CmdRes::kSyntaxErr, "lpush cmd error");`
	`36`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameLPush);`
`36`	`37`	`}`
`37`	`38`	`}`
`38`	`39`
`@@ -103,7 +104,7 @@ void RPushCmd::DoCmd(PClient* client) {`
`103`	`104`	`} else if (s.IsInvalidArgument()) {`
`104`	`105`	`client->SetRes(CmdRes::kMultiKey);`
`105`	`106`	`} else {`
`106`		`- client->SetRes(CmdRes::kSyntaxErr, "rpush cmd error");`
	`107`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameRPush);`
`107`	`108`	`}`
`108`	`109`	`}`
`109`	`110`
`@@ -169,7 +170,7 @@ void RPopCmd::DoCmd(PClient* client) {`
`169`	`170`	`} else if (s.IsInvalidArgument()) {`
`170`	`171`	`client->SetRes(CmdRes::kMultiKey);`
`171`	`172`	`} else {`
`172`		`- client->SetRes(CmdRes::kSyntaxErr, "rpop cmd error");`
	`173`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameRPop);`
`173`	`174`	`}`
`174`	`175`	`}`
`175`	`176`
`@@ -248,7 +249,7 @@ void LRangeCmd::DoCmd(PClient* client) {`
`248`	`249`	`if (s.IsInvalidArgument()) {`
`249`	`250`	`client->SetRes(CmdRes::kMultiKey);`
`250`	`251`	`} else {`
`251`		`- client->SetRes(CmdRes::kSyntaxErr, "lrange cmd error");`
	`252`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameLRange);`
`252`	`253`	`}`
`253`	`254`	`return;`
`254`	`255`	`}`
`@@ -307,7 +308,7 @@ void LTrimCmd::DoCmd(PClient* client) {`
`307`	`308`	`} else if (s.IsInvalidArgument()) {`
`308`	`309`	`client->SetRes(CmdRes::kMultiKey);`
`309`	`310`	`} else {`
`310`		`- client->SetRes(CmdRes::kSyntaxErr, "ltrim cmd error");`
	`311`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameLTrim);`
`311`	`312`	`}`
`312`	`313`	`}`
`313`	`314`
`@@ -341,7 +342,7 @@ void LSetCmd::DoCmd(PClient* client) {`
`341`	`342`	`} else if (s.IsInvalidArgument()) {`
`342`	`343`	`client->SetRes(CmdRes::kMultiKey);`
`343`	`344`	`} else {`
`344`		`- client->SetRes(CmdRes::kSyntaxErr, "lset cmd error"); // just a safeguard`
	`345`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameLSet); // just a safeguard`
`345`	`346`	`}`
`346`	`347`	`} else {`
`347`	`348`	`client->SetRes(CmdRes::kInvalidInt);`
`@@ -373,7 +374,7 @@ void LInsertCmd::DoCmd(PClient* client) {`
`373`	`374`	`if (s.IsInvalidArgument()) {`
`374`	`375`	`client->SetRes(CmdRes::kMultiKey);`
`375`	`376`	`} else {`
`376`		`- client->SetRes(CmdRes::kSyntaxErr, "linsert cmd error");`
	`377`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameLInsert);`
`377`	`378`	`}`
`378`	`379`	`return;`
`379`	`380`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`#include "cmd_set.h"`
`11`	`11`	`#include <memory>`
`12`	`12`	`#include <utility>`
	`13`	`+#include "base_cmd.h"`
`13`	`14`	`#include "std/std_string.h"`
`14`	`15`	`#include "store.h"`
`15`	`16`
`@@ -52,7 +53,7 @@ void SAddCmd::DoCmd(PClient* client) {`
`52`	`53`	`} else if (s.IsInvalidArgument()) {`
`53`	`54`	`client->SetRes(CmdRes::kMultiKey);`
`54`	`55`	`} else {`
`55`		`- client->SetRes(CmdRes::kSyntaxErr, "sadd cmd error");`
	`56`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSAdd);`
`56`	`57`	`}`
`57`	`58`	`}`
`58`	`59`
`@@ -77,7 +78,7 @@ void SUnionStoreCmd::DoCmd(PClient* client) {`
`77`	`78`	`client->SetRes(CmdRes::kMultiKey);`
`78`	`79`	`return;`
`79`	`80`	`}`
`80`		`- client->SetRes(CmdRes::kSyntaxErr, "sunionstore cmd error");`
	`81`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSUnionStore);`
`81`	`82`	`}`
`82`	`83`	`client->AppendInteger(ret);`
`83`	`84`	`}`
`@@ -172,7 +173,7 @@ void SInterStoreCmd::DoCmd(PClient* client) {`
`172`	`173`	`if (s.IsInvalidArgument()) {`
`173`	`174`	`client->SetRes(CmdRes::kMultiKey);`
`174`	`175`	`} else {`
`175`		`- client->SetRes(CmdRes::kSyntaxErr, "sinterstore cmd error");`
	`176`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSInterStore);`
`176`	`177`	`}`
`177`	`178`	`return;`
`178`	`179`	`}`
`@@ -193,15 +194,15 @@ void SCardCmd::DoCmd(PClient* client) {`
`193`	`194`	`if (s.IsInvalidArgument()) {`
`194`	`195`	`client->SetRes(CmdRes::kMultiKey);`
`195`	`196`	`} else {`
`196`		`- client->SetRes(CmdRes::kSyntaxErr, "scard cmd error");`
	`197`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSCard);`
`197`	`198`	`}`
`198`	`199`	`return;`
`199`	`200`	`}`
`200`	`201`	`if (s.ok() \|\| s.IsNotFound()) {`
`201`	`202`	`client->AppendInteger(reply_Num);`
`202`	`203`	`return;`
`203`	`204`	`}`
`204`		`- client->SetRes(CmdRes::kSyntaxErr, "scard cmd error");`
	`205`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSCard);`
`205`	`206`	`}`
`206`	`207`
`207`	`208`	`SMoveCmd::SMoveCmd(const std::string& name, int16_t arity)`
`@@ -261,7 +262,7 @@ void SRandMemberCmd::DoCmd(PClient* client) {`
`261`	`262`	`if (s.IsInvalidArgument()) {`
`262`	`263`	`client->SetRes(CmdRes::kMultiKey);`
`263`	`264`	`} else {`
`264`		`- client->SetRes(CmdRes::kSyntaxErr, "srandmember cmd error");`
	`265`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSRandMember);`
`265`	`266`	`}`
`266`	`267`	`return;`
`267`	`268`	`}`
`@@ -287,7 +288,7 @@ void SPopCmd::DoCmd(PClient* client) {`
`287`	`288`	`if (s.IsInvalidArgument()) {`
`288`	`289`	`client->SetRes(CmdRes::kMultiKey);`
`289`	`290`	`} else {`
`290`		`- client->SetRes(CmdRes::kSyntaxErr, "spop cmd error");`
	`291`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSPop);`
`291`	`292`	`}`
`292`	`293`	`return;`
`293`	`294`	`}`
`@@ -306,7 +307,7 @@ void SPopCmd::DoCmd(PClient* client) {`
`306`	`307`	`if (s.IsInvalidArgument()) {`
`307`	`308`	`client->SetRes(CmdRes::kMultiKey);`
`308`	`309`	`} else {`
`309`		`- client->SetRes(CmdRes::kSyntaxErr, "spop cmd error");`
	`310`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSPop);`
`310`	`311`	`}`
`311`	`312`	`return;`
`312`	`313`	`}`
`@@ -334,7 +335,7 @@ void SMembersCmd::DoCmd(PClient* client) {`
`334`	`335`	`if (s.IsInvalidArgument()) {`
`335`	`336`	`client->SetRes(CmdRes::kMultiKey);`
`336`	`337`	`} else {`
`337`		`- client->SetRes(CmdRes::kSyntaxErr, "smembers cmd error");`
	`338`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSMembers);`
`338`	`339`	`}`
`339`	`340`	`return;`
`340`	`341`	`}`
`@@ -357,7 +358,7 @@ void SDiffCmd::DoCmd(PClient* client) {`
`357`	`358`	`if (s.IsInvalidArgument()) {`
`358`	`359`	`client->SetRes(CmdRes::kMultiKey);`
`359`	`360`	`} else {`
`360`		`- client->SetRes(CmdRes::kSyntaxErr, "sdiff cmd error");`
	`361`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSDiff);`
`361`	`362`	`}`
`362`	`363`	`return;`
`363`	`364`	`}`
`@@ -383,7 +384,7 @@ void SDiffstoreCmd::DoCmd(PClient* client) {`
`383`	`384`	`if (s.IsInvalidArgument()) {`
`384`	`385`	`client->SetRes(CmdRes::kMultiKey);`
`385`	`386`	`} else {`
`386`		`- client->SetRes(CmdRes::kSyntaxErr, "sdiffstore cmd error");`
	`387`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSDiffstore);`
`387`	`388`	`}`
`388`	`389`	`return;`
`389`	`390`	`}`
`@@ -395,7 +396,7 @@ SScanCmd::SScanCmd(const std::string& name, int16_t arity)`
`395`	`396`
`396`	`397`	`bool SScanCmd::DoInitial(PClient* client) {`
`397`	`398`	`if (auto size = client->argv_.size(); size != 3 && size != 5 && size != 7) {`
`398`		`- client->SetRes(CmdRes::kSyntaxErr);`
	`399`	`+ client->SetRes(CmdRes::kSyntaxErr, kCmdNameSScan);`
`399`	`400`	`return false;`
`400`	`401`	`}`
`401`	`402`	`client->SetKey(client->argv_[1]);`