Skip to content

Don't exit on regression in CI #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakeLane merged 4 commits into from
Nov 25, 2025
Merged

Don't exit on regression in CI #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffd1487
Don't exit on regression in CI
JakeLane Nov 13, 2025
17bdd46
Remove another exit and up samples and three-js copies
JakeLane Nov 13, 2025
4b12435
Reduce samples
JakeLane Nov 13, 2025
ef8e3d2
10 copies
JakeLane Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/core/e2e-tests/benchmark.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,6 @@ async function main() {
` - ${r.name}: ${r.comparison?.meanDiffPercent?.toFixed(2)}% slower`,
);
});

// Exit with error code if regressions detected
if (process.env.CI === 'true') {
process.exit(1);
}
}

const improvements = comparisons.filter((c) => c.comparison?.isImprovement);
Expand Down
6 changes: 3 additions & 3 deletions packages/core/e2e-tests/benchmarks/config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const BENCHMARK_CONFIGS: BenchmarkOptions[] = [
{
name: 'Three.js Real Repository (JS)',
target: 'three-js-project/index.html',
samples: 5,
samples: 7,
warmupRuns: 1,
buildOptions: {
mode: 'production',
Expand All @@ -20,9 +20,9 @@ export const BENCHMARK_CONFIGS: BenchmarkOptions[] = [
},
},
{
name: 'Three.js Real Repository (Native)',
name: 'Three.js Real Repository (V3)',
target: 'three-js-project/index.html',
samples: 5,
samples: 7,
warmupRuns: 1,
buildOptions: {
mode: 'production',
Expand Down
1 change: 0 additions & 1 deletion scripts/benchmarks/check-regressions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ if [ -f "$RESULTS_FILE" ]; then
if grep -q "🔴 Regression" "$RESULTS_FILE"; then
echo "❌ Performance regressions detected!"
cat "$RESULTS_FILE"
exit 1
else
echo "✅ No performance regressions detected"
cat "$RESULTS_FILE"
Expand Down
6 changes: 2 additions & 4 deletions scripts/benchmarks/run-benchmarks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,12 @@ if [ -f "$BASELINE_OUTPUT_DIR/baseline-report.json" ]; then
yarn benchmark \
--output="$BASELINE_OUTPUT_DIR" \
--baseline="$BASELINE_OUTPUT_DIR/baseline-report.json" \
--github-comment \
--samples=3
--github-comment
else
echo "🔄 Running benchmarks without baseline..."
yarn benchmark \
--output="$BASELINE_OUTPUT_DIR" \
--github-comment \
--samples=3
--github-comment
fi

cd "$GITHUB_WORKSPACE"
Loading