Skip to content

Remove deprecated type from withRouter #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove deprecated type from withRouter #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6c531d
Remove deprecated type from withRouter
JakeLane Dec 31, 2020
41b55dd
Add missing function props to withRouter
JakeLane Dec 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/index.js.flow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ import type {
RouterSubscriberProps,
StaticRouterProps,
CreateRouterContextOptions,
RouterActionPush,
RouterActionReplace,
} from './types.js.flow';

export * from './utils.js.flow';
Expand Down Expand Up @@ -90,19 +92,18 @@ declare export function usePathParam(
];

// Utils
type WithRouterProps = RouteContext & {|
export type WithRouterProps = RouteContext & {|
history: BrowserHistory,
push: RouterActionPush,
replace: RouterActionReplace,
|};

declare export function withRouter<
Props: { ... },
Component: ComponentType<Props>
>(
WrappedComponent: Component
): ComponentType<
// $FlowFixMe[deprecated-utility] - $Supertype is deprecated https://github.com/flow-typed/flow-typed/issues/2991
$Diff<ElementConfig<$Supertype<Component>>, WithRouterProps>
>;
): ComponentType<$Diff<ElementConfig<Component>, WithRouterProps>>;

declare export function generatePath(
pattern: string,
Expand Down