PR feedback, use max retries from configuration

Author: akavatl

pkg/backends/cloudwatch/cloudwatch.go

@@ -25,15 +25,15 @@ const MAX_DIMENSIONS = 10
 // BackendName is the name of this backend.
 const BackendName = "cloudwatch"
 
-type ApiClient interface {
+type CloudwatchClient interface {
 	PutMetricData(context.Context, *cloudwatch.PutMetricDataInput, ...func(*cloudwatch.Options)) (*cloudwatch.PutMetricDataOutput, error)
 }
 
 // Client is an object that is used to send messages to AWS CloudWatch.
 type Client struct {
 	logger logrus.FieldLogger
 
-	cloudwatch ApiClient
+	cloudwatch CloudwatchClient
 	namespace  string
 
 	disabledSubtypes gostatsd.TimerSubtypes
@@ -60,7 +60,7 @@ func NewClient(namespace, transport string, disabled gostatsd.TimerSubtypes, log
 	if err != nil {
 		return nil, err
 	}
-	cfg, err := config.LoadDefaultConfig(context.TODO(), config.WithHTTPClient(httpClient.Client))
+	cfg, err := config.LoadDefaultConfig(context.Background(), config.WithHTTPClient(httpClient.Client))
 	if err != nil {
 		return nil, err
 	}

pkg/backends/cloudwatch/cloudwatch_test.go

@@ -17,7 +17,7 @@ import (
 )
 
 type mockedCloudwatch struct {
-	ApiClient
+	CloudwatchClient
 
 	PutMetricDataHandler func(*cloudwatch.PutMetricDataInput) (*cloudwatch.PutMetricDataOutput, error)
 }

pkg/cloudproviders/aws/aws.go

@@ -242,22 +242,22 @@ func NewProviderFromViper(v *viper.Viper, logger logrus.FieldLogger, _ string) (
 		return nil, err
 	}
 
-	cfg, err := config.LoadDefaultConfig(context.TODO(),
+	cfg, err := config.LoadDefaultConfig(context.Background(),
 		config.WithHTTPClient(&http.Client{
 			Transport: transport,
 			Timeout:   httpTimeout,
 		}),
-		config.WithRetryMaxAttempts(5),
+		config.WithRetryMaxAttempts(a.GetInt("max_retries")),
 	)
 
 	metadataClient := imds.NewFromConfig(cfg)
 
-	region, err := metadataClient.GetRegion(context.TODO(), nil)
+	region, err := metadataClient.GetRegion(context.Background(), nil)
 	if err != nil {
 		return nil, fmt.Errorf("error getting AWS region: %v", err)
 	}
 
-	ec2config, err := config.LoadDefaultConfig(context.TODO(),
+	ec2config, err := config.LoadDefaultConfig(context.Background(),
 		config.WithHTTPClient(&http.Client{
 			Transport: transport,
 			Timeout:   httpTimeout,