fix: use parameters directly as config options

Author: Singond

lib/script-view.js

@@ -18,9 +18,11 @@ export default class ScriptView extends MessagePanelView {
     this.scrollTimeout = null;
     this.ansiFilter = new AnsiFilter();
     this.headerView = headerView;
-    this.position = this.parsePositionConfig(atom.config.get('script.position'));
+    // Use 'bottom' as the default position, because that was
+    // the behaviour before the position became configurable:
+    this.position = 'bottom';
     atom.config.observe('script.position', (newVal) => {
-      this.position = this.parsePositionConfig(newVal);
+      this.position = newVal;
     });
 
     this.showInTab = this.showInTab.bind(this);
@@ -31,25 +33,6 @@ export default class ScriptView extends MessagePanelView {
     linkPaths.listen(this.body);
   }
 
-  parsePositionConfig(value) {
-    // Get the configured position of the view as one of the
-    // valid values of the MessagePanelView.position parameter.
-    switch (value) {
-      case 'Top':
-        return 'top';
-      case 'Bottom':
-        return 'bottom';
-      case 'Left':
-        return 'left';
-      case 'Right':
-        return 'right';
-      default:
-        // Use bottom as the default, because that was the behaviour
-        // before the position became configurable.
-        return 'bottom';
-    }
-  }
-
   addShowInTabIcon() {
     const icon = $$(function () {
       this.div({

lib/script.js

@@ -54,12 +54,12 @@ export const config = {
     description: 'Position of the panel with script output. \
     (Changes to this value will be applied upon reopening the panel.)',
     type: 'string',
-    default: 'Bottom',
+    default: 'bottom',
     enum: [
-      'Top',
-      'Bottom',
-      'Left',
-      'Right',
+      'top',
+      'bottom',
+      'left',
+      'right',
     ],
   },
 }