Skip to content

Commit 54d440d

Browse files
authored
feat: Change default value of max_history from unlimited (up to 256) to a more sane default of 5 (#9)
1 parent 4937a05 commit 54d440d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ No modules.
193193
| <a name="input_irsa_oidc_providers"></a> [irsa\_oidc\_providers](#input\_irsa\_oidc\_providers) | Map of OIDC providers used to create the appropriate trust policy for IAM role for service account (IRSA). If not using IRSA, leave this as `null` | <pre>map(object({<br/> provider_arn = string<br/> service_account = string<br/> namespace = optional(string)<br/> }))</pre> | `null` | no |
194194
| <a name="input_keyring"></a> [keyring](#input\_keyring) | Location of public keys used for verification. Used only if verify is true. Defaults to `/.gnupg/pubring.gpg` in the location set by `home` | `string` | `null` | no |
195195
| <a name="input_lint"></a> [lint](#input\_lint) | Run the helm chart linter during the plan. Defaults to `false` | `bool` | `null` | no |
196-
| <a name="input_max_history"></a> [max\_history](#input\_max\_history) | Maximum number of release versions stored per release. Defaults to `0` (no limit) | `number` | `null` | no |
196+
| <a name="input_max_history"></a> [max\_history](#input\_max\_history) | Maximum number of release versions stored per release. Defaults to `5` | `number` | `5` | no |
197197
| <a name="input_max_session_duration"></a> [max\_session\_duration](#input\_max\_session\_duration) | Maximum CLI/API session duration in seconds between 3600 and 43200 | `number` | `null` | no |
198198
| <a name="input_name"></a> [name](#input\_name) | Name of the Helm release | `string` | `""` | no |
199199
| <a name="input_namespace"></a> [namespace](#input\_namespace) | The namespace to install the release into. Defaults to `default` | `string` | `null` | no |

variables.tf

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,10 +104,11 @@ variable "lint" {
104104
default = null
105105
}
106106

107+
# https://github.com/hashicorp/terraform-provider-helm/issues/1571
107108
variable "max_history" {
108-
description = "Maximum number of release versions stored per release. Defaults to `0` (no limit)"
109+
description = "Maximum number of release versions stored per release. Defaults to `5`"
109110
type = number
110-
default = null
111+
default = 5
111112
}
112113

113114
variable "name" {

0 commit comments

Comments
 (0)