Add s3 endpoint override as a config variable

Let the user override what s3 endpoint the agent is using.

This change adds a new optional config variable, which lets us
override s3 endpoint override.

 * Unit Tests : Y
 * Integration Tests : Y

cr https://code.amazon.com/reviews/CR-9234157

Author: Katyal

conf/codedeployagent.yml

@@ -7,4 +7,4 @@
 :verbose: false
 :wait_between_runs: 1
 :proxy_uri:
-:max_revisions: 5
+:max_revisions: 5

lib/instance_agent/config.rb

@@ -42,7 +42,8 @@ def initialize
         :proxy_uri => nil,
         :enable_deployments_log => true,
         :use_fips_mode => false,
-        :deploy_control_endpoint => nil
+        :deploy_control_endpoint => nil,
+        :s3_endpoint_override => nil
       })
     end
 

lib/instance_agent/plugins/codedeploy/command_executor.rb

@@ -266,12 +266,13 @@ def s3_options
 
           region = ENV['AWS_REGION'] || InstanceMetadata.region
           options[:region] = region
-          if InstanceAgent::Config.config[:use_fips_mode]
+          if !InstanceAgent::Config.config[:s3_endpoint_override].to_s.empty?
+            options[:endpoint] = URI(InstanceAgent::Config.config[:s3_endpoint_override])
+          elsif InstanceAgent::Config.config[:use_fips_mode]
             #S3 Fips pseudo-regions are not supported by the SDK yet 
             #source for the URL: https://aws.amazon.com/compliance/fips/
             options[:endpoint] = "https://s3-fips.#{region}.amazonaws.com"
-          end
-            
+          end 
           proxy_uri = nil
           if InstanceAgent::Config.config[:proxy_uri]
             proxy_uri = URI(InstanceAgent::Config.config[:proxy_uri])

test/instance_agent/config_test.rb

@@ -33,7 +33,8 @@ class InstanceAgentConfigTest < InstanceAgentTestCase
         :enable_deployments_log => true,
         :kill_agent_max_wait_time_seconds => 7200,
         :use_fips_mode => false,
-        :deploy_control_endpoint => nil
+        :deploy_control_endpoint => nil,
+        :s3_endpoint_override => nil
       }, InstanceAgent::Config.config)
     end
 

test/instance_agent/plugins/codedeploy/command_executor_test.rb

@@ -332,7 +332,16 @@ def generate_signed_message_for(map)
             InstanceAgent::Config.config[:use_fips_mode] = false
           end
 
-          should "use no endpoint when not using Fips" do
+          should "use right endpoint when using endpoint override" do
+            s3_endpoint_override_url = 'htpp://testendpointoverride'
+            InstanceAgent::Config.config[:s3_endpoint_override] = s3_endpoint_override_url
+            assert_equal s3_endpoint_override_url, @command_executor.s3_options[:endpoint].to_s
+            InstanceAgent::Config.config[:s3_endpoint_override] = nil
+          end
+          
+          should "use no endpoint when neither using Fips nor Endpoint override" do
+            InstanceAgent::Config.config[:s3_endpoint_override] = nil
+            InstanceAgent::Config.config[:use_fips_mode] = false
             assert_false @command_executor.s3_options.include? :endpoint
           end