Unable to set `filename*=` in CloudFront signer

[kuhe]

Checkboxes for prior research

• I've gone through Developer Guide and API reference
• I've checked AWS Forums and StackOverflow.
• I've searched for previous similar issues and didn't find any solution.

Describe the bug

In #7437, the encoding of the URL query parameters uses the extended encoding from @smithy, leading to the * (asterisk) character being encoded.

The * character has a practical application in the query parameter -- see comment in #7437

A related ticket was not properly resolved in #3614.

Regression Issue

• Select this option if this issue appears to be a regression.

SDK version number

@aws-sdk/package-name@version, ...

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

all

Reproduction Steps

get a signed url with a query parameter such as

`?response-content-disposition=${encodeURIComponent(
  `attachment; filename=${encName}; filename*=UTF-8''${encName}`,
)}`

See section on filename* from https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Content-Disposition.

Observed Behavior

signed request fails (likely 403?)

Expected Behavior

signed request succeeds

Possible Solution

use encodeURIComponent instead of extendedEncodeURIComponent

Additional Information/Context

No response

[benclarkmck]

this has also broken our use case, where brackets in a query parameter are getting encoded where they weren't before.

something like:

import { getSignedUrl } from '@aws-sdk/cloudfront-signer';
import { cloudfront as cloudfrontConfig } from 'config';

const { keyPairId, privateKey } = cloudfrontConfig;

const url = 'https://some-cloudfront-url';
const originalFilename=encodeUriComponent('original filename (2025-01-01).pdf');
const date = new Date();
date.setMinutes(date.getMinutes() + 1); // expires in one minute,
const signedUrl = getSignedUrl({
    url: `${url}?filename=${originalFilename}`,
    keyPairId,
    dateLessThan: date.toString(),
    privateKey
});

results in an invalid signedUrl, manually changing the encoded parameters back to brackets then works

[benclarkmck]

Have raised a small PR here to change those to standard encodeURIComponent #7515

[andrewwood3]

Thanks Ben. Yes, this needs to be fixed. Can someone approve Ben's PR asap?