From 733c287e3e6a630a829e33e437964eead4143ca9 Mon Sep 17 00:00:00 2001 From: "khanh.nguyen.quoc" Date: Fri, 10 Oct 2025 11:49:40 +0700 Subject: [PATCH 1/4] migrate to wasm compatibility --- example/pubspec.lock | 62 ++-- .../model_viewer/model_viewer_plus_web.dart | 350 ++++++++++++------ .../app/model_viewer/o3d_model_viewer.dart | 7 +- .../implementation/o3d_web_impl.dart | 13 +- pubspec.yaml | 4 +- 5 files changed, 284 insertions(+), 152 deletions(-) diff --git a/example/pubspec.lock b/example/pubspec.lock index 2d286fd..a67bffb 100644 --- a/example/pubspec.lock +++ b/example/pubspec.lock @@ -29,26 +29,26 @@ packages: dependency: transitive description: name: characters - sha256: "04a925763edad70e8443c99234dc3328f442e811f1d8fd1a72f1c8ad0f69a605" + sha256: f71061c654a3380576a52b451dd5532377954cf9dbd272a78fc8479606670803 url: "https://pub.dev" source: hosted - version: "1.3.0" + version: "1.4.0" clock: dependency: transitive description: name: clock - sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf + sha256: fddb70d9b5277016c77a80201021d40a2247104d9f4aa7bab7157b7e3f05b84b url: "https://pub.dev" source: hosted - version: "1.1.1" + version: "1.1.2" collection: dependency: transitive description: name: collection - sha256: ee67cb0715911d28db6bf4af1026078bd6f0128b07a5f66fb2ed94ec6783c09a + sha256: "2f5709ae4d3d59dd8f7cd309b4e023046b57d8a6c82130785d2b0e5868084e76" url: "https://pub.dev" source: hosted - version: "1.18.0" + version: "1.19.1" cupertino_icons: dependency: "direct main" description: @@ -61,10 +61,10 @@ packages: dependency: transitive description: name: fake_async - sha256: "511392330127add0b769b75a987850d136345d9227c6b94c96a04cf4a391bf78" + sha256: "5368f224a74523e8d2e7399ea1638b37aecfca824a3cc4dfdf77bf1fa905ac44" url: "https://pub.dev" source: hosted - version: "1.3.1" + version: "1.3.3" flutter: dependency: "direct main" description: flutter @@ -92,26 +92,26 @@ packages: dependency: transitive description: name: leak_tracker - sha256: "3f87a60e8c63aecc975dda1ceedbc8f24de75f09e4856ea27daf8958f2f0ce05" + sha256: "33e2e26bdd85a0112ec15400c8cbffea70d0f9c3407491f672a2fad47915e2de" url: "https://pub.dev" source: hosted - version: "10.0.5" + version: "11.0.2" leak_tracker_flutter_testing: dependency: transitive description: name: leak_tracker_flutter_testing - sha256: "932549fb305594d82d7183ecd9fa93463e9914e1b67cacc34bc40906594a1806" + sha256: "1dbc140bb5a23c75ea9c4811222756104fbcd1a27173f0c34ca01e16bea473c1" url: "https://pub.dev" source: hosted - version: "3.0.5" + version: "3.0.10" leak_tracker_testing: dependency: transitive description: name: leak_tracker_testing - sha256: "6ba465d5d76e67ddf503e1161d1f4a6bc42306f9d66ca1e8f079a47290fb06d3" + sha256: "8d5a2d49f4a66b49744b23b018848400d23e54caf9463f4eb20df3eb8acb2eb1" url: "https://pub.dev" source: hosted - version: "3.0.1" + version: "3.0.2" lints: dependency: transitive description: @@ -124,10 +124,10 @@ packages: dependency: transitive description: name: matcher - sha256: d2323aa2060500f906aa31a895b4030b6da3ebdcc5619d14ce1aada65cd161cb + sha256: dc58c723c3c24bf8d3e2d3ad3f2f9d7bd9cf43ec6feaa64181775e60190153f2 url: "https://pub.dev" source: hosted - version: "0.12.16+1" + version: "0.12.17" material_color_utilities: dependency: transitive description: @@ -140,25 +140,25 @@ packages: dependency: transitive description: name: meta - sha256: bdb68674043280c3428e9ec998512fb681678676b3c54e773629ffe74419f8c7 + sha256: e3641ec5d63ebf0d9b41bd43201a66e3fc79a65db5f61fc181f04cd27aab950c url: "https://pub.dev" source: hosted - version: "1.15.0" + version: "1.16.0" o3d: dependency: "direct main" description: path: ".." relative: true source: path - version: "3.1.2" + version: "3.1.3" path: dependency: transitive description: name: path - sha256: "087ce49c3f0dc39180befefc60fdb4acd8f8620e5682fe2476afd0b3688bb4af" + sha256: "75cca69d1490965be98c73ceaea117e8a04dd21217b37b292c9ddbec0d955bc5" url: "https://pub.dev" source: hosted - version: "1.9.0" + version: "1.9.1" platform: dependency: transitive description: @@ -179,7 +179,7 @@ packages: dependency: transitive description: flutter source: sdk - version: "0.0.99" + version: "0.0.0" source_span: dependency: transitive description: @@ -192,18 +192,18 @@ packages: dependency: transitive description: name: stack_trace - sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" + sha256: "8b27215b45d22309b5cddda1aa2b19bdfec9df0e765f2de506401c071d38d1b1" url: "https://pub.dev" source: hosted - version: "1.11.1" + version: "1.12.1" stream_channel: dependency: transitive description: name: stream_channel - sha256: ba2aa5d8cc609d96bbb2899c28934f9e1af5cddbd60a827822ea467161eb54e7 + sha256: "969e04c80b8bcdf826f8f16579c7b14d780458bd97f56d107d3950fdbeef059d" url: "https://pub.dev" source: hosted - version: "2.1.2" + version: "2.1.4" string_scanner: dependency: transitive description: @@ -224,10 +224,10 @@ packages: dependency: transitive description: name: test_api - sha256: "5b8a98dafc4d5c4c9c72d8b31ab2b23fc13422348d2997120294d3bac86b4ddb" + sha256: "522f00f556e73044315fa4585ec3270f1808a4b186c936e612cab0b565ff1e00" url: "https://pub.dev" source: hosted - version: "0.7.2" + version: "0.7.6" url_launcher: dependency: "direct main" description: @@ -296,10 +296,10 @@ packages: dependency: transitive description: name: vector_math - sha256: "80b3257d1492ce4d091729e3a67a60407d227c27241d6927be0130c98e741803" + sha256: d530bd74fea330e6e364cda7a85019c434070188383e1cd8d9777ee586914c5b url: "https://pub.dev" source: hosted - version: "2.1.4" + version: "2.2.0" vm_service: dependency: transitive description: @@ -349,5 +349,5 @@ packages: source: hosted version: "3.16.3" sdks: - dart: ">=3.5.0 <4.0.0" + dart: ">=3.8.0-0 <4.0.0" flutter: ">=3.24.0" diff --git a/lib/src/app/model_viewer/model_viewer_plus_web.dart b/lib/src/app/model_viewer/model_viewer_plus_web.dart index 1d9124f..1b70d58 100644 --- a/lib/src/app/model_viewer/model_viewer_plus_web.dart +++ b/lib/src/app/model_viewer/model_viewer_plus_web.dart @@ -1,14 +1,43 @@ import 'dart:async'; +import 'dart:js_interop'; +import 'dart:js_interop_unsafe'; +import 'dart:ui_web' as ui_web; import 'package:flutter/material.dart'; import 'package:flutter/services.dart' show rootBundle; +import 'package:web/web.dart' as web; import 'html_builder.dart'; -import '../fake/dart_html_fake.dart' if (dart.library.html) 'dart:html'; -import '../fake/dart_ui_fake.dart' if (dart.library.html) 'dart:ui_web' - as ui_web; import 'o3d_model_viewer.dart'; +// JS interop for DOMPurify +@JS('DOMPurify') +external _DomPurify? get _domPurify; + +@JS() +extension type _DomPurify(JSObject _) implements JSObject { + external JSString sanitize(JSAny dirty, [_DomPurifyConfig? config]); +} + +@JS() +@anonymous +extension type _DomPurifyConfig._(JSObject _) implements JSObject { + external factory _DomPurifyConfig({ + JSArray? ALLOWED_TAGS, + JSArray? ALLOWED_ATTR, + JSArray? ADD_TAGS, + JSArray? ADD_ATTR, + JSBoolean? ALLOW_DATA_ATTR, + JSBoolean? ALLOW_ARIA_ATTR, + JSBoolean? KEEP_CONTENT, + JSBoolean? SAFE_FOR_TEMPLATES, + JSBoolean? WHOLE_DOCUMENT, + JSString? RETURN_DOM, + JSString? RETURN_DOM_FRAGMENT, + JSBoolean? FORCE_BODY, + }); +} + class ModelViewerState extends State { bool _isLoading = true; @@ -18,27 +47,61 @@ class ModelViewerState extends State { unawaited(generateModelViewerHtml()); } - /// To generate the HTML code for using the model viewer. Future generateModelViewerHtml() async { final htmlTemplate = await rootBundle.loadString('packages/o3d/assets/template.html'); - // allow to use elements - final NodeValidator validator = - widget.overwriteNodeValidatorBuilder ?? defaultNodeValidatorBuilder; - final html = _buildHTML(htmlTemplate); + // Ensure DOMPurify is loaded (CDN). You can switch to a local asset if preferred. + await _ensureDomPurifyLoaded(); + + // Sanitize HTML using DOMPurify or a minimal whitelist fallback + final sanitized = await _sanitizeHtml(html); + ui_web.platformViewRegistry.registerViewFactory( 'babakcode-model-viewer-html-${widget.id}', - (viewId) => HtmlHtmlElement() - // ignore: avoid_dynamic_calls - ..style.border = 'none' - // ignore: avoid_dynamic_calls - ..style.height = '100%' - // ignore: avoid_dynamic_calls - ..style.width = '100%' - ..setInnerHtml(html, validator: validator), + (viewId) { + final el = web.document.createElement('div') as web.HTMLDivElement; + el.style.border = 'none'; + el.style.height = '100%'; + el.style.width = '100%'; + el.style.margin = '0'; + el.style.padding = '0'; + el.style.overflow = 'hidden'; + + // Set sanitized HTML + el.innerHTML = sanitized.toJS; + + // Ensure model-viewer has correct styling + final modelViewer = el.querySelector('model-viewer'); + if (modelViewer != null) { + final mv = modelViewer as web.HTMLElement; + mv.style.width = '100%'; + mv.style.height = '100%'; + mv.style.display = 'block'; + mv.style.margin = '0'; + mv.style.padding = '0'; + } + + // If custom JS/CSS is needed, inject programmatically (DOMPurify strips