Skip to content

Conversation

@svr333
Copy link

@svr333 svr333 commented Oct 3, 2022

Changes

Instead of it marking the action as failed, simply return silently.
This'll look nicer in the PR overview

@WalshyDev
Copy link

Moving my comment here so it isn't lost

Is there a need now it's fixed for external contributors?

@JustAHuman-xD
Copy link

Moving my comment here so it isn't lost

Is there a need now it's fixed for external contributors?

If something else was to error in the labeling or the action breaks in the future due to a change it would avoid the same issue happening.

@WalshyDev
Copy link

But it would also avoid us knowing about it :p

Good to know when errors happen rather than avoid them haha

@JustAHuman-xD
Copy link

fair enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants