Fix truss hash calculation for dev builds #1880
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeepak-baseten
commented
Aug 21, 2025
| underneath. The (root) Directory will have the same hash, even if renamed. | ||
| """ | ||
| hasher = blake3() | ||
| print(f"Calculating hash for {root}, ignore_patterns: {ignore_patterns}") |
Contributor
Author
There was a problem hiding this comment.
Debug changes only.
| if absolute_path.is_file(): | ||
| hasher.update(file_content_hash(absolute_path)) | ||
| return hasher.hexdigest() | ||
| hash_str = hasher.hexdigest() |
Contributor
Author
There was a problem hiding this comment.
Debug changes only.
|
|
||
| def _update_config(self, **fields_to_update): | ||
| config = self._spec.config.model_copy(update=fields_to_update) | ||
| print( |
Contributor
Author
There was a problem hiding this comment.
Debug changes only.
| docker_file_path = build_dir / MODEL_DOCKERFILE_NAME | ||
| docker_file_path.write_text(dockerfile_contents) | ||
|
|
||
| def _calculate_sanitized_truss_hash(self, build_dir: Path) -> str: |
Contributor
Author
There was a problem hiding this comment.
Main change.
ndeepak-baseten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first-cut PR, and is not ready to merge.
🚀 What
Adjust truss hash calculation to ignore changes to environment variables.
Prior to this, dev builds for regular (non-custom-server) truss deployments rebuilt the image even on environment variable changes.
💻 How
Compute a reduced-set truss config for hash calculation.
🔬 Testing
Tested locally. Unit tests and integration tests pending.