-
Notifications
You must be signed in to change notification settings - Fork 42
Open
Description
👋 I've noticed that this silently fails (doesn't post a comment) if the repository doesn't have a .github/config.yml file.
I'm not sure how probot-config works, but looking at it I'd guess that it returns that defaultConfig if both the file and the file in a .github repository don't exist:
Line 24 in c245141
| const config = await getConfig(context, 'config.yml', defaultConfig) |
Instead its returning null, which results in an error log:
TypeError: Cannot read property 'requestInfoOn' of null
at receive (/app/index.js:26:19)
at process._tickCallback (internal/process/next_tick.js:68:7)
event: {
--
"id": "123",
"event": "issues.opened",
"repository": "JasonEtco/tests",
"installation": 123
}
cc @hollenberry
Stanzilla
Metadata
Metadata
Assignees
Labels
No labels