Skip to content

Commit 2c9dc57

Browse files
bobbrodiebobbrodie
authored
Merge pull request #25 from open-source-contributions/improve_assertequals
Let assertEquals change into assertSame
2 parents 4428301 + c805010 commit 2c9dc57

15 files changed

+102
-102
lines changed

‎test/unit/BitPayKeyUtils/KeyHelper/KeyTest.php‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public function testGetIdWhenIdSet()
2424
$id = 'test';
2525
$testedObject = $this->getTestedClass($id);
2626
$result = $testedObject->getId();
27-
$this->assertEquals($id, $result);
27+
$this->assertSame($id, $result);
2828
}
2929

3030
/**
@@ -37,7 +37,7 @@ public function testGetHex()
3737

3838
$this->setProtectedPropertyValue($testedObject, 'hex', $exampleValue);
3939
$result = $testedObject->getHex();
40-
$this->assertEquals($exampleValue, $result);
40+
$this->assertSame($exampleValue, $result);
4141
}
4242

4343
/**
@@ -50,7 +50,7 @@ public function testGetDec()
5050

5151
$this->setProtectedPropertyValue($testedObject, 'dec', $exampleValue);
5252
$result = $testedObject->getDec();
53-
$this->assertEquals($exampleValue, $result);
53+
$this->assertSame($exampleValue, $result);
5454
}
5555

5656
/**
@@ -75,11 +75,11 @@ public function testUnserialize()
7575

7676
$testedObject->unserialize($data);
7777

78-
$this->assertEquals('id', $testedObject->getId());
79-
$this->assertEquals('x', $testedObject->getX());
80-
$this->assertEquals('y', $testedObject->getY());
81-
$this->assertEquals('hex', $testedObject->getHex());
82-
$this->assertEquals('dec', $testedObject->getDec());
78+
$this->assertSame('id', $testedObject->getId());
79+
$this->assertSame('x', $testedObject->getX());
80+
$this->assertSame('y', $testedObject->getY());
81+
$this->assertSame('hex', $testedObject->getHex());
82+
$this->assertSame('dec', $testedObject->getDec());
8383
}
8484

8585
/**

‎test/unit/BitPayKeyUtils/KeyHelper/PrivateKeyTest.php‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public function testSetHex()
1717

1818
$testedObject->setHex( $exampleValue );
1919
$realValue = $this->accessProtected( $testedObject, 'hex' );
20-
$this->assertEquals( $exampleValue, $realValue );
20+
$this->assertSame( $exampleValue, $realValue );
2121
}
2222

2323
/**
@@ -42,7 +42,7 @@ public function testGenerateReturnsObjectWithHexIfHexIsSet()
4242
$testedObject->setHex( $expectedValue );
4343
$result = $testedObject->generate();
4444
$realValue = $this->accessProtected( $result, 'hex' );
45-
$this->assertEquals( $expectedValue, $realValue );
45+
$this->assertSame( $expectedValue, $realValue );
4646
}
4747

4848
public function testIsValidIfKeyNotSet()
@@ -109,8 +109,8 @@ public function testPemDecode()
109109
$result = $testedObject->pemDecode( self::EXAMPLE_ECDSA_KEY );
110110

111111
$this->assertIsArray( $result );
112-
$this->assertEquals( '52f7b0b9e2a06703bc758cfc13e5370f7a04ec7528a728daab2ae14c21414a2c', $result[ 'private_key' ] );
113-
$this->assertEquals(
112+
$this->assertSame( '52f7b0b9e2a06703bc758cfc13e5370f7a04ec7528a728daab2ae14c21414a2c', $result[ 'private_key' ] );
113+
$this->assertSame(
114114
'045ecd459aae1074f01b9f737271d114f873a3737916f5e7dbb28da423fbdd0d359c482324df5d2ce771b7b510a50c13cfbae240b0a8216cf7da4da52999714234',
115115
$result[ 'public_key' ] );
116116
}
@@ -177,7 +177,7 @@ public function test__toStringWhenHexIsSet()
177177
$testedObject = $this->createClassObject();
178178
$testedObject->setHex( self::EXAMPLE_HEX_STRING );
179179

180-
$this->assertEquals( self::EXAMPLE_HEX_STRING, (string) $testedObject );
180+
$this->assertSame( self::EXAMPLE_HEX_STRING, (string) $testedObject );
181181
}
182182

183183
public function testGetPublicKeyIfKeyIsNull()
@@ -195,7 +195,7 @@ public function testGetPublicKeyIfKeyIsNotNull()
195195
$secondResult = $testedObject->getPublicKey();
196196

197197
$this->assertInstanceOf( PublicKey::class, $firstResult );
198-
$this->assertEquals( $firstResult, $secondResult );
198+
$this->assertSame( $firstResult, $secondResult );
199199
}
200200

201201
private function createClassObject(): PrivateKey

‎test/unit/BitPayKeyUtils/KeyHelper/PublicKeyTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ public function testSetPrivateKey()
2727

2828
$testedObject = $this->getTestedClassObject();
2929
$testedObject->setPrivateKey($privateKeyMock);
30-
$this->assertEquals($privateKeyMock, $this->accessProtected($testedObject, 'privateKey'));
30+
$this->assertSame($privateKeyMock, $this->accessProtected($testedObject, 'privateKey'));
3131
}
3232

3333
public function testToStringWhenXIsNull()
3434
{
3535
$testedObject = $this->getTestedClassObject();
36-
$this->assertEquals('', (string)$testedObject);
36+
$this->assertSame('', (string)$testedObject);
3737
}
3838

3939
/**
@@ -47,7 +47,7 @@ public function testToStringWhenXIsNotNullAndMathModIs1()
4747
$this->setProtectedPropertyValue($testedObject, 'y', 1);
4848

4949
$toStringCompressionResult = '031';
50-
$this->assertEquals($toStringCompressionResult, (string)$testedObject);
50+
$this->assertSame($toStringCompressionResult, (string)$testedObject);
5151
}
5252

5353
/**
@@ -61,7 +61,7 @@ public function testToStringWhenXIsNotNullAndMathModIsNot1()
6161
$this->setProtectedPropertyValue($testedObject, 'y', 4);
6262

6363
$toStringCompressionResult = '021';
64-
$this->assertEquals($toStringCompressionResult, (string)$testedObject);
64+
$this->assertSame($toStringCompressionResult, (string)$testedObject);
6565
}
6666

6767
public function testIsValidWhenPublicKeyIsBlank()

‎test/unit/BitPayKeyUtils/KeyHelper/SinKeyTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,14 @@ public function test__toStringValue(): void
3333
$property = $this->getAccessibleProperty(SinKey::class, 'value');
3434
$value = $property->getValue($this->sinKey);
3535

36-
$this->assertEquals($value, $this->sinKey->__toString());
36+
$this->assertSame($value, $this->sinKey->__toString());
3737
}
3838

3939
public function testSetPublicKey(): void
4040
{
4141
$publicKey = $this->getMockBuilder(PublicKey::class)->getMock();
4242

43-
$this->assertEquals($this->sinKey, $this->sinKey->setPublicKey($publicKey));
43+
$this->assertSame($this->sinKey, $this->sinKey->setPublicKey($publicKey));
4444
}
4545

4646
public function testGenerateWithoutPublicKey(): void
@@ -65,12 +65,12 @@ public function testIsValid(): void
6565
$this->sinKey->setPublicKey($publicKey);
6666
$this->sinKey->generate();
6767

68-
$this->assertEquals(true, $this->sinKey->isValid());
68+
$this->assertSame(true, $this->sinKey->isValid());
6969
}
7070

7171
public function testIsValidFalse(): void
7272
{
73-
$this->assertEquals(false, $this->sinKey->isValid());
73+
$this->assertSame(false, $this->sinKey->isValid());
7474
}
7575

7676
private function getAccessibleProperty(string $class, string $property): ReflectionProperty

‎test/unit/BitPayKeyUtils/Math/BcEngineTest.php‎

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -16,31 +16,31 @@ public function testAdd()
1616
$expectedValue = '12';
1717

1818
$bcEngine = $this->createClassObject();
19-
$this->assertEquals($expectedValue, $bcEngine->add('5', '7'));
19+
$this->assertSame($expectedValue, $bcEngine->add('5', '7'));
2020
}
2121

2222
public function testInput()
2323
{
2424
$expectedValue = '5';
2525

2626
$bcEngine = $this->createClassObject();
27-
$this->assertEquals($expectedValue, $bcEngine->input($expectedValue));
27+
$this->assertSame($expectedValue, $bcEngine->input($expectedValue));
2828
}
2929

3030
public function testInputNull()
3131
{
3232
$expectedValue = '0';
3333

3434
$bcEngine = $this->createClassObject();
35-
$this->assertEquals($expectedValue, $bcEngine->input(null));
35+
$this->assertSame($expectedValue, $bcEngine->input(null));
3636
}
3737

3838
public function testInputHex()
3939
{
4040
$expectedValue = '86';
4141

4242
$bcEngine = $this->createClassObject();
43-
$this->assertEquals($expectedValue, $bcEngine->input('0x56'));
43+
$this->assertSame($expectedValue, $bcEngine->input('0x56'));
4444
}
4545

4646
public function testInputException()
@@ -53,122 +53,122 @@ public function testInputException()
5353

5454
public function testCmpGreaterThan()
5555
{
56-
$expectedValue = '1';
56+
$expectedValue = 1;
5757

5858
$bcEngine = $this->createClassObject();
59-
$this->assertEquals($expectedValue, $bcEngine->cmp('9', '7'));
59+
$this->assertSame($expectedValue, $bcEngine->cmp('9', '7'));
6060
}
6161

6262
public function testCmpLessThan()
6363
{
64-
$expectedValue = '-1';
64+
$expectedValue = -1;
6565

6666
$bcEngine = $this->createClassObject();
67-
$this->assertEquals($expectedValue, $bcEngine->cmp('7', '9'));
67+
$this->assertSame($expectedValue, $bcEngine->cmp('7', '9'));
6868
}
6969

7070
public function testCmpEqualsTo()
7171
{
72-
$expectedValue = '0';
72+
$expectedValue = 0;
7373

7474
$bcEngine = $this->createClassObject();
75-
$this->assertEquals($expectedValue, $bcEngine->cmp('7', '7'));
75+
$this->assertSame($expectedValue, $bcEngine->cmp('7', '7'));
7676
}
7777

7878
public function testDiv()
7979
{
8080
$expectedValue = '3';
8181

8282
$bcEngine = $this->createClassObject();
83-
$this->assertEquals($expectedValue, $bcEngine->div('6', '2'));
83+
$this->assertSame($expectedValue, $bcEngine->div('6', '2'));
8484
}
8585

8686
public function testInvertm()
8787
{
8888
$expectedValue = '0';
8989

9090
$bcEngine = $this->createClassObject();
91-
$this->assertEquals($expectedValue, $bcEngine->invertm('6', '2'));
91+
$this->assertSame($expectedValue, $bcEngine->invertm('6', '2'));
9292
}
9393

9494
public function testInvertm2()
9595
{
9696
$expectedValue = '1';
9797

9898
$bcEngine = $this->createClassObject();
99-
$this->assertEquals($expectedValue, $bcEngine->invertm('-1', '2'));
99+
$this->assertSame($expectedValue, $bcEngine->invertm('-1', '2'));
100100
}
101101

102102
public function testMod()
103103
{
104104
$expectedValue = '0';
105105

106106
$bcEngine = $this->createClassObject();
107-
$this->assertEquals($expectedValue, $bcEngine->mod('6', '2'));
107+
$this->assertSame($expectedValue, $bcEngine->mod('6', '2'));
108108
}
109109

110110
public function testMod2()
111111
{
112112
$expectedValue = '2';
113113

114114
$bcEngine = $this->createClassObject();
115-
$this->assertEquals($expectedValue, $bcEngine->mod('-6', '2'));
115+
$this->assertSame($expectedValue, $bcEngine->mod('-6', '2'));
116116
}
117117

118118
public function testMul()
119119
{
120120
$expectedValue = '21';
121121

122122
$bcEngine = $this->createClassObject();
123-
$this->assertEquals($expectedValue, $bcEngine->mul('3', '7'));
123+
$this->assertSame($expectedValue, $bcEngine->mul('3', '7'));
124124
}
125125

126126
public function testPow()
127127
{
128128
$expectedValue = '64';
129129

130130
$bcEngine = $this->createClassObject();
131-
$this->assertEquals($expectedValue, $bcEngine->pow('4', '3'));
131+
$this->assertSame($expectedValue, $bcEngine->pow('4', '3'));
132132
}
133133

134134
public function testSub()
135135
{
136136
$expectedValue = '18';
137137

138138
$bcEngine = $this->createClassObject();
139-
$this->assertEquals($expectedValue, $bcEngine->sub('20', '2'));
139+
$this->assertSame($expectedValue, $bcEngine->sub('20', '2'));
140140
}
141141

142142
public function testCoprime()
143143
{
144144
$expectedValue = false;
145145

146146
$bcEngine = $this->createClassObject();
147-
$this->assertEquals($expectedValue, $bcEngine->coprime('20', '2'));
147+
$this->assertSame($expectedValue, $bcEngine->coprime('20', '2'));
148148
}
149149

150150
public function testCoprime2()
151151
{
152152
$expectedValue = true;
153153

154154
$bcEngine = $this->createClassObject();
155-
$this->assertEquals($expectedValue, $bcEngine->coprime('5', '3'));
155+
$this->assertSame($expectedValue, $bcEngine->coprime('5', '3'));
156156
}
157157

158158
public function testCoprime3()
159159
{
160160
$expectedValue = true;
161161

162162
$bcEngine = $this->createClassObject();
163-
$this->assertEquals($expectedValue, $bcEngine->coprime('3', '5'));
163+
$this->assertSame($expectedValue, $bcEngine->coprime('3', '5'));
164164
}
165165

166166
public function testCoprime4()
167167
{
168168
$expectedValue = false;
169169

170170
$bcEngine = $this->createClassObject();
171-
$this->assertEquals($expectedValue, $bcEngine->coprime('3', '3'));
171+
$this->assertSame($expectedValue, $bcEngine->coprime('3', '3'));
172172
}
173173

174174
private function createClassObject()

0 commit comments

Comments
 (0)