Commit d5198bd
Fix test failures caused by LTR visual transformation
## Objective
Update test assertions to expect LTR-wrapped text in password and
sensitive fields following the implementation of ForceLtrVisualTransformation.
## Changes
- Made LRO and PDF constants public in ForceLtrVisualTransformation.kt
to enable cross-module access from :app tests
- Updated VaultAddEditScreenTest assertions (4 locations) to expect
text wrapped with Unicode LTR control characters (LRO/PDF)
- Updated VaultItemScreenTest assertions (3 locations) for password,
card number, and security code fields
- Added @Suppress("StringTemplate") annotations to maintain code
clarity with wrapped text format
## Technical Details
BitwardenPasswordField now applies ForceLtrVisualTransformation to
visible, read-only fields, wrapping text with `\u202A` (LRO) prefix
and `\u202C` (PDF) suffix to ensure left-to-right display in all
locales. Tests now correctly expect this transformed output.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 08636a6 commit d5198bd
File tree
3 files changed
+21
-9
lines changed- app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature
- addedit
- item
- ui/src/main/kotlin/com/bitwarden/ui/platform/components/util
3 files changed
+21
-9
lines changedLines changed: 10 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
| 45 | + | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
| |||
682 | 684 | | |
683 | 685 | | |
684 | 686 | | |
| 687 | + | |
685 | 688 | | |
686 | 689 | | |
687 | | - | |
| 690 | + | |
688 | 691 | | |
689 | 692 | | |
690 | 693 | | |
| |||
1004 | 1007 | | |
1005 | 1008 | | |
1006 | 1009 | | |
| 1010 | + | |
1007 | 1011 | | |
1008 | 1012 | | |
1009 | | - | |
| 1013 | + | |
1010 | 1014 | | |
1011 | 1015 | | |
1012 | 1016 | | |
1013 | 1017 | | |
1014 | 1018 | | |
1015 | 1019 | | |
| 1020 | + | |
1016 | 1021 | | |
1017 | 1022 | | |
1018 | | - | |
| 1023 | + | |
1019 | 1024 | | |
1020 | 1025 | | |
1021 | 1026 | | |
| |||
1040 | 1045 | | |
1041 | 1046 | | |
1042 | 1047 | | |
| 1048 | + | |
1043 | 1049 | | |
1044 | 1050 | | |
1045 | | - | |
| 1051 | + | |
1046 | 1052 | | |
1047 | 1053 | | |
1048 | 1054 | | |
| |||
Lines changed: 9 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
31 | 33 | | |
32 | 34 | | |
33 | 35 | | |
| |||
62 | 64 | | |
63 | 65 | | |
64 | 66 | | |
| 67 | + | |
65 | 68 | | |
66 | 69 | | |
67 | 70 | | |
| |||
1000 | 1003 | | |
1001 | 1004 | | |
1002 | 1005 | | |
| 1006 | + | |
1003 | 1007 | | |
1004 | 1008 | | |
1005 | | - | |
| 1009 | + | |
1006 | 1010 | | |
1007 | 1011 | | |
1008 | 1012 | | |
| |||
2797 | 2801 | | |
2798 | 2802 | | |
2799 | 2803 | | |
| 2804 | + | |
2800 | 2805 | | |
2801 | 2806 | | |
2802 | | - | |
| 2807 | + | |
2803 | 2808 | | |
2804 | 2809 | | |
2805 | 2810 | | |
| |||
2947 | 2952 | | |
2948 | 2953 | | |
2949 | 2954 | | |
| 2955 | + | |
2950 | 2956 | | |
2951 | 2957 | | |
2952 | | - | |
| 2958 | + | |
2953 | 2959 | | |
2954 | 2960 | | |
2955 | 2961 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
| 12 | + | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
0 commit comments