-
Notifications
You must be signed in to change notification settings - Fork 25
Replace log with tracing in WASM crate
#550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
+ Coverage 79.63% 79.65% +0.01%
==========================================
Files 302 302
Lines 32248 32251 +3
==========================================
+ Hits 25682 25688 +6
+ Misses 6566 6563 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| #[wasm_bindgen] | ||
| pub fn set_log_level(level: LogLevel) { | ||
| let log_level = convert_level(level); | ||
| set_max_level(log_level.to_level_filter()); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this wasn't being used anywhere. There is a way to dynamically reload the tracing subscriber but I didn't want to add that if it isn't being utilized.
|
Claude finished @neuronull's task —— View job Code Review: Replace
|
|
Note in the latest commit I switch to use |
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
585a91b to
726db7c
Compare
reverted that, @quexten noted that if we need to add layers as we may with flight recorder, wasm-tracing doesn't allow that. and it apparently doesn't support |

🎟️ Tracking
📔 Objective
Cascading the standardization of
tracingcrate from clients repo into the SDK, that was started per bitwarden/clients#16321, this change updates the WASM crate to use
tracing.📸 Screenshots
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes