-
Notifications
You must be signed in to change notification settings - Fork 25
chore: update to fixed argon2 crate #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixes the compilation errors described here: RustCrypto/password-hashes#736 this compilation error manifests itself when building various rust-based Secrets Manager clients
|
Great job! No new security vulnerabilities introduced in this pull request |
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
+ Coverage 79.63% 79.66% +0.02%
==========================================
Files 302 302
Lines 32248 32248
==========================================
+ Hits 25682 25691 +9
+ Misses 6566 6557 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Not sure why, but even after running the Android workflow 3 times, it keeps failing with a 409 error. |
|
Claude finished @tangowithfoxtrot's task —— View job Review CompleteThis PR appropriately addresses the argon2 compilation errors by updating from rc.1 to rc.2, which includes fixes for blake2 import issues. The changes are minimal and focused. Summary of ChangesCommit 1 (32a2108): Updated argon2 from The Cargo.lock update includes:
FindingsFinding 1: PR description lacks Jira reference in the Tracking section (💭) The Finding 2: Test plan is not described (💭) The PR description doesn't include how the changes were verified. Consider adding:
Suggested PR description improvements## 🎟️ Tracking
[JIRA-XXXX or "None - maintenance fix"]
## 📔 Objective
Fix the compilation errors described [here](https://github.com/RustCrypto/password-hashes/issues/736). This compilation error manifests when building various Rust-based [Secrets Manager clients](https://github.com/bitwarden/sm-action/actions/runs/19506757233/job/55834981484?pr=234#step:8:488).
The issue was caused by unresolved blake2 imports in argon2 0.6.0-rc.1. Updating to rc.2 resolves these transitive dependency issues.
## Test Plan
- ✅ Local build succeeds with `cargo build`
- ✅ Secrets Manager client compilation verified (provide link or confirmation)
- ✅ All CI checks passingGood Practices Observed
Action Items: None - findings are optional inquiries only. The code changes are correct and the PR is ready to merge pending maintainer discretion on documentation. |
quexten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like between rc1 and rc2 only some transitive dependencies changed. As long as this builds fine there is no concern from my side. Approving for KM.
dani-garcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not updating the Cargo.lock file, make sure to run cargo build after to ensure the lockfile is updated correctly.
9c318ac to
94a6492
Compare
|
@dani-garcia Thanks. I pushed the updated lockfile in 94a6492. |

🎟️ Tracking
📔 Objective
Fix the compilation errors described here. This compilation error manifests itself when building various Rust-based Secrets Manager clients.
🚨 Breaking Changes
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes