Skip to content

Conversation

@tangowithfoxtrot
Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot commented Nov 19, 2025

🎟️ Tracking

📔 Objective

Fix the compilation errors described here. This compilation error manifests itself when building various Rust-based Secrets Manager clients.

🚨 Breaking Changes

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

fixes the compilation errors described here:
RustCrypto/password-hashes#736

this compilation error manifests itself when
building various rust-based Secrets Manager clients
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

Logo
Checkmarx One – Scan Summary & Details84931251-361e-4435-b23f-76ece26aee89

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

🔍 SDK Breaking Change Detection Results

SDK Version: fix-unresolved-blake2-imports (94a6492)
Completed: 2025-11-20 13:44:48 UTC
Total Time: 216s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.66%. Comparing base (00c854d) to head (94a6492).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
+ Coverage   79.63%   79.66%   +0.02%     
==========================================
  Files         302      302              
  Lines       32248    32248              
==========================================
+ Hits        25682    25691       +9     
+ Misses       6566     6557       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tangowithfoxtrot
Copy link
Contributor Author

Not sure why, but even after running the Android workflow 3 times, it keeps failing with a 409 error.

@tangowithfoxtrot tangowithfoxtrot marked this pull request as ready for review November 19, 2025 16:44
@tangowithfoxtrot tangowithfoxtrot requested review from a team as code owners November 19, 2025 16:44
@claude
Copy link

claude bot commented Nov 19, 2025

Claude finished @tangowithfoxtrot's task —— View job


Review Complete

This PR appropriately addresses the argon2 compilation errors by updating from rc.1 to rc.2, which includes fixes for blake2 import issues. The changes are minimal and focused.

Summary of Changes

Commit 1 (32a2108): Updated argon2 from 0.6.0-rc.1 to 0.6.0-rc.2 in Cargo.toml
Commit 2 (94a6492): Updated Cargo.lock with transitive dependency changes

The Cargo.lock update includes:

  • argon2: rc.1 → rc.2
  • blake2: rc.2 → rc.3
  • digest: rc.3 → rc.4
  • crypto-common: rc.4 → rc.5
  • password-hash: rc.1 → rc.2
  • Addition of rand_core 0.10.0-rc-2

Findings

Finding 1: PR description lacks Jira reference in the Tracking section (💭)

The ## 🎟️ Tracking section is empty. While this may be intentional for maintenance work, consider adding a Jira task reference if one exists for tracking the compilation fix.

Finding 2: Test plan is not described (💭)

The PR description doesn't include how the changes were verified. Consider adding:

  • Confirmation that the compilation errors in the Secrets Manager clients are resolved
  • Any local build/test verification performed
Suggested PR description improvements
## 🎟️ Tracking

[JIRA-XXXX or "None - maintenance fix"]

## 📔 Objective

Fix the compilation errors described [here](https://github.com/RustCrypto/password-hashes/issues/736). This compilation error manifests when building various Rust-based [Secrets Manager clients](https://github.com/bitwarden/sm-action/actions/runs/19506757233/job/55834981484?pr=234#step:8:488).

The issue was caused by unresolved blake2 imports in argon2 0.6.0-rc.1. Updating to rc.2 resolves these transitive dependency issues.

## Test Plan

- ✅ Local build succeeds with `cargo build`
- ✅ Secrets Manager client compilation verified (provide link or confirmation)
- ✅ All CI checks passing

Good Practices Observed

  • Pinned exact version (=0.6.0-rc.2) for pre-release dependency
  • Followed up with lockfile update in separate commit for traceability
  • All CI checks passing (no breaking changes, security scan clean, coverage maintained)

Action Items: None - findings are optional inquiries only. The code changes are correct and the PR is ready to merge pending maintainer discretion on documentation.

quexten
quexten previously approved these changes Nov 19, 2025
Copy link
Contributor

@quexten quexten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like between rc1 and rc2 only some transitive dependencies changed. As long as this builds fine there is no concern from my side. Approving for KM.

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not updating the Cargo.lock file, make sure to run cargo build after to ensure the lockfile is updated correctly.

@tangowithfoxtrot tangowithfoxtrot force-pushed the fix-unresolved-blake2-imports branch from 9c318ac to 94a6492 Compare November 20, 2025 13:35
@tangowithfoxtrot tangowithfoxtrot marked this pull request as ready for review November 20, 2025 13:38
@tangowithfoxtrot
Copy link
Contributor Author

@dani-garcia Thanks. I pushed the updated lockfile in 94a6492.

@tangowithfoxtrot tangowithfoxtrot merged commit d5be37f into main Nov 20, 2025
65 checks passed
@tangowithfoxtrot tangowithfoxtrot deleted the fix-unresolved-blake2-imports branch November 20, 2025 13:54
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants