-
Notifications
You must be signed in to change notification settings - Fork 25
Replace log with tracing for ios and android uniffi
#566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace log with tracing for ios and android uniffi
#566
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
==========================================
- Coverage 79.63% 79.54% -0.10%
==========================================
Files 302 302
Lines 32256 32295 +39
==========================================
Hits 25688 25688
- Misses 6568 6607 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
84c195c to
063b63d
Compare
063b63d to
42a81e8
Compare
|
Claude finished @neuronull's task —— View job Code Review CompleteSummaryThis PR successfully migrates the FindingsFinding 1: PR title contains a typo❌ The PR title "Relplace Suggested correctionFinding 2: Test coverage gap is expected💭 Codecov reports 0% patch coverage with 54 lines missing coverage in
Consider documenting in the PR description that the coverage gap is intentional for initialization code. Finding 3: Enhanced structured logging capability👍 The migration to
Finding 4: Breaking change from android_logger behavior
Finding 5: Logger configuration is more comprehensive👍 The new
Good Practices Observed
Action Items
|
log with tracing for ios and android uniffilog with tracing for ios and android uniffi
…h `tracing` for ios and android uniffi (bitwarden/sdk-internal#566)

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26932
📔 Objective
Cascading the standardization of
tracingcrate from clients repo into the SDK, that was started per bitwarden/clients#16321, this change updates the
bitwarden-unifficrate to usetracing.android:
ios:
🚨 Breaking Changes
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes