Fixed issues with sequence diagram caller context (#415)

Author: bkryza

src/sequence_diagram/model/diagram.cc

@@ -110,15 +110,12 @@ void diagram::add_participant(std::unique_ptr<participant> p)
     else {
         if (participants_.at(participant_id)->full_name(false) !=
             p->full_name(false)) {
-            LOG_ERROR("Participant with id {} already exists but has different "
-                      "name {} [{}], {} [{}]",
+            LOG_WARN("Participant with id {} already exists but has different "
+                     "name {} [{}], {} [{}]",
                 participant_id.value(),
                 participants_.at(participant_id)->full_name(false),
                 participants_.at(participant_id)->id().usr(),
                 p->full_name(false), p->id().usr());
-
-            assert(participants_.at(participant_id)->full_name(false) ==
-                p->full_name(false));
         }
     }
 }

src/sequence_diagram/visitor/call_expression_context.cc

@@ -25,6 +25,11 @@ call_expression_context::call_expression_context() = default;
 void call_expression_context::reset()
 {
     current_caller_id_ = eid_t{};
+    reset_declarations();
+}
+
+void call_expression_context::reset_declarations()
+{
     current_class_decl_ = nullptr;
     current_class_template_decl_ = nullptr;
     current_class_template_specialization_decl_ = nullptr;
@@ -105,27 +110,32 @@ clang::ASTContext *call_expression_context::get_ast_context() const
 
 void call_expression_context::update(clang::CXXRecordDecl *cls)
 {
+    reset_declarations();
     current_class_decl_ = cls;
 }
 
 void call_expression_context::update(clang::ObjCInterfaceDecl *cls)
 {
+    reset_declarations();
     objc_interface_decl_ = cls;
 }
 
 void call_expression_context::update(clang::ObjCProtocolDecl *cls)
 {
+    reset_declarations();
     objc_protocol_decl_ = cls;
 }
 
 void call_expression_context::update(
     clang::ClassTemplateSpecializationDecl *clst)
 {
+    reset_declarations();
     current_class_template_specialization_decl_ = clst;
 }
 
 void call_expression_context::update(clang::ClassTemplateDecl *clst)
 {
+    reset_declarations();
     current_class_template_decl_ = clst;
 }
 
@@ -136,6 +146,7 @@ void call_expression_context::update(clang::CXXMethodDecl *method)
 
 void call_expression_context::update(clang::ObjCMethodDecl *method)
 {
+    reset_declarations();
     current_objc_method_decl_ = method;
 }
 

src/sequence_diagram/visitor/call_expression_context.h

@@ -56,6 +56,7 @@ struct call_expression_context {
      * @brief Reset call expression context to the original state.
      */
     void reset();
+    void reset_declarations();
 
     /**
      * @brief Verify that the context is in a valid state.

src/sequence_diagram/visitor/translation_unit_visitor.cc

@@ -3101,6 +3101,17 @@ void translation_unit_visitor::process_function_parameters(
     for (const auto *param : declaration.parameters()) {
         auto parameter_type =
             common::to_string(param->getType(), param->getASTContext());
+
+        if (param->getType().isConstQualified() &&
+            !param->getType()->isPointerType() &&
+            !param->getType()->isReferenceType()) {
+            auto non_const_type = param->getType();
+            non_const_type.removeLocalConst();
+
+            parameter_type =
+                common::to_string(non_const_type, param->getASTContext());
+        }
+
         common::ensure_lambda_type_is_relative(config(), parameter_type);
         parameter_type = simplify_system_template(parameter_type);
 

uml/sequence/template_builder_sequence.yml

@@ -18,4 +18,4 @@ exclude:
 using_namespace:
   - clanguml
 from:
-  - function: "clanguml::common::visitor::template_builder<VisitorT>::build(const clang::NamedDecl &,common::model::template_element &,const clang::NamedDecl *,const clang::TemplateDecl *,const clang::ArrayRef<clang::TemplateArgument>,std::string,std::optional<common::model::template_element *>)"
+  - function: "clanguml::common::visitor::template_builder<VisitorT>::build(const clang::NamedDecl &,common::model::template_element &,const clang::NamedDecl *,const clang::TemplateDecl *,clang::ArrayRef<clang::TemplateArgument>,std::string,std::optional<common::model::template_element *>)"