caddyhttp: fix escaped path matcher over-matching longer paths#7828
Open
alhudz wants to merge 1 commit into
Open
caddyhttp: fix escaped path matcher over-matching longer paths#7828alhudz wants to merge 1 commit into
alhudz wants to merge 1 commit into
Conversation
Member
|
@alhudz the code is fine but we really need the assistance disclosure mate... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:
path /foo%2fbar(a%-escaped pattern with no trailing wildcard) matches a request to/foo%2fbarbaz. The plain pattern/foobarcorrectly does not match/foobarbaz, so escaped patterns silently behave like prefix matches.Cause:
matchPatternWithEscapeSequencewalks the pattern and escaped path in lock-step and stops once the pattern is consumed, so trailing path bytes never make it into the string handed topath.Match; it then only ever sees the prefix.Fix: append the remaining (normalised) path bytes after the loop so
path.Matchcompares the whole path. Exact patterns now reject longer paths while wildcard patterns are unaffected.