Skip to content

Commit 0df1086

Browse files
fix: add noop domain audit manager for test cluster
- Create noopDomainAuditManager to satisfy DomainAuditManager interface - Update NewReplicationTaskExecutor calls with new signature - Pass EnableDomainAuditLogging dynamic property 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: David Porter <[email protected]>
1 parent 7d1c252 commit 0df1086

File tree

2 files changed

+23
-2
lines changed

2 files changed

+23
-2
lines changed

host/testcluster.go

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ func NewCluster(t *testing.T, options *TestClusterConfig, logger log.Logger, par
185185
MatchingConfig: options.MatchingConfig,
186186
WorkerConfig: options.WorkerConfig,
187187
MockAdminClient: options.MockAdminClient,
188-
DomainReplicationTaskExecutor: domain.NewReplicationTaskExecutor(testBase.DomainManager, testBase.DomainAuditManager, clock.NewRealTimeSource(), logger),
188+
DomainReplicationTaskExecutor: domain.NewReplicationTaskExecutor(testBase.DomainManager, newNoopDomainAuditManager(), clock.NewRealTimeSource(), logger, dynamicproperties.GetBoolPropertyFn(false)),
189189
AuthorizationConfig: aConfig,
190190
AsyncWFQueues: options.AsyncWFQueues,
191191
TimeSource: options.TimeSource,
@@ -266,7 +266,7 @@ func NewPinotTestCluster(t *testing.T, options *TestClusterConfig, logger log.Lo
266266
MatchingConfig: options.MatchingConfig,
267267
WorkerConfig: options.WorkerConfig,
268268
MockAdminClient: options.MockAdminClient,
269-
DomainReplicationTaskExecutor: domain.NewReplicationTaskExecutor(testBase.DomainManager, testBase.DomainAuditManager, clock.NewRealTimeSource(), logger),
269+
DomainReplicationTaskExecutor: domain.NewReplicationTaskExecutor(testBase.DomainManager, newNoopDomainAuditManager(), clock.NewRealTimeSource(), logger, dynamicproperties.GetBoolPropertyFn(false)),
270270
AuthorizationConfig: aConfig,
271271
PinotConfig: options.PinotConfig,
272272
PinotClient: pinotClient,
@@ -354,6 +354,26 @@ func NewPersistenceTestCluster(t *testing.T, clusterConfig *TestClusterConfig) t
354354
return testCluster
355355
}
356356

357+
func newNoopDomainAuditManager() persistence.DomainAuditManager {
358+
return &noopDomainAuditManager{}
359+
}
360+
361+
type noopDomainAuditManager struct{}
362+
363+
func (n *noopDomainAuditManager) GetName() string {
364+
return "noop"
365+
}
366+
367+
func (n *noopDomainAuditManager) Close() {}
368+
369+
func (n *noopDomainAuditManager) CreateDomainAuditLog(ctx context.Context, request *persistence.CreateDomainAuditLogRequest) (*persistence.CreateDomainAuditLogResponse, error) {
370+
return &persistence.CreateDomainAuditLogResponse{}, nil
371+
}
372+
373+
func (n *noopDomainAuditManager) GetDomainAuditLogs(ctx context.Context, request *persistence.GetDomainAuditLogsRequest) (*persistence.GetDomainAuditLogsResponse, error) {
374+
return &persistence.GetDomainAuditLogsResponse{}, nil
375+
}
376+
357377
func setupShards(testBase *persistencetests.TestBase, numHistoryShards int, logger log.Logger) {
358378
// shard 0 is always created, we create additional shards if needed
359379
for shardID := 1; shardID < numHistoryShards; shardID++ {

service/frontend/config/config.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@ func NewConfig(dc *dynamicconfig.Collection, numHistoryShards int, isAdvancedVis
189189
EmitSignalNameMetricsTag: dc.GetBoolPropertyFilteredByDomain(dynamicproperties.FrontendEmitSignalNameMetricsTag),
190190
Lockdown: dc.GetBoolPropertyFilteredByDomain(dynamicproperties.Lockdown),
191191
EnableTasklistIsolation: dc.GetBoolPropertyFilteredByDomain(dynamicproperties.EnableTasklistIsolation),
192+
EnableDomainAuditLogging: dc.GetBoolProperty(dynamicproperties.EnableDomainAuditLogging),
192193
DomainConfig: domain.Config{
193194
MaxBadBinaryCount: dc.GetIntPropertyFilteredByDomain(dynamicproperties.FrontendMaxBadBinaries),
194195
MinRetentionDays: dc.GetIntProperty(dynamicproperties.MinRetentionDays),

0 commit comments

Comments
 (0)