Skip to content

Commit 7c1d1d5

Browse files
authored
fix(shard-distributor): change to migration dynamic config name (#7441)
<!-- Describe what has changed in this PR --> **What changed?** Changed to use the standard naming convention was not reflected in development config <!-- Tell your future self why have you made these changes --> **Why?** when starting the services only the namespaces with default behavior where receiving the righe configuration from SD. the misconfigured ones were still operating since the result was an invalid migration mode, but the shadow mode was not really tested in local environment after the change of the property name. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** local development <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** no, only affect local development <!-- Is it notable for release? e.g. schema updates, configuration or data migration required? If so, please mention it, and also update CHANGELOG.md --> **Release notes** <!-- Is there any documentation updates should be made for config, https://cadenceworkflow.io/docs/operation-guide/setup/ ? If so, please open an PR in https://github.com/cadence-workflow/cadence-docs --> **Documentation Changes** Signed-off-by: edigregorio <[email protected]>
1 parent 90dcbc7 commit 7c1d1d5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

config/dynamicconfig/development.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,17 +75,17 @@ system.domainAuditLogTTL:
7575
- value: "15m"
7676
matching.enableClientAutoConfig:
7777
- value: true
78-
shardDistributor.MigrationMode:
78+
shardDistributor.migrationMode:
7979
- value: "onboarded"
8080
- value: "local_pass"
8181
constraints:
82-
namespace: "test-local-passthrough"
82+
namespace: "test-local-passthrough"
8383
- value: "local_pass_shadow"
8484
constraints:
85-
namespace: "test-local-passthrough-shadow"
85+
namespace: "test-local-passthrough-shadow"
8686
- value: "distributed_pass"
8787
constraints:
88-
namespace: "test-distributed-passthrough"
88+
namespace: "test-distributed-passthrough"
8989
- value: "distributed_pass"
9090
constraints:
91-
namespace: "test-external-assignment"
91+
namespace: "test-external-assignment"

0 commit comments

Comments
 (0)