Skip to content

Commit 5192d77

Browse files
committed
Merge branch 'Roemer-feature/XmlImprovements' into develop
2 parents f21b485 + d5e2c57 commit 5192d77

File tree

6 files changed

+245
-132
lines changed

6 files changed

+245
-132
lines changed

src/Cake.Common.Tests/Cake.Common.Tests.csproj

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,22 @@
4444
<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
4545
</ItemGroup>
4646

47+
<ItemGroup>
48+
<Compile Update="Properties\Resources.Designer.cs">
49+
<DesignTime>True</DesignTime>
50+
<AutoGen>True</AutoGen>
51+
<DependentUpon>Resources.resx</DependentUpon>
52+
</Compile>
53+
</ItemGroup>
54+
55+
<ItemGroup>
56+
<EmbeddedResource Update="Properties\Resources.resx">
57+
<Generator>PublicResXFileCodeGenerator</Generator>
58+
<LastGenOutput>Resources.Designer.cs</LastGenOutput>
59+
</EmbeddedResource>
60+
<EmbeddedResource Update="Properties\Resources2.resx">
61+
<Generator></Generator>
62+
</EmbeddedResource>
63+
</ItemGroup>
64+
4765
</Project>

src/Cake.Common.Tests/Fixtures/XmlPokeFixture.cs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public string PokeString(string xml, string xpath, string value)
5555

5656
public bool TestIsValue(string xpath, string value)
5757
{
58-
var xmlString = new StreamReader(FileSystem.GetFile(XmlPath).OpenRead()).ReadToEnd();
58+
var xmlString = GetFullXml();
5959
return TestIsValue(xmlString, xpath, value);
6060
}
6161

@@ -81,7 +81,7 @@ public bool TestIsValue(string xml, string xpath, string value)
8181

8282
public bool TestIsRemoved(string xpath)
8383
{
84-
var xmlString = new StreamReader(FileSystem.GetFile(XmlPath).OpenRead()).ReadToEnd();
84+
var xmlString = GetFullXml();
8585
return TestIsRemoved(xmlString, xpath);
8686
}
8787

@@ -105,6 +105,11 @@ public bool TestIsRemoved(string xml, string xpath)
105105
}
106106
}
107107

108+
private string GetFullXml()
109+
{
110+
return new StreamReader(FileSystem.GetFile(XmlPath).OpenRead()).ReadToEnd();
111+
}
112+
108113
/// <summary>
109114
/// Gets a XmlReaderSettings from a XmlPokeSettings
110115
/// </summary>

0 commit comments

Comments
 (0)