test: preserve snapshot and daemon cleanup evidence

Author: thymikee

packages/daemon/src/sessions/handlers/snapshot-runtime-disclosure.test.ts

@@ -138,8 +138,9 @@ test('a snapshot after a scroll that moved nothing warns and stamps the no-effec
     await vi.advanceTimersByTimeAsync(100);
     await new Promise((resolve) => realSetTimeout(resolve, 1));
   }
-  await pending;
+  const response = await pending;
 
+  expect(response.ok).toBe(true);
   expect(input.sessionStore.get(input.sessionName)?.snapshot?.postGestureOutcome).toEqual(outcome);
 });
 

src/commands/capture/runtime/snapshot.test.ts

@@ -841,6 +841,25 @@ test('runtime snapshot warns when its tree was read on a surface still moving af
   assert.deepEqual(result.warnings, [formatPostGestureOutcomeWarning(outcome)]);
 });
 
+test('runtime snapshot warns when a gesture produced no visible change', async () => {
+  const outcome: PostGestureOutcome = {
+    kind: 'no-effect',
+    gesture: { action: 'scroll', positionals: ['up'] },
+  };
+  const device = createSnapshotOnlyDevice({
+    snapshot: {
+      ...makeSnapshotState([{ index: 0, depth: 0, type: 'Window', label: 'Home' }], {
+        backend: 'xctest',
+      }),
+      postGestureOutcome: outcome,
+    },
+  });
+
+  const result = await device.capture.snapshot({ session: 'default' });
+
+  assert.deepEqual(result.warnings, [formatPostGestureOutcomeWarning(outcome)]);
+});
+
 // The box a capture's rects are measured in is public output (#3182) for the same reason the
 // keyboard band is: `snapshot --json` is how a caller learns the surface to scale against, and a
 // producer that measured no box has to leave the key off rather than claim a screen it never read.

src/daemon-runtime-limrun-public-http.test.ts

@@ -77,33 +77,35 @@ test('public HTTP rejects Limrun uploaded-app listing and allocation before prov
     limrunTestDependencies,
   );
   rootPorts.providerComposition.mockResolvedValue({ runtimes: [limrun], platformModules: [] });
-  const runtime = await startDaemonRuntime({
-    composeDeps: createDaemonRuntimeDeps,
-    env: {
-      ...process.env,
-      AGENT_DEVICE_STATE_DIR: stateDir,
-      AGENT_DEVICE_DAEMON_IDLE_TIMEOUT_MS: '0',
-      AGENT_DEVICE_DAEMON_SERVER_MODE: 'http',
-      LIM_ANDROID_INSTANCE_URL: 'https://region.limrun.example/v1/android_test/api',
-      LIM_ANDROID_INSTANCE_TOKEN: 'lim-test-token',
-      LIM_ANDROID_INSTANCE_ADB_URL: 'https://region.limrun.example/v1/android_test/adb',
-    },
-    exit: () => {},
-    registerProcessHandlers: false,
-    stderr: { write: () => {} },
-    stdout: { write: () => {} },
-  });
+  let runtime: Awaited<ReturnType<typeof startDaemonRuntime>> | undefined;
 
   try {
-    if (!runtime?.httpPort) throw new Error('HTTP daemon runtime did not start');
+    runtime = await startDaemonRuntime({
+      composeDeps: createDaemonRuntimeDeps,
+      env: {
+        ...process.env,
+        AGENT_DEVICE_STATE_DIR: stateDir,
+        AGENT_DEVICE_DAEMON_IDLE_TIMEOUT_MS: '0',
+        AGENT_DEVICE_DAEMON_SERVER_MODE: 'http',
+        LIM_ANDROID_INSTANCE_URL: 'https://region.limrun.example/v1/android_test/api',
+        LIM_ANDROID_INSTANCE_TOKEN: 'lim-test-token',
+        LIM_ANDROID_INSTANCE_ADB_URL: 'https://region.limrun.example/v1/android_test/adb',
+      },
+      exit: () => {},
+      registerProcessHandlers: false,
+      stderr: { write: () => {} },
+      stdout: { write: () => {} },
+    });
+    const activeRuntime = runtime;
+    if (!activeRuntime?.httpPort) throw new Error('HTTP daemon runtime did not start');
     limrunIo.listAssets.mockClear();
     limrunIo.createAndroidInstance.mockClear();
 
     const callRpc = async (payload: Record<string, unknown>) => {
-      const response = await fetch(`http://127.0.0.1:${runtime.httpPort}/rpc`, {
+      const response = await fetch(`http://127.0.0.1:${activeRuntime.httpPort}/rpc`, {
         method: 'POST',
         headers: {
-          authorization: `Bearer ${runtime.token}`,
+          authorization: `Bearer ${activeRuntime.token}`,
           'content-type': 'application/json',
           [DAEMON_HTTP_NETWORK_ACCESS_HEADER]: DAEMON_HTTP_PUBLIC_NETWORK_ACCESS,
         },
@@ -147,7 +149,8 @@ test('public HTTP rejects Limrun uploaded-app listing and allocation before prov
   } finally {
     await runtime?.shutdown();
     await limrun.shutdown();
-    assert.equal(rootPorts.applicationLifecycle.finalizeDaemonShutdown.mock.calls.length, 1);
     fs.rmSync(paths.baseDir, { recursive: true, force: true });
+    if (runtime)
+      assert.equal(rootPorts.applicationLifecycle.finalizeDaemonShutdown.mock.calls.length, 1);
   }
 });

src/platform-runtime-gateway-gesture-admission.test.ts

@@ -29,9 +29,7 @@ test('Android phones and emulators admit single- and multi-touch gesture plans',
 test('target-authored drag is admitted only where adapters preserve every authored phase', async () => {
   const supported = [
     device({ kind: 'device', target: 'mobile' }),
-    device({ platform: 'apple', appleOs: 'ios', kind: 'device', target: 'mobile' }),
     device({ platform: 'apple', appleOs: 'ios', kind: 'simulator', target: 'mobile' }),
-    device({ platform: 'apple', appleOs: 'ipados', kind: 'device', target: 'mobile' }),
     device({ platform: 'apple', appleOs: 'ipados', kind: 'simulator', target: 'mobile' }),
     device({ platform: 'apple', kind: 'simulator', target: 'mobile' }),
   ];