From 16b0788771d17eb22a177a0cc588464f1412d445 Mon Sep 17 00:00:00 2001 From: Jakub Romanczyk Date: Tue, 13 May 2025 15:32:11 +0200 Subject: [PATCH 1/3] fix: hide persistent cache behind flag --- .../common/config/getCommandConfig.ts | 23 +++++++++++++------ 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/packages/repack/src/commands/common/config/getCommandConfig.ts b/packages/repack/src/commands/common/config/getCommandConfig.ts index 26c9788d1..b129328f9 100644 --- a/packages/repack/src/commands/common/config/getCommandConfig.ts +++ b/packages/repack/src/commands/common/config/getCommandConfig.ts @@ -1,14 +1,23 @@ import { DEFAULT_HOSTNAME, DEFAULT_PORT } from '../../consts.js'; +function isExperimentalCacheEnabled() { + return ( + process.env.REPACK_EXPERIMENTAL_CACHE === 'true' || + process.env.REPACK_EXPERIMENTAL_CACHE === '1' + ); +} + function getCacheConfig(bundler: 'rspack' | 'webpack') { - if (bundler === 'rspack') { - return { - cache: true, - experiments: { cache: { type: 'persistent' } }, - }; + if (isExperimentalCacheEnabled()) { + if (bundler === 'rspack') { + return { + cache: true, + experiments: { cache: { type: 'persistent' } }, + }; + } + return { cache: { type: 'filesystem' } }; } - - return { cache: { type: 'filesystem' } }; + return {}; } function getStartCommandDefaults(bundler: 'rspack' | 'webpack') { From e087aa6fa4b0593aac74698f1352d3def852845c Mon Sep 17 00:00:00 2001 From: Jakub Romanczyk Date: Tue, 13 May 2025 17:46:42 +0200 Subject: [PATCH 2/3] refactor: use env key --- .../repack/src/commands/common/config/getCommandConfig.ts | 5 +++-- packages/repack/src/env.ts | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/repack/src/commands/common/config/getCommandConfig.ts b/packages/repack/src/commands/common/config/getCommandConfig.ts index b129328f9..f080b7a30 100644 --- a/packages/repack/src/commands/common/config/getCommandConfig.ts +++ b/packages/repack/src/commands/common/config/getCommandConfig.ts @@ -1,9 +1,10 @@ +import { EXPERIMENTAL_CACHE_ENV_KEY } from '../../../env.js'; import { DEFAULT_HOSTNAME, DEFAULT_PORT } from '../../consts.js'; function isExperimentalCacheEnabled() { return ( - process.env.REPACK_EXPERIMENTAL_CACHE === 'true' || - process.env.REPACK_EXPERIMENTAL_CACHE === '1' + process.env[EXPERIMENTAL_CACHE_ENV_KEY] === 'true' || + process.env[EXPERIMENTAL_CACHE_ENV_KEY] === '1' ); } diff --git a/packages/repack/src/env.ts b/packages/repack/src/env.ts index f34405f76..b9c04d3f0 100644 --- a/packages/repack/src/env.ts +++ b/packages/repack/src/env.ts @@ -4,3 +4,5 @@ export const WORKER_ENV_KEY = 'REPACK_WORKER'; export const BUNDLE_FILENAME_ENV_KEY = 'REPACK_BUNDLE_FILENAME'; export const SOURCEMAP_FILENAME_ENV_KEY = 'REPACK_SOURCEMAP_FILENAME'; export const ASSETS_DEST_ENV_KEY = 'REPACK_ASSETS_DEST'; + +export const EXPERIMENTAL_CACHE_ENV_KEY = 'REPACK_EXPERIMENTAL_CACHE'; From d67e0c81cee30911965d7467c7c0f5debb1409db Mon Sep 17 00:00:00 2001 From: Jakub Romanczyk Date: Tue, 13 May 2025 17:50:14 +0200 Subject: [PATCH 3/3] chore: changeset --- .changeset/sharp-socks-dress.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/sharp-socks-dress.md diff --git a/.changeset/sharp-socks-dress.md b/.changeset/sharp-socks-dress.md new file mode 100644 index 000000000..555420480 --- /dev/null +++ b/.changeset/sharp-socks-dress.md @@ -0,0 +1,5 @@ +--- +"@callstack/repack": patch +--- + +Hide persistent cache behind `REPACK_EXPERIMENTAL_CACHE` flag