Skip to content

Commit 7abe0a5

Browse files
krithika369Krithika Sundararajan
andauthored
Fix experiment engine dynamic config load (#214)
Co-authored-by: Krithika Sundararajan <[email protected]>
1 parent c7864f6 commit 7abe0a5

File tree

1 file changed

+15
-19
lines changed

1 file changed

+15
-19
lines changed

ui/src/components/experiments/ExperimentEngineLoaderComponent.js

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -27,35 +27,31 @@ export const ExperimentEngineLoaderComponent = ({
2727
const [configReady, setConfigReady] = useState(false);
2828
const [configFailed, setConfigFailed] = useState(false);
2929

30-
if (!!experimentEngine.url && !urlReady) {
31-
return urlFailed ? (
32-
<FallbackView text={"Failed to load Experiment Engine"} />
33-
) : (
34-
<>
30+
return urlFailed ? (
31+
<FallbackView text={"Failed to load Experiment Engine"} />
32+
) : configFailed ? (
33+
<FallbackView text={"Failed to load Experiment Engine Config"} />
34+
) : !urlReady || !configReady ? (
35+
<>
36+
{!!experimentEngine.url && !urlReady && (
3537
<LoadDynamicScript
3638
setReady={setUrlReady}
3739
setFailed={setUrlFailed}
3840
url={experimentEngine.url}
3941
/>
40-
<FallbackView text={"Loading Experiment Engine..."} />
41-
</>
42-
);
43-
} else if (!!experimentEngine.config && !configReady) {
44-
return configFailed ? (
45-
<FallbackView text={"Failed to load Experiment Engine Config"} />
46-
) : (
47-
<>
42+
)}
43+
{!!experimentEngine.config && !configReady && (
4844
<LoadDynamicScript
4945
setReady={setConfigReady}
5046
setFailed={setConfigFailed}
5147
url={experimentEngine.config}
5248
/>
53-
<FallbackView text={"Loading Experiment Engine Config..."} />
54-
</>
55-
);
56-
}
57-
58-
return children;
49+
)}
50+
<FallbackView text={"Loading Experiment Engine..."} />
51+
</>
52+
) : (
53+
children
54+
);
5955
};
6056

6157
export default ExperimentEngineLoaderComponent;

0 commit comments

Comments
 (0)