Skip to content

Commit 47c6200

Browse files
authored
build(deps): upgrade go-git from v5.18.0 to v6.0.0-alpha.2 (#3078)
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
1 parent b19e267 commit 47c6200

5 files changed

Lines changed: 57 additions & 51 deletions

File tree

go.mod

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ require (
7272
github.com/casbin/casbin/v2 v2.103.0
7373
github.com/denisbrodbeck/machineid v1.0.1
7474
github.com/extism/go-sdk v1.7.1
75+
github.com/go-git/go-git/v6 v6.0.0-alpha.2 // recommended path: https://github.com/go-git/go-git/issues/1943#issuecomment-4232656963
7576
github.com/google/go-github/v66 v66.0.0
7677
github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.3.3
7778
github.com/grpc-ecosystem/grpc-gateway/v2 v2.27.4
@@ -164,7 +165,7 @@ require (
164165
github.com/cpuguy83/dockercfg v0.3.2 // indirect
165166
github.com/cpuguy83/go-md2man/v2 v2.0.7 // indirect
166167
github.com/creack/pty v1.1.21 // indirect
167-
github.com/cyphar/filepath-securejoin v0.4.1 // indirect
168+
github.com/cyphar/filepath-securejoin v0.6.1 // indirect
168169
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.0 // indirect
169170
github.com/distribution/reference v0.6.0 // indirect
170171
github.com/dsnet/compress v0.0.2-0.20230904184137-39efe44ab707 // indirect
@@ -182,7 +183,9 @@ require (
182183
github.com/gitleaks/go-gitdiff v0.9.1 // indirect
183184
github.com/go-chi/chi/v5 v5.2.5 // indirect
184185
github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 // indirect
186+
github.com/go-git/gcfg/v2 v2.0.2 // indirect
185187
github.com/go-git/go-billy/v5 v5.8.0 // indirect
188+
github.com/go-git/go-billy/v6 v6.0.0-20260328065524-593ae452e14d // indirect
186189
github.com/go-ini/ini v1.67.0 // indirect
187190
github.com/go-jose/go-jose/v4 v4.1.4 // indirect
188191
github.com/go-ole/go-ole v1.3.0 // indirect
@@ -216,8 +219,8 @@ require (
216219
github.com/jackc/puddle/v2 v2.2.2 // indirect
217220
github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99 // indirect
218221
github.com/jellydator/ttlcache/v3 v3.4.0 // indirect
219-
github.com/kevinburke/ssh_config v1.2.0 // indirect
220-
github.com/klauspost/cpuid/v2 v2.2.5 // indirect
222+
github.com/kevinburke/ssh_config v1.6.0 // indirect
223+
github.com/klauspost/cpuid/v2 v2.3.0 // indirect
221224
github.com/klauspost/pgzip v1.2.6 // indirect
222225
github.com/kylelemons/godebug v1.1.0 // indirect
223226
github.com/lestrrat-go/blackmagic v1.0.4 // indirect
@@ -256,7 +259,7 @@ require (
256259
github.com/package-url/packageurl-go v0.1.1 // indirect
257260
github.com/pelletier/go-toml v1.9.5 // indirect
258261
github.com/pierrec/lz4/v4 v4.1.22 // indirect
259-
github.com/pjbgf/sha1cd v0.3.2 // indirect
262+
github.com/pjbgf/sha1cd v0.5.0 // indirect
260263
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c // indirect
261264
github.com/pkg/xattr v0.4.9 // indirect
262265
github.com/planetscale/vtprotobuf v0.6.1-0.20240319094008-0393e58bdf10 // indirect
@@ -328,7 +331,7 @@ require (
328331
github.com/Azure/azure-sdk-for-go/sdk/keyvault/azsecrets v0.12.0
329332
github.com/Azure/go-ansiterm v0.0.0-20250102033503-faa5f7b0171c // indirect
330333
github.com/Microsoft/go-winio v0.6.2 // indirect
331-
github.com/ProtonMail/go-crypto v1.1.6 // indirect
334+
github.com/ProtonMail/go-crypto v1.4.1 // indirect
332335
github.com/ThalesIgnite/crypto11 v1.2.5 // indirect
333336
github.com/agext/levenshtein v1.2.3 // indirect
334337
github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2 // indirect
@@ -356,7 +359,7 @@ require (
356359
github.com/emicklei/go-restful/v3 v3.13.0 // indirect
357360
github.com/fsnotify/fsnotify v1.9.0 // indirect
358361
github.com/fsouza/fake-gcs-server v1.47.6
359-
github.com/go-git/go-git/v5 v5.18.0
362+
github.com/go-git/go-git/v5 v5.18.0 // indirect
360363
github.com/go-kratos/aegis v0.2.0 // indirect
361364
github.com/go-logr/logr v1.4.3 // indirect
362365
github.com/go-logr/stdr v1.2.2 // indirect

go.sum

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,8 @@ github.com/Microsoft/go-winio v0.6.1/go.mod h1:LRdKpFKfdobln8UmuiYcKPot9D2v6svN5
125125
github.com/Microsoft/go-winio v0.6.2 h1:F2VQgta7ecxGYO8k3ZZz3RS8fVIXVxONVUPlNERoyfY=
126126
github.com/Microsoft/go-winio v0.6.2/go.mod h1:yd8OoFMLzJbo9gZq8j5qaps8bJ9aShtEA8Ipt1oGCvU=
127127
github.com/ProtonMail/go-crypto v0.0.0-20230828082145-3c4c8a2d2371/go.mod h1:EjAoLdwvbIOoOQr3ihjnSoLZRtE8azugULFRteWMNc0=
128-
github.com/ProtonMail/go-crypto v1.1.6 h1:ZcV+Ropw6Qn0AX9brlQLAUXfqLBc7Bl+f/DmNxpLfdw=
129-
github.com/ProtonMail/go-crypto v1.1.6/go.mod h1:rA3QumHc/FZ8pAHreoekgiAbzpNsfQAosU5td4SnOrE=
128+
github.com/ProtonMail/go-crypto v1.4.1 h1:9RfcZHqEQUvP8RzecWEUafnZVtEvrBVL9BiF67IQOfM=
129+
github.com/ProtonMail/go-crypto v1.4.1/go.mod h1:e1OaTyu5SYVrO9gKOEhTc+5UcXtTUa+P3uLudwcgPqo=
130130
github.com/STARRY-S/zip v0.2.3 h1:luE4dMvRPDOWQdeDdUxUoZkzUIpTccdKdhHHsQJ1fm4=
131131
github.com/STARRY-S/zip v0.2.3/go.mod h1:lqJ9JdeRipyOQJrYSOtpNAiaesFO6zVDsE8GIGFaoSk=
132132
github.com/Shopify/sarama v1.19.0/go.mod h1:FVkBWblsNy7DGZRfXLU0O9RCGt5g3g3yEuWXgklEdEo=
@@ -320,8 +320,8 @@ github.com/creack/pty v1.1.21/go.mod h1:MOBLtS5ELjhRRrroQr9kyvTxUAFNvYEK993ew/Vr
320320
github.com/cyberphone/json-canonicalization v0.0.0-20241213102144-19d51d7fe467 h1:uX1JmpONuD549D73r6cgnxyUu18Zb7yHAy5AYU0Pm4Q=
321321
github.com/cyberphone/json-canonicalization v0.0.0-20241213102144-19d51d7fe467/go.mod h1:uzvlm1mxhHkdfqitSA92i7Se+S9ksOn3a3qmv/kyOCw=
322322
github.com/cyphar/filepath-securejoin v0.2.4/go.mod h1:aPGpWjXOXUn2NCNjFvBE6aRxGGx79pTxQpKOJNYHHl4=
323-
github.com/cyphar/filepath-securejoin v0.4.1 h1:JyxxyPEaktOD+GAnqIqTf9A8tHyAG22rowi7HkoSU1s=
324-
github.com/cyphar/filepath-securejoin v0.4.1/go.mod h1:Sdj7gXlvMcPZsbhwhQ33GguGLDGQL7h7bg04C/+u9jI=
323+
github.com/cyphar/filepath-securejoin v0.6.1 h1:5CeZ1jPXEiYt3+Z6zqprSAgSWiggmpVyciv8syjIpVE=
324+
github.com/cyphar/filepath-securejoin v0.6.1/go.mod h1:A8hd4EnAeyujCJRrICiOWqjS1AX0a9kM5XL+NwKoYSc=
325325
github.com/danieljoos/wincred v1.2.3 h1:v7dZC2x32Ut3nEfRH+vhoZGvN72+dQ/snVXo/vMFLdQ=
326326
github.com/danieljoos/wincred v1.2.3/go.mod h1:6qqX0WNrS4RzPZ1tnroDzq9kY3fu1KwE7MRLQK4X0bs=
327327
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
@@ -441,15 +441,23 @@ github.com/go-errors/errors v1.4.2 h1:J6MZopCL4uSllY1OfXM374weqZFFItUbrImctkmUxI
441441
github.com/go-errors/errors v1.4.2/go.mod h1:sIVyrIiJhuEF+Pj9Ebtd6P/rEYROXFi3BopGUQ5a5Og=
442442
github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 h1:+zs/tPmkDkHx3U66DAb0lQFJrpS6731Oaa12ikc+DiI=
443443
github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376/go.mod h1:an3vInlBmSxCcxctByoQdvwPiA7DTK7jaaFDBTtu0ic=
444+
github.com/go-git/gcfg/v2 v2.0.2 h1:MY5SIIfTGGEMhdA7d7JePuVVxtKL7Hp+ApGDJAJ7dpo=
445+
github.com/go-git/gcfg/v2 v2.0.2/go.mod h1:/lv2NsxvhepuMrldsFilrgct6pxzpGdSRC13ydTLSLs=
444446
github.com/go-git/go-billy/v5 v5.4.1/go.mod h1:vjbugF6Fz7JIflbVpl1hJsGjSHNltrSw45YK/ukIvQg=
445447
github.com/go-git/go-billy/v5 v5.5.0/go.mod h1:hmexnoNsr2SJU1Ju67OaNz5ASJY3+sHgFRpCtpDCKow=
446448
github.com/go-git/go-billy/v5 v5.8.0 h1:I8hjc3LbBlXTtVuFNJuwYuMiHvQJDq1AT6u4DwDzZG0=
447449
github.com/go-git/go-billy/v5 v5.8.0/go.mod h1:RpvI/rw4Vr5QA+Z60c6d6LXH0rYJo0uD5SqfmrrheCY=
450+
github.com/go-git/go-billy/v6 v6.0.0-20260328065524-593ae452e14d h1:bLMI9z4mKkfQO383+O3fkP4xdWQcMdnn5fFBMwaBC1M=
451+
github.com/go-git/go-billy/v6 v6.0.0-20260328065524-593ae452e14d/go.mod h1:LLeMBFApkgIKwMzirxpU9XB7NvO2HdTw5FXmeP1M6c8=
448452
github.com/go-git/go-git-fixtures/v4 v4.3.2-0.20231010084843-55a94097c399 h1:eMje31YglSBqCdIqdhKBW8lokaMrL3uTkpGYlE2OOT4=
449453
github.com/go-git/go-git-fixtures/v4 v4.3.2-0.20231010084843-55a94097c399/go.mod h1:1OCfN199q1Jm3HZlxleg+Dw/mwps2Wbk9frAWm+4FII=
454+
github.com/go-git/go-git-fixtures/v6 v6.0.0-20260405195209-b16dd39735e0 h1:XoTsdvaghuVfIr7HpNTmFDLu2nz3I2iGqyn6Uk6MkJc=
455+
github.com/go-git/go-git-fixtures/v6 v6.0.0-20260405195209-b16dd39735e0/go.mod h1:1Lr7/vYEYyl6Ir9Ku0tKrCIRreM5zovv0Jdx2MPSM4s=
450456
github.com/go-git/go-git/v5 v5.11.0/go.mod h1:6GFcX2P3NM7FPBfpePbpLd21XxsgdAt+lKqXmCUiUCY=
451457
github.com/go-git/go-git/v5 v5.18.0 h1:O831KI+0PR51hM2kep6T8k+w0/LIAD490gvqMCvL5hM=
452458
github.com/go-git/go-git/v5 v5.18.0/go.mod h1:pW/VmeqkanRFqR6AljLcs7EA7FbZaN5MQqO7oZADXpo=
459+
github.com/go-git/go-git/v6 v6.0.0-alpha.2 h1:T3loNtDuAixNzXtlQxZhnYiYpaQ3CA4vn9RssAniEeI=
460+
github.com/go-git/go-git/v6 v6.0.0-alpha.2/go.mod h1:oCD3i19CTz7gBpeb11ZZqL91WzqbMq9avn5KpUYy/Ak=
453461
github.com/go-gl/glfw v0.0.0-20190409004039-e6da0acd62b1/go.mod h1:vR7hzQXu2zJy9AVAgeJqvqgH9Q5CA+iKCZ2gyEVpxRU=
454462
github.com/go-gl/glfw/v3.3/glfw v0.0.0-20191125211704-12ad95a8df72/go.mod h1:tQ2UAYgL5IevRw8kRxooKSPJfGvJ9fJQFa0TUsXzTg8=
455463
github.com/go-gl/glfw/v3.3/glfw v0.0.0-20200222043503-6f7a984d4dc4/go.mod h1:tQ2UAYgL5IevRw8kRxooKSPJfGvJ9fJQFa0TUsXzTg8=
@@ -816,8 +824,9 @@ github.com/jstemmer/go-junit-report v0.9.1/go.mod h1:Brl9GWCQeLvo8nXZwPNNblvFj/X
816824
github.com/jtolds/gls v4.20.0+incompatible/go.mod h1:QJZ7F/aHp+rZTRtaJ1ow/lLfFfVYBRgL+9YlvaHOwJU=
817825
github.com/julienschmidt/httprouter v1.2.0/go.mod h1:SYymIcj16QtmaHHD7aYtjjsJG7VTCxuUUipMqKk8s4w=
818826
github.com/julienschmidt/httprouter v1.3.0/go.mod h1:JR6WtHb+2LUe8TCKY3cZOxFyyO8IZAc4RVcycCCAKdM=
819-
github.com/kevinburke/ssh_config v1.2.0 h1:x584FjTGwHzMwvHx18PXxbBVzfnxogHaAReU4gf13a4=
820827
github.com/kevinburke/ssh_config v1.2.0/go.mod h1:CT57kijsi8u/K/BOFA39wgDQJ9CxiF4nAY/ojJ6r6mM=
828+
github.com/kevinburke/ssh_config v1.6.0 h1:J1FBfmuVosPHf5GRdltRLhPJtJpTlMdKTBjRgTaQBFY=
829+
github.com/kevinburke/ssh_config v1.6.0/go.mod h1:q2RIzfka+BXARoNexmF9gkxEX7DmvbW9P4hIVx2Kg4M=
821830
github.com/keybase/go-keychain v0.0.1 h1:way+bWYa6lDppZoZcgMbYsvC7GxljxrskdNInRtuthU=
822831
github.com/keybase/go-keychain v0.0.1/go.mod h1:PdEILRW3i9D8JcdM+FmY6RwkHGnhHxXwkPPMeUgOK1k=
823832
github.com/kisielk/errcheck v1.1.0/go.mod h1:EZBBE59ingxPouuu3KfxchcWSUPOHkagtvWXihfKN4Q=
@@ -830,8 +839,8 @@ github.com/klauspost/compress v1.18.4 h1:RPhnKRAQ4Fh8zU2FY/6ZFDwTVTxgJ/EMydqSTzE
830839
github.com/klauspost/compress v1.18.4/go.mod h1:R0h/fSBs8DE4ENlcrlib3PsXS61voFxhIs2DeRhCvJ4=
831840
github.com/klauspost/cpuid v1.2.0/go.mod h1:Pj4uuM528wm8OyEC2QMXAi2YiTZ96dNQPGgoMS4s3ek=
832841
github.com/klauspost/cpuid/v2 v2.0.1/go.mod h1:FInQzS24/EEf25PyTYn52gqo7WaD8xa0213Md/qVLRg=
833-
github.com/klauspost/cpuid/v2 v2.2.5 h1:0E5MSMDEoAulmXNFquVs//DdoomxaoTY1kUhbc/qbZg=
834-
github.com/klauspost/cpuid/v2 v2.2.5/go.mod h1:Lcz8mBdAVJIBVzewtcLocK12l3Y+JytZYpaMropDUws=
842+
github.com/klauspost/cpuid/v2 v2.3.0 h1:S4CRMLnYUhGeDFDqkGriYKdfoFlDnMtqTiI/sFzhA9Y=
843+
github.com/klauspost/cpuid/v2 v2.3.0/go.mod h1:hqwkgyIinND0mEev00jJYCxPNVRVXFQeu1XKlok6oO0=
835844
github.com/klauspost/pgzip v1.2.6 h1:8RXeL5crjEUFnR2/Sn6GJNWtSQ3Dk8pq4CL3jvdDyjU=
836845
github.com/klauspost/pgzip v1.2.6/go.mod h1:Ch1tH69qFZu15pkjo5kYi6mth2Zzwzt50oCQKQE9RUs=
837846
github.com/konsorten/go-windows-terminal-sequences v1.0.1/go.mod h1:T0+1ngSBFLxvqU3pZ+m/2kptfBszLMUkC4ZK/EgS/cQ=
@@ -1097,8 +1106,8 @@ github.com/pierrec/lz4/v4 v4.1.22/go.mod h1:gZWDp/Ze/IJXGXf23ltt2EXimqmTUXEy0GFu
10971106
github.com/pingcap/errors v0.11.4 h1:lFuQV/oaUMGcD2tqt+01ROSmJs75VG1ToEOkZIZ4nE4=
10981107
github.com/pingcap/errors v0.11.4/go.mod h1:Oi8TUi2kEtXXLMJk9l1cGmz20kV3TaQ0usTwv5KuLY8=
10991108
github.com/pjbgf/sha1cd v0.3.0/go.mod h1:nZ1rrWOcGJ5uZgEEVL1VUM9iRQiZvWdbZjkKyFzPPsI=
1100-
github.com/pjbgf/sha1cd v0.3.2 h1:a9wb0bp1oC2TGwStyn0Umc/IGKQnEgF0vVaZ8QF8eo4=
1101-
github.com/pjbgf/sha1cd v0.3.2/go.mod h1:zQWigSxVmsHEZow5qaLtPYxpcKMMQpa09ixqBxuCS6A=
1109+
github.com/pjbgf/sha1cd v0.5.0 h1:a+UkboSi1znleCDUNT3M5YxjOnN1fz2FhN48FlwCxs0=
1110+
github.com/pjbgf/sha1cd v0.5.0/go.mod h1:lhpGlyHLpQZoxMv8HcgXvZEhcGs0PG/vsZnEJ7H0iCM=
11021111
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c h1:+mdjkGKdHQG3305AYmdv1U2eRNDiU2ErMBj1gwrq8eQ=
11031112
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c/go.mod h1:7rwL4CYBLnjLxUqIJNnCWiEdr3bn6IUYi15bNlnbCCU=
11041113
github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsKMEsNbx1VGcRFpLqf3715MtcvvzbA=

pkg/attestation/crafter/crafter.go

Lines changed: 3 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ import (
3535
"github.com/chainloop-dev/chainloop/pkg/attestation/crafter/runners/commitverification"
3636
"github.com/chainloop-dev/chainloop/pkg/casclient"
3737
"github.com/chainloop-dev/chainloop/pkg/policies"
38-
"github.com/go-git/go-git/v5"
39-
"github.com/go-git/go-git/v5/plumbing"
38+
"github.com/go-git/go-git/v6"
39+
"github.com/go-git/go-git/v6/plumbing"
4040
"github.com/google/go-containerregistry/pkg/authn"
4141
intoto "github.com/in-toto/attestation/go/v1"
4242
"github.com/rs/zerolog"
@@ -305,9 +305,6 @@ type CommitRemote struct {
305305
Name, URL string
306306
}
307307

308-
// This error is not exposed by go-git
309-
var errBranchInvalidMerge = errors.New("branch config: invalid merge")
310-
311308
// Returns the current directory git commit hash if possible
312309
// If we are not in a git repo it will return an empty string
313310
func gracefulGitRepoHead(path string, logger *zerolog.Logger) (*HeadCommit, error) {
@@ -317,10 +314,7 @@ func gracefulGitRepoHead(path string, logger *zerolog.Logger) (*HeadCommit, erro
317314
}
318315

319316
repo, err := git.PlainOpenWithOptions(path, &git.PlainOpenOptions{
320-
// walk up the directory tree until we find a git repo
321317
DetectDotGit: true,
322-
// enable .git/commondir support so worktrees can resolve HEAD
323-
EnableDotGitCommonDir: true,
324318
})
325319

326320
if err != nil {
@@ -334,15 +328,6 @@ func gracefulGitRepoHead(path string, logger *zerolog.Logger) (*HeadCommit, erro
334328
return nil, nil
335329
}
336330

337-
// Mitigate https://github.com/go-git/go-git/issues/331
338-
// This error is not exposed by go-git so we do a string comparison.
339-
// The upcoming go-git v6 no longer returns this error, so this
340-
// workaround can be removed after upgrading.
341-
if isBranchInvalidMergeError(err) {
342-
logger.Warn().Err(err).Msg("branch is invalid merge, skipping commit")
343-
return nil, nil
344-
}
345-
346331
return nil, fmt.Errorf("opening repository: %w", err)
347332
}
348333

@@ -366,20 +351,11 @@ func gracefulGitRepoHead(path string, logger *zerolog.Logger) (*HeadCommit, erro
366351
Date: commit.Author.When,
367352
Message: commit.Message,
368353
Remotes: make([]*CommitRemote, 0),
369-
Signature: commit.PGPSignature,
354+
Signature: commit.Signature,
370355
}
371356

372357
remotes, err := repo.Remotes()
373358
if err != nil {
374-
// go-git does an additional validation that the branch is pushed upstream
375-
// we do not care about that use-case, so we ignore the error
376-
// we compare by error string because go-git does not expose the error type
377-
// and errors.Is require the same instance of the error
378-
if isBranchInvalidMergeError(err) {
379-
logger.Warn().Err(err).Msg("branch is invalid merge, skipping remotes")
380-
return c, nil
381-
}
382-
383359
return nil, fmt.Errorf("getting remotes: %w", err)
384360
}
385361

@@ -402,10 +378,6 @@ func gracefulGitRepoHead(path string, logger *zerolog.Logger) (*HeadCommit, erro
402378
return c, nil
403379
}
404380

405-
func isBranchInvalidMergeError(err error) bool {
406-
return err.Error() == errBranchInvalidMerge.Error()
407-
}
408-
409381
// Clear any basic auth credentials from the remote URL
410382
func sanitizeRemoteURL(remoteURL string) (string, error) {
411383
uri, err := url.Parse(remoteURL)

pkg/attestation/crafter/crafter_test.go

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,9 @@ import (
3636
"github.com/chainloop-dev/chainloop/pkg/casclient"
3737
mUploader "github.com/chainloop-dev/chainloop/pkg/casclient/mocks"
3838

39-
"github.com/go-git/go-git/v5"
40-
"github.com/go-git/go-git/v5/plumbing/object"
39+
"github.com/go-git/go-git/v6"
40+
"github.com/go-git/go-git/v6/config"
41+
"github.com/go-git/go-git/v6/plumbing/object"
4142
"github.com/stretchr/testify/assert"
4243
"github.com/stretchr/testify/require"
4344
"github.com/stretchr/testify/suite"
@@ -504,6 +505,12 @@ func (s *crafterSuite) SetupTest() {
504505
s.repoPath = s.T().TempDir()
505506
repo, err := git.PlainInit(s.repoPath, false)
506507
require.NoError(s.T(), err)
508+
509+
cfg, err := repo.Config()
510+
require.NoError(s.T(), err)
511+
cfg.Commit.GpgSign = config.NewOptBool(false)
512+
require.NoError(s.T(), repo.SetConfig(cfg))
513+
507514
wt, err := repo.Worktree()
508515
require.NoError(s.T(), err)
509516

pkg/attestation/crafter/crafter_unit_test.go

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ import (
2424
"time"
2525

2626
api "github.com/chainloop-dev/chainloop/pkg/attestation/crafter/api/attestation/v1"
27-
"github.com/go-git/go-git/v5"
28-
"github.com/go-git/go-git/v5/config"
29-
"github.com/go-git/go-git/v5/plumbing/object"
27+
"github.com/go-git/go-git/v6"
28+
"github.com/go-git/go-git/v6/config"
29+
"github.com/go-git/go-git/v6/plumbing/object"
3030
"github.com/stretchr/testify/assert"
3131
"github.com/stretchr/testify/require"
3232
"github.com/stretchr/testify/suite"
@@ -79,6 +79,15 @@ func (s *crafterUnitSuite) TestSanitizeRemoteURI() {
7979
}
8080
}
8181

82+
func disableGPGSign(repo *git.Repository) error {
83+
cfg, err := repo.Config()
84+
if err != nil {
85+
return err
86+
}
87+
cfg.Commit.GpgSign = config.NewOptBool(false)
88+
return repo.SetConfig(cfg)
89+
}
90+
8291
func (s *crafterUnitSuite) TestGitRepoHead() {
8392
initRepo := func(withCommit bool) func(string) (*HeadCommit, error) {
8493
return func(repoPath string) (*HeadCommit, error) {
@@ -87,6 +96,10 @@ func (s *crafterUnitSuite) TestGitRepoHead() {
8796
return nil, err
8897
}
8998

99+
if err := disableGPGSign(repo); err != nil {
100+
return nil, err
101+
}
102+
90103
_, err = repo.CreateRemote(&config.RemoteConfig{
91104
Name: "origin",
92105
URLs: []string{"git@cyberdyne.com:skynet.git"},
@@ -328,6 +341,8 @@ func (s *crafterUnitSuite) TestGitRepoHeadWorktree() {
328341
repo, err := git.PlainInit(repoPath, false)
329342
require.NoError(s.T(), err)
330343

344+
require.NoError(s.T(), disableGPGSign(repo))
345+
331346
_, err = repo.CreateRemote(&config.RemoteConfig{
332347
Name: "origin",
333348
URLs: []string{"git@cyberdyne.com:skynet.git"},

0 commit comments

Comments
 (0)