Asset ImageFetcher thread correctness in DEBUG builds (facebook#54487)

Summary:

Changelog: [Internal]

Differential Revision: D86678354

Author: christophpurrer

packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageFetcher.cpp

@@ -17,10 +17,19 @@ extern const char ImageFetcherKey[] = "ImageFetcher";
 
 ImageFetcher::ImageFetcher(
     std::shared_ptr<const ContextContainer> contextContainer)
-    : contextContainer_(std::move(contextContainer)) {}
+    : contextContainer_(std::move(contextContainer))
+#ifdef REACT_NATIVE_DEBUG
+      ,
+      threadId_(std::this_thread::get_id())
+#endif
+{
+}
 
 ImageFetcher::~ImageFetcher() noexcept {
   if (ReactNativeFeatureFlags::enableImagePrefetchingJNIBatchingAndroid()) {
+#ifdef REACT_NATIVE_DEBUG
+    assertThread();
+#endif
     contextContainer_->erase(ImageFetcherKey);
   }
 }
@@ -68,4 +77,12 @@ void ImageFetcher::flushImageRequests() {
   items_.clear();
 }
 
+#ifdef REACT_NATIVE_DEBUG
+void ImageFetcher::assertThread() const {
+  assert(
+      threadId_ == std::this_thread::get_id() &&
+      "ImageFetcher method called from the wrong thread!");
+}
+#endif
+
 } // namespace facebook::react

packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageFetcher.h

@@ -13,6 +13,9 @@
 #include <memory>
 #include <unordered_map>
 #include <vector>
+#ifdef REACT_NATIVE_DEBUG
+#include <thread>
+#endif
 
 namespace facebook::react {
 
@@ -39,5 +42,10 @@ class ImageFetcher {
 
   std::unordered_map<SurfaceId, std::vector<ImageRequestItem>> items_;
   std::shared_ptr<const ContextContainer> contextContainer_;
+
+#ifdef REACT_NATIVE_DEBUG
+  std::thread::id threadId_;
+  void assertThread() const;
+#endif
 };
 } // namespace facebook::react