SGF containing `;)` will break wgo

[climu]

This game for instance: https://openstudyroom.org/league/games/7061/

produce:

The sgf contain this line GoDave89: wanna review? ;)
Removing the ;) fix it.

Wgo have an a unmerged PR about that here.

I am contemplating removing such characters client side with js before feeding wgo.

[climu]

The js is here:

openstudyroom/league/templates/league/archives_games.html

Lines 7 to 29 in d1979e1

	function load_game(sgf_id) {
	var url = "/league/game/json/" + sgf_id
	$.ajax({
	type: "GET",
	url: "/league/game/json/" + sgf_id,
	dataType: "json",
	success: processData,
	error: function(){ alert("failed"); }
	});
	function processData(data)
	{
	document.getElementById("game_infos").innerHTML= data.game_infos ;
	var elem = document.getElementById("player");
	var player = new WGo.BasicPlayer(elem, {
	sgf: data.sgf
	});
	window.history.pushState('page2', 'Title', data.permalink);
	document.getElementById("game-header").innerHTML= ' - ' + data.white + ' vs ' + data.black;
	document.title ='Archives - Games - '+ data.white + ' vs ' + data.black + ' - Open Study Room';
	};
	return false;};

But on second thought I think I will do that server side here:

openstudyroom/league/views.py

Lines 641 to 664 in d1979e1

	def game_api(request, sgf_id, event_id=None):
	"""Returns a json to be use in game pages. Json is formated as:
	'infos': players, date, league, group, permalink, download link.
	'sgf': sgf datas as plain text string
	"""
	sgf = get_object_or_404(Sgf, pk=sgf_id)
	event = None
	if event_id is not None:
	event = get_object_or_404(LeagueEvent, pk=event_id)
	html = loader.render_to_string(
	"league/includes/game_info.html",
	{'sgf': sgf, 'event': event}
	)
	data = {}
	data['sgf'] = sgf.sgf_text.replace(';B[]', "").replace(';W[]', "")
	data['permalink'] = '/league/games/' + str(sgf.pk) + '/'
	data['game_infos'] = html
	data['white'] = sgf.white.username
	data['black'] = sgf.black.username
	data['id'] = str(sgf.pk)
	return HttpResponse(json.dumps(data), content_type="application/json")

This was introduced to fix some similar wgo bugs data['sgf'] = sgf.sgf_text.replace(';B[]', "").replace(';W[]', "").

[climu]

https://openstudyroom.org/league/games/7201/

That too ;-)