chore: gritty: lint

Author: coderaiser

.github/workflows/nodejs.yml

@@ -8,9 +8,8 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - 14.x
           - 16.x
-          - 17.x
+          - 18.x
     steps:
       - uses: actions/checkout@v2
       - name: Use Node.js ${{ matrix.node-version }}

.gitignore

@@ -10,3 +10,4 @@ dist-dev
 
 *.swp
 
+.idea

README.md

@@ -1,10 +1,8 @@
-# Gritty [![License][LicenseIMGURL]][LicenseURL] [![NPM version][NPMIMGURL]][NPMURL] [![Dependency Status][DependencyStatusIMGURL]][DependencyStatusURL] [![Build Status][BuildStatusIMGURL]][BuildStatusURL] [![Coverage Status][CoverageIMGURL]][CoverageURL]
+# Gritty [![License][LicenseIMGURL]][LicenseURL] [![NPM version][NPMIMGURL]][NPMURL] [![Build Status][BuildStatusIMGURL]][BuildStatusURL] [![Coverage Status][CoverageIMGURL]][CoverageURL]
 
 [NPMIMGURL]: https://img.shields.io/npm/v/gritty.svg?style=flat&longCache=true
 [BuildStatusURL]: https://github.com/cloudcmd/gritty/actions?query=workflow%3A%22Node+CI%22 "Build Status"
 [BuildStatusIMGURL]: https://github.com/cloudcmd/gritty/workflows/Node%20CI/badge.svg
-[DependencyStatusURL]: https://david-dm.org/cloudcmd/gritty "Dependency Status"
-[DependencyStatusIMGURL]: https://img.shields.io/david/cloudcmd/gritty.svg?style=flat&longCache=true
 [LicenseIMGURL]: https://img.shields.io/badge/license-MIT-317BF9.svg?style=flat&longCache=true
 [NPM_INFO_IMG]: https://nodei.co/npm/cloudcmd.png
 [NPMURL]: https://npmjs.org/package/cloudcmd "npm"
@@ -161,4 +159,3 @@ server.listen(port, ip);
 ## License
 
 MIT
-

bin/gritty.js

@@ -73,8 +73,8 @@ function start(options) {
     const app = express();
     const server = http.createServer(app);
 
-    const ip = process.env.IP || /* c9 */
-              '0.0.0.0';
+    const ip = process.env.IP /* c9 */
+              || '0.0.0.0';
 
     app.use(gritty())
         .use(express.static(DIR));

client/get-el.js

@@ -1,7 +1,9 @@
 'use strict';
 
+const isString = (a) => typeof a === 'string';
+
 module.exports = (el) => {
-    if (typeof el === 'string')
+    if (isString(el))
         return document.querySelector(el);
 
     return el;

client/get-env.js

@@ -1,5 +1,7 @@
 'use strict';
 
+const isFn = (a) => typeof a === 'function';
+
 module.exports = (env) => {
     const obj = {};
 
@@ -11,7 +13,7 @@ module.exports = (env) => {
 };
 
 function getValue(value) {
-    if (typeof value === 'function')
+    if (isFn(value))
         return value();
 
     return value;

client/gritty.js

@@ -12,16 +12,16 @@ const getHost = require('./get-host');
 const getEnv = require('./get-env');
 const wrap = require('wraptile');
 
-const onConnect = wrap(_onConnect);
-const onDisconnect = wrap(_onDisconnect);
-const onData = currify(_onData);
-const onTermResize = currify(_onTermResize);
-const onTermData = currify(_onTermData);
+const {io} = require('socket.io-client');
+const {Terminal} = require('xterm');
 const onWindowResize = wrap(_onWindowResize);
+const onTermData = currify(_onTermData);
+const onTermResize = currify(_onTermResize);
+const onData = currify(_onData);
 
-const {io} = require('socket.io-client');
+const onDisconnect = wrap(_onDisconnect);
 
-const {Terminal} = require('xterm');
+const onConnect = wrap(_onConnect);
 
 module.exports = gritty;
 module.exports._onConnect = _onConnect;

server/gritty.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const DIR_ROOT = __dirname + '/..';
+const isBool = (a) => typeof a === 'boolean';
 
 const path = require('path');
 const log = require('debug')('gritty');
@@ -11,6 +11,8 @@ const wraptile = require('wraptile');
 const pty = require('node-pty');
 const stringArgv = require('string-to-argv');
 
+const DIR_ROOT = __dirname + '/..';
+
 const terminalFn = currify(_terminalFn);
 const connectionWraped = wraptile(connection);
 
@@ -25,10 +27,10 @@ const getDist = () => {
 };
 
 const choose = (a, b, options) => {
-    if (typeof a === 'boolean')
+    if (isBool(a))
         return a;
 
-    if (typeof b === 'boolean')
+    if (isBool(b))
         return b;
 
     return options.default;

test/before.js

@@ -1,5 +1,7 @@
 'use strict';
 
+const isFn = (a) => typeof a === 'function';
+
 const http = require('http');
 const {promisify} = require('util');
 
@@ -11,7 +13,7 @@ const gritty = require('..');
 module.exports = before;
 
 function before(options, fn = options) {
-    if (typeof options === 'function')
+    if (isFn(options))
         options = {};
 
     const app = express();

test/client/get-el.js

@@ -1,7 +1,9 @@
 'use strict';
 
-const test = require('supertape');
-const stub = require('@cloudcmd/stub');
+const {
+    test,
+    stub,
+} = require('supertape');
 
 const getEl = require('../../client/get-el');