Merge #158148

158148: ts: record child metrics with low frequency poller r=jasonlmfong a=jasonlmfong

This change adds the ability to get changefeed child metrics to be recorded. The child metrics have their names augmented with their labels.

Epic: CRDB-55079
Release: None

Co-authored-by: Jason Fong <[email protected]>

Author: craig[bot]

docs/generated/metrics/metrics.yaml

@@ -150,6 +150,7 @@ func MakeMetrics(histogramWindow time.Duration) Metrics {
 			Help:        fmt.Sprintf("Total time spent throttled for %s quota", n),
 			Measurement: "Nanoseconds",
 			Unit:        metric.Unit_NANOSECONDS,
+			Category:    metric.Metadata_CHANGEFEEDS,
 		}
 	}
 

pkg/ccl/changefeedccl/cdcutils/throttle.go

@@ -17,27 +17,31 @@ var (
 		Help:        "Time it takes to create a changefeed checkpoint",
 		Unit:        metric.Unit_NANOSECONDS,
 		Measurement: "Nanoseconds",
+		Category:    metric.Metadata_CHANGEFEEDS,
 	}
 
 	metaTotalBytes = metric.Metadata{
 		Name:        "changefeed.checkpoint.total_bytes",
 		Help:        "Total size of a changefeed checkpoint",
 		Unit:        metric.Unit_BYTES,
 		Measurement: "Bytes",
+		Category:    metric.Metadata_CHANGEFEEDS,
 	}
 
 	metaTimestampCount = metric.Metadata{
 		Name:        "changefeed.checkpoint.timestamp_count",
 		Help:        "Number of unique timestamps in a changefeed checkpoint",
 		Unit:        metric.Unit_COUNT,
 		Measurement: "Timestamps",
+		Category:    metric.Metadata_CHANGEFEEDS,
 	}
 
 	metaSpanCount = metric.Metadata{
 		Name:        "changefeed.checkpoint.span_count",
 		Help:        "Number of spans in a changefeed checkpoint",
 		Unit:        metric.Unit_COUNT,
 		Measurement: "Spans",
+		Category:    metric.Metadata_CHANGEFEEDS,
 	}
 )
 

pkg/ccl/changefeedccl/checkpoint/metrics.go

@@ -18,42 +18,49 @@ var (
 		Help:        "Total entries entering the buffer between raft and changefeed sinks",
 		Measurement: "Entries",
 		Unit:        metric.Unit_COUNT,
+		Category:    metric.Metadata_CHANGEFEEDS,
 	}
 	metaChangefeedBufferEntriesOut = metric.Metadata{
 		Name:        "changefeed.buffer_entries.out",
 		Help:        "Total entries leaving the buffer between raft and changefeed sinks",
 		Measurement: "Entries",
 		Unit:        metric.Unit_COUNT,
+		Category:    metric.Metadata_CHANGEFEEDS,
 	}
 	metaChangefeedBufferEntriesReleased = metric.Metadata{
 		Name:        "changefeed.buffer_entries.released",
 		Help:        "Total entries processed, emitted and acknowledged by the sinks",
 		Measurement: "Entries",
 		Unit:        metric.Unit_COUNT,
+		Category:    metric.Metadata_CHANGEFEEDS,
 	}
 	metaChangefeedBufferMemAcquired = metric.Metadata{
 		Name:        "changefeed.buffer_entries_mem.acquired",
 		Help:        "Total amount of memory acquired for entries as they enter the system",
 		Measurement: "Entries",
 		Unit:        metric.Unit_COUNT,
+		Category:    metric.Metadata_CHANGEFEEDS,
 	}
 	metaChangefeedBufferMemReleased = metric.Metadata{
 		Name:        "changefeed.buffer_entries_mem.released",
 		Help:        "Total amount of memory released by the entries after they have been emitted",
 		Measurement: "Entries",
 		Unit:        metric.Unit_COUNT,
+		Category:    metric.Metadata_CHANGEFEEDS,
 	}
 	metaChangefeedBufferPushbackNanos = metric.Metadata{
 		Name:        "changefeed.buffer_pushback_nanos",
 		Help:        "Total time spent waiting while the buffer was full",
 		Measurement: "Nanoseconds",
 		Unit:        metric.Unit_NANOSECONDS,
+		Category:    metric.Metadata_CHANGEFEEDS,
 	}
 	metaChangefeedAllocatedMemory = metric.Metadata{
 		Name:        "changefeed.buffer_entries.allocated_mem",
 		Help:        "Current quota pool memory allocation",
 		Measurement: "Bytes",
 		Unit:        metric.Unit_BYTES,
+		Category:    metric.Metadata_CHANGEFEEDS,
 	}
 )
 
@@ -138,6 +145,7 @@ func MakeMetrics(histogramWindow time.Duration) Metrics {
 			Help:        fmt.Sprintf("Number of %s elements added to the buffer", eventTypeName),
 			Measurement: "Events",
 			Unit:        metric.Unit_COUNT,
+			Category:    metric.Metadata_CHANGEFEEDS,
 		}
 	}
 	commonBufferMetrics := CommonBufferMetrics{