roachprod: fix service registry unit test name collision

DarrylWong · DarrylWong · commit 68a238887f99 · 2025-11-17T11:33:30.000-05:00
We were previously generating cluster names with Uint32, which is not sufficient enough to prevent naming collisions after 1000 iterations. Instead, use a RandString of length 10. Fixes: #157884 Release note: none
diff --git a/pkg/roachprod/install/services_test.go b/pkg/roachprod/install/services_test.go
@@ -138,7 +138,7 @@ func (t *serviceRegistryTest) makeVM(clusterName string, i int) vm.VM {
 }
 
 func (t *serviceRegistryTest) newCluster(nodeCount int) *SyncedCluster {
-	clusterName := fmt.Sprintf("cluster-%d", t.rng.Uint32())
+	clusterName := fmt.Sprintf("cluster-%s", randutil.RandString(t.rng, 10, randutil.PrintableKeyAlphabet))
 	c := &SyncedCluster{
 		Cluster: cloud.Cluster{
 			Name: clusterName,

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ func (t *serviceRegistryTest) makeVM(clusterName string, i int) vm.VM {`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`func (t serviceRegistryTest) newCluster(nodeCount int) SyncedCluster {`
`141`		`- clusterName := fmt.Sprintf("cluster-%d", t.rng.Uint32())`
	`141`	`+ clusterName := fmt.Sprintf("cluster-%s", randutil.RandString(t.rng, 10, randutil.PrintableKeyAlphabet))`
`142`	`142`	`c := &SyncedCluster{`
`143`	`143`	`Cluster: cloud.Cluster{`
`144`	`144`	`Name: clusterName,`