refactor(plugin-typescript): filter tsconfigs by content

Author: hanna-skryl

packages/plugin-typescript/mocks/fixtures/nx-monorepo/packages/cli/tsconfig.lib.json

@@ -1 +1,3 @@
-{}
+{
+  "include": ["src/**/*.ts"]
+}

packages/plugin-typescript/mocks/fixtures/nx-monorepo/packages/core/tsconfig.lib.json

@@ -1 +1,3 @@
-{}
+{
+  "include": ["src/**/*.ts"]
+}

packages/plugin-typescript/mocks/fixtures/nx-monorepo/packages/nx-plugin/tsconfig.lib.json

@@ -1 +1,3 @@
-{}
+{
+  "include": ["src/**/*.ts"]
+}

packages/plugin-typescript/mocks/fixtures/nx-monorepo/packages/utils/tsconfig.lib.json

@@ -1 +1,3 @@
-{}
+{
+  "include": ["src/**/*.ts"]
+}

packages/plugin-typescript/src/lib/nx/tsconfig-paths.int.test.ts

@@ -37,9 +37,9 @@ describe.skipIf(process.platform === 'win32')('Nx helpers', () => {
   });
 
   describe('tsconfigFromAllNxProjects', () => {
-    it('should find tsconfig files, filtering out empty configs and tsconfig.base.json', async () => {
-      // cli project has tsconfig.json (empty arrays, filtered), tsconfig.base.json (excluded), tsconfig.lib.json (included)
-      // other projects only have tsconfig.lib.json
+    it('should find tsconfig files with explicit include or files values', async () => {
+      // cli project has tsconfig.json (empty arrays), tsconfig.base.json (no include/files), tsconfig.lib.json (has include)
+      // other projects only have tsconfig.lib.json (has include)
       await expect(tsconfigFromAllNxProjects()).resolves.toEqual([
         'packages/cli/tsconfig.lib.json',
         'packages/core/tsconfig.lib.json',

packages/plugin-typescript/src/lib/nx/tsconfig-paths.ts

@@ -10,30 +10,22 @@ import {
 import { formatMetaLog } from '../format.js';
 
 const TSCONFIG_PATTERN = /^tsconfig(\..+)?\.json$/;
-const EXCLUDED_TSCONFIGS = new Set(['tsconfig.base.json', 'tsconfig.json']);
 
 /**
- * Matches tsconfig.*.json files, excludes tsconfig.json and tsconfig.base.json.
- */
-function isTsconfigFile(filename: string): boolean {
-  return TSCONFIG_PATTERN.test(filename) && !EXCLUDED_TSCONFIGS.has(filename);
-}
-
-/**
- * Returns false for empty configs (files and include both empty arrays).
+ * Returns true only if config explicitly defines files or include with values.
  */
 function hasFilesToCompile(tsconfigPath: string): boolean {
   const { config } = readConfigFile(tsconfigPath, sys.readFile);
 
   if (!config) {
-    return true;
+    return false;
   }
 
   const { files, include } = config;
-  const filesEmpty = Array.isArray(files) && files.length === 0;
-  const includeEmpty = Array.isArray(include) && include.length === 0;
+  const hasFiles = Array.isArray(files) && files.length > 0;
+  const hasInclude = Array.isArray(include) && include.length > 0;
 
-  return !(filesEmpty && includeEmpty);
+  return hasFiles || hasInclude;
 }
 
 function isProjectIncluded(
@@ -51,7 +43,7 @@ async function findTsconfigsInProject(projectRoot: string): Promise<string[]> {
   const files = await readdir(absoluteRoot);
 
   return files
-    .filter(isTsconfigFile)
+    .filter(file => TSCONFIG_PATTERN.test(file))
     .filter(file => hasFilesToCompile(path.join(absoluteRoot, file)))
     .map(file => path.join(projectRoot, file));
 }