feat(deps): upgrade to Spring Boot 4 #4558
Conversation
|
Hmmm ... The de.codecentric.boot.admin.client.ClientServletApplicationTest hangs forever (in my fork build) ... Is this normal? 
Locally its "working" ... 
|
|
I found a major problem ... may you guys have an idea ... Currently de.codecentric.boot.admin.client.config.SpringBootAdminClientRegistrationClientAutoConfigurationTest is failing for some of the defined "what kind of RegistrationClient is used" tests ... because de.codecentric.boot.admin.client.config.SpringBootAdminClientAutoConfiguration is mixing restclient and webclient and the bean-conditions which working with sb 3.5.x are no longer working because of the new splitting of the springboot dependencies ... may I'm wrong ... 
|
|
jolokia-support-spring is also not ready yet for spring-boot 4: jolokia/jolokia#866 |
SteKoe
force-pushed
the
feat/migrate-to-springboot-4
branch
from
c6403c2 to
13573fd
Compare
SteKoe
changed the title
SteKoe
changed the title
|
I update the fork to M3 ... now some more new "incompatibilities" present ... all about jackson. For example in de.codecentric.boot.admin.server.utils.jackson.EndpointMixinTest 
The new org.springframework.boot.test.json.JacksonTester.initFields(Object, JsonMapper) accept only tools.jackson.databind.json.JsonMapper from jackson-databind-3.0.0-rc9. I can't find anything in spring's migration guide for this changes :-( https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-4.0-Migration-Guide |
TODO: Fix Autoconfiguration for RegistrationClient
ahoehma
force-pushed
the
feat/migrate-to-springboot-4
branch
from
06958f3 to
e9f78f0
Compare
|
I rebased #4838 in my fork as well. |
ahoehma
force-pushed
the
feat/migrate-to-springboot-4
branch
from
4ccf0e6 to
4a96e55
Compare
ahoehma
force-pushed
the
feat/migrate-to-springboot-4
branch
from
4a96e55 to
95253b1
Compare
…he test is also waiting for 60 seconds in StepVerifier, so the client should support that.
…nts. Restored proper CountDownLatch synchronization with corrected interrupt handling to ensure instance registration completes before assertions attempt to read the registered ID.
…around Reactor 3.8.0 blocking detection
…ve threads to prevent flaky tests with webclient
|
Hi @SteKoe ... I have a question regarding copyright and licensing. My project is currently migrating to Spring Boot 4. To enable our builds, I plan to build the code from [this fork] (and/or the Spring Boot 4 migration MR) and publish the resulting artifact to our internal Artifactory, so it can be consumed by our GitLab pipeline. Thank you in advance for your guidance. |
- I did "mvn install -DskipTests=true -nsu -Dcheckstyle.skip=false -pl '!spring-boot-admin-docs'" - spring-boot-admin-docs doesn't build successfully no glue why
…re.MailSenderAutoConfiguration] - some tests failing because of missing MailSenderAutoConfiguration - adding spring-boot-starter-mail in test-scope
- the CountDownLatch.await should have a timeout too
…re.MailSenderAutoConfiguration] - some tests failing because of missing MailSenderAutoConfiguration - adding spring-boot-starter-mail in test-scope
- wee need both starters because of import of RestTemplateAutoConfiguration, RestClientAutoConfiguration and WebClientAutoConfiguration in SpringBootAdminClientAutoConfiguration - locally (win 11, gitbash, eclipse) ClientServletApplicationTest not working, the --spring.jackson.property-naming-strategy=SNAKE_CASE is not used (no glue why) - in github build its working - why is this? - locally SpringBootAdminClientRegistrationClientAutoConfigurationTest is also not working 100% - a lot of "wrong" RegistrationClient are created, doesn't matter which "builders" are in the spring context - in github build its working - why is this?
- I did "mvn install -DskipTests=true -nsu -Dcheckstyle.skip=false -pl '!spring-boot-admin-docs'" - spring-boot-admin-docs doesn't build successfully no glue why
- wee need both starters because of import of RestTemplateAutoConfiguration, RestClientAutoConfiguration and WebClientAutoConfiguration in SpringBootAdminClientAutoConfiguration - locally (win 11, gitbash, eclipse) ClientServletApplicationTest not working, the --spring.jackson.property-naming-strategy=SNAKE_CASE is not used (no glue why) - in github build its working - why is this? - locally SpringBootAdminClientRegistrationClientAutoConfigurationTest is also not working 100% - a lot of "wrong" RegistrationClient are created, doesn't matter which "builders" are in the spring context - in github build its working - why is this?
- cleaned also all "invalid" code-formattings from previous commits - one big problem in spring-boot-admin-server jackson's databind module 3.0.0-rc9 was included into spring which conflicts here and there with the old jackson stuff?!
ahoehma
force-pushed
the
feat/migrate-to-springboot-4
branch
from
95253b1 to
4c5bef6
Compare
|
Hi @ahoehma Spring Boot Admin is licensed under Apache 2 License: https://github.com/codecentric/spring-boot-admin?tab=Apache-2.0-1-ov-file#readme So from License perspective there should be no problem. Please note that we cannot give legal advice and don't know your compliance requirements. |
5 participants
No description provided.