refactor: using filter_var

Author: ddevsr

system/Session/Handlers/RedisHandler.php

@@ -142,7 +142,7 @@ protected function setSavePath(): void
             }
         }
 
-        $persistent = isset($query['persistent']) ? (bool) $query['persistent'] : null;
+        $persistent = filter_var($query['persistent'], FILTER_VALIDATE_BOOLEAN) ? (bool) $query['persistent'] : null;
         $password   = $query['auth'] ?? null;
         $database   = isset($query['database']) ? (int) $query['database'] : 0;
         $timeout    = isset($query['timeout']) ? (float) $query['timeout'] : 0.0;

tests/system/Session/Handlers/Database/RedisHandlerTest.php

@@ -261,6 +261,28 @@ public static function provideSetSavePath(): iterable
                     'persistent' => false,
                 ],
             ],
+            'persistent connection with true' => [
+                'tcp://127.0.0.1:6379?timeout=10&persistent=true',
+                [
+                    'host'       => 'tcp://127.0.0.1',
+                    'port'       => 6379,
+                    'password'   => null,
+                    'database'   => 0,
+                    'timeout'    => 10.0,
+                    'persistent' => true,
+                ],
+            ],
+            'persistent connection with false' => [
+                'tcp://127.0.0.1:6379?timeout=10&persistent=false',
+                [
+                    'host'       => 'tcp://127.0.0.1',
+                    'port'       => 6379,
+                    'password'   => null,
+                    'database'   => 0,
+                    'timeout'    => 10.0,
+                    'persistent' => false,
+                ],
+            ],
         ];
     }
 }