feat(new homepage navigation): add section "my notes" to homepage navigation #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
requested changes
Nov 8, 2025
Member
neSpecc
left a comment
neSpecc
left a comment
There was a problem hiding this comment.
some big parts of code are duplicated. For example getMyNoteList duplicates getNoteList.
Get rid of code repetition. And reuse existing code
neSpecc
reviewed
Nov 9, 2025
src/presentation/pages/Home.vue
Outdated
Comment on lines
3
to
15
| <div v-if="user === null"> | ||
| <Container data-dimensions="large"> | ||
| <Row :title="t('home.authText')"> | ||
| <template #right> | ||
| <Button | ||
| @click="showGoogleAuthPopup" | ||
| > | ||
| {{ t('auth.login') }} | ||
| </Button> | ||
| </template> | ||
| </Row> | ||
| </Container> | ||
| </div> |
Member
There was a problem hiding this comment.
all page content should be wrapped with <PageBlock>
src/presentation/pages/Home.vue
Outdated
|
|
||
| <!-- Authorized users --> | ||
| <PageBlock | ||
| v-else-if="user !== undefined" |
Member
There was a problem hiding this comment.
move to computed variable with clear name
src/presentation/pages/Home.vue
Outdated
Comment on lines
56
to
75
| <template v-if="activeMenuItem === 'recents'"> | ||
| <Heading | ||
| :level="1" | ||
| :class="$style['page-header']" | ||
| > | ||
| {{ t('home.sections.recents.title') }} | ||
| </Heading> | ||
| <NoteList /> | ||
| </template> | ||
|
|
||
| <!-- My notes content --> | ||
| <template v-else-if="activeMenuItem === 'myNotes'"> | ||
| <Heading | ||
| :level="1" | ||
| :class="$style['page-header']" | ||
| > | ||
| {{ t('home.sections.myNotes.title') }} | ||
| </Heading> | ||
| <NoteList :only-created-by-user="true" /> | ||
| </template> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a new “My Notes” section in the homepage navigation, allowing authenticated users to view notes they have created directly from the home page.
Details
Purpose
Enhances the homepage UX by providing quick access to the user’s own notes, improving navigation and note management workflow.
Preview