Skip to content

Commit 4a1d0f8

Browse files
Revision 3: Use TemplateUtils.newST to prevent memory leaks
1 parent 7c1f7f5 commit 4a1d0f8

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2335,7 +2335,7 @@ public Mono<Void> bulkUpdate(@NonNull Set<UUID> ids, @NonNull SpanUpdate update,
23352335
}
23362336

23372337
private ST newBulkUpdateTemplate(SpanUpdate spanUpdate, String sql, boolean mergeTags) {
2338-
var template = new ST(sql);
2338+
var template = TemplateUtils.newST(sql);
23392339

23402340
if (StringUtils.isNotBlank(spanUpdate.name())) {
23412341
template.add("name", spanUpdate.name());

apps/opik-backend/src/main/java/com/comet/opik/domain/TraceDAO.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3600,7 +3600,7 @@ public Mono<Void> bulkUpdate(@NonNull Set<UUID> ids, @NonNull TraceUpdate update
36003600
}
36013601

36023602
private ST newBulkUpdateTemplate(TraceUpdate traceUpdate, String sql, boolean mergeTags) {
3603-
var template = new ST(sql);
3603+
var template = TemplateUtils.newST(sql);
36043604

36053605
if (StringUtils.isNotBlank(traceUpdate.name())) {
36063606
template.add("name", traceUpdate.name());

apps/opik-backend/src/main/java/com/comet/opik/domain/threads/TraceThreadDAO.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -651,7 +651,7 @@ public Mono<Void> bulkUpdate(@NonNull List<UUID> ids, @NonNull TraceThreadUpdate
651651
}
652652

653653
private ST newBulkUpdateTemplate(TraceThreadUpdate update, String sql, boolean mergeTags) {
654-
var template = new ST(sql);
654+
var template = TemplateUtils.newST(sql);
655655

656656
Optional.ofNullable(update.tags())
657657
.ifPresent(tags -> {

0 commit comments

Comments
 (0)