Skip to content

Test gap: no coverage for estimateRequiredFee() (src/soroban.ts) #461

Description

@Jaydbrown

estimateRequiredFee() in src/soroban.ts has no dedicated test under src/tests/. This is directly relevant: this function's fallback behavior is the root cause of a separate filed bug where InsufficientBalanceError overstates the required balance by ~500 XLM in the common case (a WasmVm/InvalidAction simulation error, which carries neither minResourceFee nor fee, always falls through to the 5_000_000_000n fallback). A test asserting the fallback value and the extraction logic for both minResourceFee and fee shapes would have surfaced that the fallback is reached far more often than intended.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions