-
Notifications
You must be signed in to change notification settings - Fork 19
Use Gemini for text review #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Hi @adams85, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 I'm sorry @adams85, but I was unable to process your request. Please see the logs for more details. |
Deploying configcat-docs with
|
| Latest commit: |
cf6debb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ec3ddab.docs-xmy.pages.dev |
| Branch Preview URL: | https://gemini-text-review.docs-xmy.pages.dev |
|
🤖 Hi @adams85, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This pull request effectively replaces the existing Copilot-based text review workflow with a new one powered by Google Gemini. The changes are well-structured, introducing new GitHub workflow files and a Gemini prompt configuration.
🔍 General Feedback
- The new workflows in
.github/workflows/are well-defined and follow good practices, such as using pinned actions for most steps. - The Gemini prompt in
.github/commands/gemini-review.tomlis comprehensive and provides clear instructions for the model. - The renaming and simplification of
GUIDELINES.mdcentralizes the official guidelines, which is a good maintainability improvement.
| uses: 'google-github-actions/run-gemini-cli@v0' # ratchet:exclude | ||
| id: 'gemini_pr_review' | ||
| env: | ||
| GITHUB_TOKEN: '${{ steps.mint_identity_token.outputs.token || secrets.GITHUB_TOKEN || github.token }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 For better security and to ensure workflow stability, it's recommended to pin the version of the google-github-actions/run-gemini-cli action to a specific commit SHA or tag instead of using a floating tag like v0.
| GITHUB_TOKEN: '${{ steps.mint_identity_token.outputs.token || secrets.GITHUB_TOKEN || github.token }}' | |
| uses: 'google-github-actions/[email protected]' # ratchet:exclude |
Describe the purpose of your pull request
Replaces Copilot for Google Gemini for automatic text review.
Related issues (only if applicable)
n/a
How to test? (only if applicable)
n/a
Requirement checklist